Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotation marks in launch.json #13325

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

eneuschild
Copy link
Contributor

Context

With the original contrib/ide/vscode/launch.json, I get the following error when trying to "Launch (with SQLite3)":

named files must be .go files: sqlite_unlock_notify"
exit status 1
Process exiting with code: 1

This is on Ubuntu Linux.

Fix

Using single quotation marks instead of escaped double quotes fixes the problem.


Additionally, the added settings.json allows running single unit tests through the Go extension.

I figured both changes are small enough to fit into one PR. ;)

@codecov-io
Copy link

Codecov Report

Merging #13325 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13325      +/-   ##
==========================================
- Coverage   42.13%   42.12%   -0.01%     
==========================================
  Files         689      689              
  Lines       75845    75845              
==========================================
- Hits        31956    31952       -4     
- Misses      38658    38661       +3     
- Partials     5231     5232       +1     
Impacted Files Coverage Δ
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e368e7...1bf5f38. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 27, 2020
@6543 6543 added the type/docs This PR mainly updates/creates documentation label Oct 27, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 27, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 27, 2020
@techknowlogick techknowlogick merged commit 6c2c521 into go-gitea:master Oct 27, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants