Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Docker container name #13077

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Improve Docker container name #13077

merged 3 commits into from
Oct 9, 2020

Conversation

melroy89
Copy link
Contributor

@melroy89 melroy89 commented Oct 8, 2020

Use a better Docker container name rather than the default 'server'

Use a better Docker container name than the default 'server'
@codecov-io
Copy link

Codecov Report

Merging #13077 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13077      +/-   ##
==========================================
+ Coverage   42.52%   42.60%   +0.07%     
==========================================
  Files         672      672              
  Lines       73788    73788              
==========================================
+ Hits        31381    31436      +55     
+ Misses      37337    37257      -80     
- Partials     5070     5095      +25     
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/queue.go 52.94% <0.00%> (-11.77%) ⬇️
services/pull/check.go 48.46% <0.00%> (-4.62%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
services/pull/patch.go 66.37% <0.00%> (-2.59%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
models/error.go 34.34% <0.00%> (-0.51%) ⬇️
modules/git/repo.go 46.19% <0.00%> (-0.51%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06ee37...661b41d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 8, 2020
@lafriks
Copy link
Member

lafriks commented Oct 8, 2020

Doesn't docker compose already prefix it with project/directory name?

@melroy89
Copy link
Contributor Author

melroy89 commented Oct 8, 2020

No it will use a automated generated name based on the service name, which is 'server'. And in my case it used the username and number. Result: melroy_server_1.

After this merge, it will be:
gitea_server

image

@silverwind
Copy link
Member

I'd prefer simply gitea over gitea_server.

@melroy89
Copy link
Contributor Author

melroy89 commented Oct 8, 2020

I'd prefer simply gitea over gitea_server.

Also fine by me.

Use `gitea` as container name. And use version 3 of the docker-compose, which should now be used: https://docs.docker.com/compose/compose-file/compose-versioning/
@melroy89
Copy link
Contributor Author

melroy89 commented Oct 8, 2020

Changed, I also moved to version 3 of docker compose, which is advised.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 9, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 9, 2020
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Oct 9, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 508aca1 into go-gitea:master Oct 9, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants