Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure db is closed in migration test #12844

Merged
merged 4 commits into from
Sep 18, 2020
Merged

Ensure db is closed in migration test #12844

merged 4 commits into from
Sep 18, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 15, 2020 •
edited

This PR try to fix missed database close.

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2020 •
edited

Codecov Report

Merging #12844 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12844   +/-   ##
=======================================
  Coverage   43.09%   43.10%           
=======================================
  Files         656      656           
  Lines       72348    72348           
=======================================
+ Hits        31179    31182    +3     
+ Misses      36117    36115    -2     
+ Partials     5052     5051    -1
Impacted Files Coverage Δ
modules/git/repo.go 46.70% <0.00%> (-1.02%) ⬇️
models/gpg_key.go 54.81% <0.00%> (-0.59%) ⬇️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
services/pull/check.go 47.69% <0.00%> (+3.07%) ⬆️
modules/indexer/stats/db.go 60.86% <0.00%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06480af...346d6eb. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 16, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 17, 2020
@zeripath zeripath changed the title Fix pgsql migration test Ensure db is closed in migration test Sep 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 17, 2020
@lafriks lafriks added this to the 1.13.0 milestone Sep 17, 2020
@lunny lunny merged commit 1fb5bbd into go-gitea:master Sep 18, 2020
@lunny lunny deleted the lunny/fix_migrate_pgsql branch September 18, 2020 01:36
lunny added a commit to lunny/gitea that referenced this pull request Sep 18, 2020
@lunny @lafriks
Fix pgsql migration test (go-gitea#12844)
aedc368 
Co-authored-by: Lauris BH <lauris@nix.lv>
@lunny lunny mentioned this pull request Sep 18, 2020
Merged
@lunny lunny added backport/done All backports for this PR have been created backport/v1.12 labels Sep 18, 2020
lunny added a commit that referenced this pull request Sep 18, 2020
@lunny @lafriks
Fix pgsql migration test (#12844) (#12884)
65ef634 
Co-authored-by: Lauris BH <lauris@nix.lv>

Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lunny @codecov-commenter @lafriks @zeripath @GiteaBot