Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Database preparation: Clarify why database client is installed on Gitea server #12833

Merged
merged 4 commits into from
Dec 27, 2020

Conversation

bagasme
Copy link
Contributor

@bagasme bagasme commented Sep 14, 2020

The database client program (mysql or psql) is used to test database
connection, but Gitea use Go's database driver to do the same.

Also, rename "server part" and "client part" to "server application" and
"client program" to disambiguate.

…ea server

The database client program (`mysql` or `psql`) is used to test database
connection, but Gitea use Go's database driver to do the same.

Also, rename "server part" and "client part" to "server application" and
"client program" to disambiguate.
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020

Codecov Report

Merging #12833 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12833   +/-   ##
=======================================
  Coverage   42.84%   42.84%           
=======================================
  Files         662      662           
  Lines       73002    73002           
=======================================
+ Hits        31279    31280    +1     
+ Misses      36652    36651    -1     
  Partials     5071     5071           
Impacted Files Coverage Δ
modules/indexer/stats/db.go 43.47% <0.00%> (-17.40%) ⬇️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/avatar/avatar.go 50.00% <0.00%> (-4.77%) ⬇️
models/error.go 34.85% <0.00%> (ø)
models/issue_comment.go 53.90% <0.00%> (+0.15%) ⬆️
services/pull/pull.go 41.27% <0.00%> (+0.49%) ⬆️
models/gpg_key.go 53.90% <0.00%> (+0.57%) ⬆️
services/pull/check.go 50.00% <0.00%> (+2.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82179a6...ee87544. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 14, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Dec 25, 2020
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Dec 26, 2020
@stale stale bot removed the issue/stale label Dec 26, 2020
@lunny
Copy link
Member

lunny commented Dec 26, 2020

Please resolve the conflicts.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 27, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2020
@lunny lunny merged commit 25f8970 into go-gitea:master Dec 27, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
@bagasme bagasme deleted the docs/db-prep-client-part-test branch May 5, 2022 04:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants