Fix bug on elastic search #12811
Merged
Fix bug on elastic search #12811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/bug
skip-changelog
zeripath
reviewed
Sep 11, 2020
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #12811 +/- ##
==========================================
+ Coverage 43.12% 43.14% +0.01%
==========================================
Files 654 654
Lines 72194 72205 +11
==========================================
+ Hits 31133 31152 +19
+ Misses 36010 36008 -2
+ Partials 5051 5045 -6
Continue to review full report at Codecov.
|
lunny
force-pushed
the
lunny/fix_es_code
branch
from
8cf40ee
to
c5462d1
Compare
|
@zeripath done. |
lunny
force-pushed
the
lunny/fix_es_code
branch
from
c5462d1
to
32de75f
Compare
lafriks
reviewed
Sep 11, 2020
lafriks
approved these changes
Sep 11, 2020
GiteaBot
added
lgtm/need 1
zeripath
reviewed
Sep 11, 2020
lunny
force-pushed
the
lunny/fix_es_code
branch
from
e9ffc8d
to
a58e9ae
Compare
|
@zeripath done. |
zeripath
approved these changes
Sep 12, 2020
GiteaBot
added
lgtm/done
|
So need to figure out what happens with content |
|
@zeripath Updated on the first comment of mine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When input two words or some Unicode texts on the search box, the default elastic search highlighting plugin will return content with high light html tags. i.e.
<em>word1</em> <em>word2</em>.But the previous codes will try to find
<em>word1 word2</em>and returnstartIndex = endIndex = -1which will resutl in a panic.Should fix #12791
Since the new mapping option
"term_vector": "with_positions_offsets"added, you have to delete your index previously.You can try
And restart gitea, the index will be rebuilt.
The new option will increse the space of the index but get faster on returning words positions.