Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check unhandled errors #128

Merged
merged 1 commit into from
Nov 10, 2016
Merged

Check unhandled errors #128

merged 1 commit into from
Nov 10, 2016

Conversation

metalmatze
Copy link
Contributor

Just a few errors that haven't been handled in the project.
When this is merged errcheck won't complain about anything anymore. 馃帀

@codecov-io
Copy link

codecov-io commented Nov 10, 2016

Current coverage is 3.14% (diff: 100%)

Merging #128 into master will not change coverage

@@            master      #128   diff @@
========================================
  Files           33        33          
  Lines         7823      7823          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7557      7557          
  Partials        20        20          

Powered by Codecov. Last update 475ddd8...1e707ea

@lunny
Copy link
Member

lunny commented Nov 10, 2016

LGTM

@lunny lunny added this to the 1.0.0 milestone Nov 10, 2016
@andreynering
Copy link
Contributor

LGTM

@andreynering andreynering merged commit 31da225 into go-gitea:master Nov 10, 2016
@metalmatze metalmatze deleted the enhancement/errcheck branch November 10, 2016 10:02
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Jan 5, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants