Ensure that the detected charset order is set in chardet test #12574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestToUTF8WithFallback is the cause of recurrent spurious test failures even despite code to set the detected charset order. The reason why this happens is because the preferred detected charset order is not being initialised for these tests. This PR simply ensures that this is set at the start of each test and would allow different tests to be written to allow differing orders. Replaces go-gitea#12571 Close go-gitea#12571 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
topic/build
|
I've made this backport so that we can prevent the bug from occurring during building of 1.12 - we can skip-changelog it. |
GiteaBot
added
the
lgtm/need 2
zeripath
added
the
skip-changelog
|
Now I am sure that #11621 (at least temporarily) fixed this issue - I repeatedly ran CI builds on that and did not get a failure. If I am correct that it did fix this - there was likely a change at some point that caused the unit tests to stop calling modules/setting.newRepository() (which is on the whole a good thing) but would have caused this issue to reappear. |
|
Seems to work. I could not get any more failure in over 100 runs. So the non-determinism was a just a race between test cases after all? |
silverwind
approved these changes
Aug 23, 2020
GiteaBot
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #12574 +/- ##
==========================================
- Coverage 43.43% 43.42% -0.01%
==========================================
Files 643 643
Lines 71165 71165
==========================================
- Hits 30910 30904 -6
- Misses 35246 35252 +6
Partials 5009 5009
Continue to review full report at Codecov.
|
6543
approved these changes
Aug 23, 2020
GiteaBot
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Aug 23, 2020
…ea#12574) Backport go-gitea#12574 TestToUTF8WithFallback is the cause of recurrent spurious test failures even despite code to set the detected charset order. The reason why this happens is because the preferred detected charset order is not being initialised for these tests. This PR simply ensures that this is set at the start of each test and would allow different tests to be written to allow differing orders. Replaces go-gitea#12571 Close go-gitea#12571 Signed-off-by: Andrew Thornton <art27@cantab.net>
Closed
|
Not backportable to 1.12 because #11621 is not in 1.12 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestToUTF8WithFallback is the cause of recurrent spurious test failures
even despite code to set the detected charset order.
The reason why this happens is because the preferred detected charset order
is not being initialised for these tests.
This PR simply ensures that this is set at the start of each test and would
allow different tests to be written to allow differing orders.
Replaces #12571
Close #12571
Fix #12569
Signed-off-by: Andrew Thornton art27@cantab.net