Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in models/ and modules/ #1248

Merged
merged 1 commit into from Mar 15, 2017
Merged

Fix typos in models/ and modules/ #1248

merged 1 commit into from Mar 15, 2017

Conversation

ethantkoenig
Copy link
Member

One I want to double check:

neddedConnectOnMsg() should be neededConnectOnMsg() (i.e. nedded is not an intentional abbrevation of something), correct?

@lunny lunny added this to the 1.2.0 milestone Mar 14, 2017
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Mar 14, 2017
@lunny
Copy link
Member

lunny commented Mar 14, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 14, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2017
@lunny lunny merged commit 021904e into go-gitea:master Mar 15, 2017
@ethantkoenig ethantkoenig deleted the typos branch March 15, 2017 00:53
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ethantkoenig @lunny @appleboy @tboerger