Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to use testfixtures v3 #11904

Merged
merged 9 commits into from Jun 17, 2020
Merged

upgrade to use testfixtures v3 #11904

merged 9 commits into from Jun 17, 2020

Conversation

techknowlogick
Copy link
Member

gomod upgrade testfixtures

This is extracted from another PR I'm working on.

@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jun 16, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Jun 16, 2020
@techknowlogick techknowlogick added dependencies and removed type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Jun 16, 2020
@6543
Copy link
Member

6543 commented Jun 16, 2020

pleace resolve conflicts

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 16, 2020
@techknowlogick
Copy link
Member Author

@6543 resolved

techknowlogick
techknowlogick commented Jun 17, 2020
View reviewed changes
templates/repo/empty.tmpl Outdated Show resolved Hide resolved
templates/repo/empty.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 17, 2020
@6543
Copy link
Member

6543 commented Jun 17, 2020

🚀

@lafriks lafriks merged commit 9e6a79b into go-gitea:master Jun 17, 2020
@techknowlogick techknowlogick deleted the testfixtures3 branch June 17, 2020 20:13
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@techknowlogick @lafriks
upgrade to use testfixtures v3 (go-gitea#11904)
6c84648 
* upgrade to use testfixtures v3

* simplify logic

* make vendor

* update per @lunny

* Update templates/repo/empty.tmpl

* Update templates/repo/empty.tmpl

Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@techknowlogick @6543 @lunny @lafriks @GiteaBot