Ensure search action button is coalesced to adjacent input #11385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fomantic-ui's action button syntax requires that the button is the next sibling of the input it is attached to and that they are both children of a div.action. Fix go-gitea#11375 Signed-off-by: Andrew Thornton <art27@cantab.net>
silverwind
approved these changes
May 12, 2020
GiteaBot
added
the
lgtm/need 1
|
The diff looks good but can't reproduce relevant issue under Chromium or Firefox. |
lafriks
approved these changes
May 12, 2020
GiteaBot
added
lgtm/done
|
ping LG-TM |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Fomantic-ui's action button syntax requires that the button is the next sibling of the input it is attached to and that they are both children of a div.action. Fix go-gitea#11375 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fomantic-ui's action button syntax requires that the button is
the next sibling of the input it is attached to and that they
are both children of a div.action.
Fix #11375
Signed-off-by: Andrew Thornton art27@cantab.net