Consolidate API for getting single commit #11368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
approved these changes
May 11, 2020
GiteaBot
added
the
lgtm/need 1
lafriks
added
issue/regression
zeripath
approved these changes
May 11, 2020
GiteaBot
added
lgtm/done
lafriks
added
the
skip-changelog
3 tasks
|
make lg-tm work |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Allow Git ref for /repos/{owner}/{repo}/git/commits/{sha}
* Consolidate API for getting single commit
* Fix tests and do it differently
Co-authored-by: zeripath <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #11367
As discussed on Discord; this PR removes new API endpoint introduced by #10915 and reverts it's breaking change of disallowing Git ref on already existing ones. It makes drone/go-scm#50 unnecessary.
In addition, this PR updates documentation regarding this API endpoint to make it obvious that it accepts valid git ref.
Functionally, #10915 made no changes except introducing redundant API endpoint.
Closes #11367