Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding advanced label set. #11298

Merged
merged 10 commits into from May 7, 2020
Merged

Adding advanced label set. #11298

merged 10 commits into from May 7, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 5, 2020 •
edited by ghost

This pull request should add an advanced set of labels to contrib/ as discussed with @6543.

guillep2k
guillep2k reviewed May 5, 2020
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some English improvements. Those could probably be improved still more. 😝

contrib/options/label/Advanced Outdated Show resolved Hide resolved
contrib/options/label/Advanced Outdated Show resolved Hide resolved
contrib/options/label/Advanced Outdated Show resolved Hide resolved
contrib/options/label/Advanced Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 5, 2020
@ghost ghost requested a review from guillep2k May 5, 2020 04:55
@6543
Copy link
Member

6543 commented May 5, 2020

GH default label: https://github.com/6543/tttesr/labels

A repo with topic default labels: https://github.com/yoshuawuyts/github-standard-labels

6543
6543 approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok - this is good to go for me ;)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 5, 2020
6543
6543 requested changes May 5, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot a thing,

Can you add "Kind: Documentation"?

6543
6543 reviewed May 5, 2020
View reviewed changes
contrib/options/label/Advanced Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented May 5, 2020

I forgot a thing,

Can you add "Kind: Documentation"?

Done.

6543
6543 approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok finaly - I'm ok with this

for remove Iprovement vs dont - I have no real opinion on it

@zeripath
Copy link
Contributor

zeripath commented May 6, 2020

I think we could just distribute this as an alternative label set. However, LGTM as it stands.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 6, 2020
@zeripath zeripath merged commit b16534b into go-gitea:master May 7, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
Adding advanced label set. (go-gitea#11298)
9840863 
Add an advanced label set to contrib
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k Awaiting requested review from guillep2k

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/miscellaneous
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@6543 @zeripath @lafriks @guillep2k @GiteaBot