Automatically remove Watches, Assignments, etc if user loses access due to being removed as collaborator or from a team #10997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as a collaborator
…member of a team that can access the repo
Co-Authored-By: 6543 <6543@obermui.de>
Co-Authored-By: 6543 <6543@obermui.de>
6543
changed the title
6543
changed the title
|
THIS is ready for review |
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #10997 +/- ##
==========================================
- Coverage 43.60% 43.39% -0.21%
==========================================
Files 597 597
Lines 83923 84547 +624
==========================================
+ Hits 36594 36691 +97
- Misses 42817 43330 +513
- Partials 4512 4526 +14
Continue to review full report at Codecov.
|
zeripath
reviewed
Apr 7, 2020
There was a problem hiding this comment.
I think this is right but I have two questions:
- The deletecollaboration call just removes watchers etc without checking if the user would still have access, should we check if the user would still have access before doing those?
- Do we need to do a similar change for removal from team
|
|
It might be better to just move them all in to this. They're all related. |
6543
changed the title
|
@zeripath done |
zeripath
approved these changes
Apr 7, 2020
GiteaBot
added
lgtm/need 1
zeripath
changed the title
lafriks
approved these changes
Apr 7, 2020
GiteaBot
added
lgtm/done
|
ping |
|
Thanks a lot mate. Really appreciate you completing this. |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
…ue to being removed as collaborator or from a team (go-gitea#10997) * remove a user from being assigned to any issue/PR if (s)he is removed as a collaborator * fix gender specific comment * do not remove users that still have access to the repo if they are a member of a team that can access the repo * add context to errors * updates * incorporate review fixes * Update models/repo_collaboration.go Co-Authored-By: 6543 <6543@obermui.de> * Update models/repo_collaboration.go Co-Authored-By: 6543 <6543@obermui.de> * Fix Rebase Relict * Fix & Impruve * use xorm builder * all in one session * generalize reconsiderIssueAssignees * Only Unwatch if have no access anymore * prepare for reuse * Same things if remove User from Team * fix lint * let mysql take time to react * add description * CI.restart() * CI.restart() Co-authored-by: Lanre Adelowo <yo@lanre.wtf> Co-authored-by: techknowlogick <matti@mdranta.net> Co-authored-by: Lauris BH <lauris@nix.lv>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continue #5676
fix #5673
Include #11003