Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] provide OwnerName field for README template #10981

Merged
merged 5 commits into from Apr 7, 2020
Merged

[feature] provide OwnerName field for README template #10981

merged 5 commits into from Apr 7, 2020

Conversation

everhopingandwaiting
Copy link
Contributor

reopen: pr #10356

everhopingandwaiting and others added 2 commits April 6, 2020 08:33
@everhopingandwaiting
provide OwnerName field for reame template
8375215 
Provide more information to readme template
@everhopingandwaiting
go fmt
f7ee8fd
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 6, 2020
@6543
Copy link
Member

6543 commented Apr 6, 2020 •
edited

I think we need docs for this ... I'll send a pull for this (#10983)

-> based on the merge order either this or the other pr has to add OwnerName to the docs

@codecov-io
Copy link

Codecov Report

Merging #10981 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10981      +/-   ##
==========================================
- Coverage   43.63%   43.60%   -0.04%     
==========================================
  Files         597      597              
  Lines       83923    83924       +1     
==========================================
- Hits        36623    36596      -27     
- Misses      42787    42811      +24     
- Partials     4513     4517       +4
Impacted Files Coverage Δ
modules/repository/init.go 57.41% <100.00%> (+0.27%) ⬆️
services/pull/check.go 47.56% <0.00%> (-6.10%) ⬇️
services/pull/temp_repo.go 29.05% <0.00%> (-5.13%) ⬇️
services/pull/patch.go 62.93% <0.00%> (-4.90%) ⬇️
modules/indexer/issues/indexer.go 56.19% <0.00%> (-1.33%) ⬇️
services/pull/pull.go 35.00% <0.00%> (-0.89%) ⬇️
models/repo.go 51.42% <0.00%> (-0.14%) ⬇️
modules/process/manager.go 78.31% <0.00%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca33a95...f7ee8fd. Read the comment docs.

@6543
Copy link
Member

6543 commented Apr 7, 2020 •
edited

@everhopingandwaiting since #10983 got merged:
can you "update" your featurebranch and extend docs/content/doc/advanced/customizing-gitea.en-us.md by adding your new variable to the note?

@6543
Copy link
Member

6543 commented Apr 7, 2020

@everhopingandwaiting a hint: you should make git pull -r before git push

@everhopingandwaiting
Copy link
Contributor Author

@everhopingandwaiting a hint: you should make git pull -r before git push

should I choose rebase or merge to select upstream changes in my origin branch?
image

@6543
Copy link
Member

6543 commented Apr 7, 2020

@everhopingandwaiting If you like to chat with me -> https://discord.gg/Gitea

@everhopingandwaiting
Copy link
Contributor Author

@everhopingandwaiting since #10983 got merged:
can you "update" your featurebranch and extend docs/content/doc/advanced/customizing-gitea.en-us.md by adding your new variable to the note?

**NOTE:** readme templates support **variable expansion**.  
currently there are `{Name}` (name of repository), `{Description}`, `{CloneURL.SSH}` and `{CloneURL.HTTPS}`

seems I should change OwnerName to Name 😉

"Description":    repo.Description,
		"CloneURL.SSH":   cloneLink.SSH,			"CloneURL.SSH":   cloneLink.SSH,
		"CloneURL.HTTPS": cloneLink.HTTPS,			"CloneURL.HTTPS": cloneLink.HTTPS,
		"OwnerName":      repo.OwnerName,

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 7, 2020
6543
6543 requested changes Apr 7, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking since need addition to docs

@6543
Copy link
Member

6543 commented Apr 7, 2020

just add your OwnerName to the list in docs/content/doc/advanced/customizing-gitea.en-us.md

@everhopingandwaiting
Copy link
Contributor Author

@everhopingandwaiting If you like to chat with me -> https://discord.gg/Gitea

Unknown cause ， the site is blocked 😜
image

6543
6543 requested changes Apr 7, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just "apply"

6543
6543 approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@techknowlogick techknowlogick merged commit b252b23 into go-gitea:master Apr 7, 2020
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Apr 7, 2020
@a1012112796
Copy link
Member

I wander why this PR is not on any Milestone ?

@everhopingandwaiting
Copy link
Contributor Author

on 1.12, but reopen

@lunny
Copy link
Member

lunny commented Apr 14, 2020

@a1012112796 most docs PRs we haven't added milestone because most of them are outdate documents so that we should not mark them on the milestone.

@guillep2k guillep2k added this to the 1.12.0 milestone Apr 15, 2020
@guillep2k guillep2k removed the type/docs This PR mainly updates/creates documentation label Apr 15, 2020
@guillep2k guillep2k added the type/enhancement An improvement of existing functionality label Apr 15, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@everhopingandwaiting @6543 @techknowlogick
[feature] provide OwnerName field for README template (go-gitea#10981)
e0960cd 
Co-Authored-By: 6543 <6543@obermui.de>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@everhopingandwaiting @6543 @codecov-io @a1012112796 @lunny @guillep2k @techknowlogick @lafriks @GiteaBot