Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to go-enry new version #10906

Merged
merged 6 commits into from Apr 15, 2020
Merged

Migrate to go-enry new version #10906

merged 6 commits into from Apr 15, 2020

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Mar 31, 2020 •
edited

Migrate to https://github.com/go-enry/go-enry as projects under https://github.com/src-d are no longer supported.

  • Supports more languages by sync with Linguist v7.9.0

Fixes #10476

@lafriks lafriks added type/enhancement An improvement of existing functionality type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 31, 2020
@lafriks lafriks added this to the 1.12.0 milestone Mar 31, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 31, 2020
@techknowlogick
Copy link
Member

please run make vendor using go1.14.1

@lafriks
Copy link
Member Author

lafriks commented Mar 31, 2020

@techknowlogick done ;)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 31, 2020
@techknowlogick
Copy link
Member

ARM runners fail, I've tried restarting a few times, and it still fails, so something related to this PR is affecting it.

@techknowlogick
Copy link
Member

This PR adds 9mins to the average CI build :(

@lunny
Copy link
Member

lunny commented Apr 12, 2020

This PR adds 9mins to the average CI build :(

But why?

@lafriks
Copy link
Member Author

lafriks commented Apr 12, 2020

Seems to be that only arm tests are affected... But I can not seem to see reason for this

@sapk
Copy link
Member

sapk commented Apr 15, 2020

CI seems fine now (without too much extra time). Can you update the PR ?

@lafriks
Copy link
Member Author

lafriks commented Apr 15, 2020

Make lgtm work

@lafriks
Copy link
Member Author

lafriks commented Apr 15, 2020

Again :)

@lafriks lafriks merged commit 4dc62da into go-gitea:master Apr 15, 2020
@lafriks lafriks deleted the feat/go_enry branch April 15, 2020 17:40
@mrsdizzie mrsdizzie mentioned this pull request Apr 18, 2020
Merged
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@lafriks
Migrate to go-enry new version (go-gitea#10906)
53590f5
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

More colors for language bar / language mapping like linguist
7 participants
@lafriks @techknowlogick @lunny @sapk @mrsdizzie @6543 @GiteaBot