Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize and unit test Issue_ReplaceLabels #1080

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Optimize and unit test Issue_ReplaceLabels #1080

merged 1 commit into from
Feb 28, 2017

Conversation

ethantkoenig
Copy link
Member

Refactor out 2 "quadratic" loops in favor of 1 "linear" loop. Also add unit tests to make sure I didn't break anything 馃槃

@andreynering
Copy link
Contributor

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 27, 2017
@strk
Copy link
Member

strk commented Feb 27, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 27, 2017
@lunny lunny added this to the 1.1.0 milestone Feb 28, 2017
@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing labels Feb 28, 2017
@lunny lunny merged commit cf80e19 into go-gitea:master Feb 28, 2017
@ethantkoenig ethantkoenig deleted the refactor/issue branch February 28, 2017 13:38
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ethantkoenig @andreynering @strk @lunny @tboerger