Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: change the "taskName" to "label" in vscode tasks.json #10739

Merged
merged 1 commit into from
Mar 16, 2020
Merged

misc: change the "taskName" to "label" in vscode tasks.json #10739

merged 1 commit into from
Mar 16, 2020

Conversation

a1012112796
Copy link
Member

@a1012112796 a1012112796 commented Mar 16, 2020 •
edited

because of vscode suggest

ref ISSUE: microsoft/vscode-docs#1181

@a1012112796
misc: change the "taskName" to "label" in vscode tasks.json
2bbee83 
because of vscode suggest
ref ISSUE: microsoft/vscode-docs#1181

Signed-off-by: a1012112796 <1012112796@qq.com>
@codecov-io
Copy link

Codecov Report

Merging #10739 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10739      +/-   ##
==========================================
- Coverage   43.55%   43.50%   -0.05%     
==========================================
  Files         589      589              
  Lines       82662    82662              
==========================================
- Hits        36006    35966      -40     
- Misses      42185    42229      +44     
+ Partials     4471     4467       -4
Impacted Files Coverage Δ
modules/indexer/stats/db.go 40.62% <0.00%> (-18.75%) ⬇️
modules/indexer/stats/queue.go 62.50% <0.00%> (-18.75%) ⬇️
services/pull/check.go 35.97% <0.00%> (-14.03%) ⬇️
modules/git/utils.go 65.67% <0.00%> (-4.48%) ⬇️
modules/git/repo.go 46.78% <0.00%> (-0.92%) ⬇️
services/pull/pull.go 35.00% <0.00%> (-0.89%) ⬇️
models/pull.go 42.30% <0.00%> (-0.56%) ⬇️
modules/git/command.go 89.56% <0.00%> (+2.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7ece6...2bbee83. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 16, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 16, 2020
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 16, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Mar 16, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 16, 2020
@lafriks lafriks merged commit 19ebe2b into go-gitea:master Mar 16, 2020
@a1012112796 a1012112796 deleted the vscode branch March 17, 2020 12:44
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@a1012112796 @codecov-io @techknowlogick @lafriks @GiteaBot