Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move jquery-datetimepicker to npm/webpack #10713

Merged
merged 2 commits into from
Mar 17, 2020
Merged

move jquery-datetimepicker to npm/webpack #10713

merged 2 commits into from
Mar 17, 2020

Conversation

silverwind
Copy link
Member

  • update to latest version and move to npm
  • adapt for api changes and css class rename
  • add specificity to arc-green rules as dependency css now loads later
  • use imports-loader to make it load correctly
  • fix some wrong paths in librejs

@silverwind
Copy link
Member Author

silverwind commented Mar 11, 2020 •
edited

Resulting bundle is 335kB because of the dependencies this plugin has. Not sure if/how it's possible to prevent that second jQuery from loading.

It's only used on a single page (create milestone) and I think we should just use Fomantic's Calendar to replace it entirely later.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 11, 2020
@lafriks lafriks added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 11, 2020
@lafriks lafriks added this to the 1.12.0 milestone Mar 11, 2020
@6543
Copy link
Member

6543 commented Mar 11, 2020

@silverwind how hard is it to switch to "Fomantic's Calendar" directly instead?

@silverwind
Copy link
Member Author

Probably not too hard but I've never worked with Fomantic stuff yet.

@silverwind
Copy link
Member Author

silverwind commented Mar 12, 2020 •
edited

Another issue with using Calendar is that we can not lazy-load Fomantic components (yet), so it would increase the size of the already big Fomantic bundle as we're not using that component anywhere yet. Maybe I'll try it later, but I'd land this anyways.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 12, 2020
gary-kim
gary-kim approved these changes Mar 15, 2020
View reviewed changes
Copy link
Member

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 15, 2020
@silverwind
move jquery-datetimepicker to npm/webpack
263d122 
- update to latest version and move to npm
- adapt for api changes and css class rename
- add specificity to arc-green rules as dependency css now loads later
- use imports-loader to make it load correctly
- fix some wrong paths in librejs
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit 85fb33a into go-gitea:master Mar 17, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@gary-kim gary-kim gary-kim approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@silverwind @6543 @techknowlogick @gary-kim @lafriks @GiteaBot