Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog for v1.10.6 (#10699) #10710

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Changelog for v1.10.6 (#10699) #10710

merged 2 commits into from
Mar 11, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 11, 2020

  • Changelog for v1.10.6
  • Add warnning
  • Apply suggestions from code review

Co-Authored-By: John Olheiser john.olheiser@gmail.com

@lunny @jolheiser
Changelog for v1.10.6 (go-gitea#10699)
ba6665e 
* Changelog for v1.10.6

* Add warnning

* Apply suggestions from code review

Co-Authored-By: John Olheiser <john.olheiser@gmail.com>

Co-authored-by: John Olheiser <john.olheiser@gmail.com>
@lunny lunny added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 11, 2020
@lunny lunny added this to the 1.12.0 milestone Mar 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #10710 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10710      +/-   ##
==========================================
+ Coverage   43.53%   43.56%   +0.03%     
==========================================
  Files         589      589              
  Lines       82662    82662              
==========================================
+ Hits        35989    36014      +25     
+ Misses      42209    42177      -32     
- Partials     4464     4471       +7
Impacted Files Coverage Δ
models/unit.go 37.03% <0.00%> (-2.47%) ⬇️
modules/log/event.go 64.61% <0.00%> (-1.03%) ⬇️
routers/repo/view.go 36.14% <0.00%> (-0.68%) ⬇️
models/gpg_key.go 53.42% <0.00%> (-0.53%) ⬇️
models/pull.go 42.85% <0.00%> (+0.55%) ⬆️
modules/queue/workerpool.go 58.00% <0.00%> (+1.06%) ⬆️
services/pull/check.go 56.70% <0.00%> (+18.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6618348...ba6665e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 11, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 11, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 11, 2020
@lafriks lafriks merged commit ac1e411 into go-gitea:master Mar 11, 2020
@lunny lunny deleted the lunny/changelog_1.10.6-3 branch March 11, 2020 05:48
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lunny @codecov-io @techknowlogick @lafriks @GiteaBot