Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2 linking to existing 2FA enabled account fails #1050

Closed
1 of 3 tasks
willemvd opened this issue Feb 25, 2017 · 0 comments · Fixed by #1052
Closed
1 of 3 tasks

OAuth2 linking to existing 2FA enabled account fails #1050

willemvd opened this issue Feb 25, 2017 · 0 comments · Fixed by #1052
Labels
type/bug
Milestone
1.1.0

Comments

@willemvd
Copy link
Contributor

  • Gitea version (or commit ref): master
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Mentioned by @geek1011 at the gitter channel and confirmed by myself on try.gitea.io

If you have setup an existing account with 2FA enabled and want to sign in with Github it fails to link the Github account to the existing account.

Steps to reproduce:

  • Setup an local account and enable 2FA
  • Logout the account and sign in with Github
  • On the sign-in-or-create-account page login with the existing local account with 2FA
  • Login with the 2FA code
  • Your Settings - External Accounts -> here should a Github entry be mentioned but isn't
  • Logout and try to login with Github again
  • The sign-in-or-create-account page is shown again instead of the user being logged in
@willemvd willemvd changed the title OAuth2 linking to existing 2FA fails OAuth2 linking to existing 2FA enabled account fails Feb 25, 2017
@lunny lunny added the type/bug label Feb 25, 2017
@lunny lunny added this to the 1.x.x milestone Feb 25, 2017
willemvd added a commit to willemvd/gitea that referenced this issue Feb 25, 2017
@willemvd
fixes go-gitea#1050 where linking an account to a 2fa enabled account…
b757c44 
… failed because we forgot to really link the account when 2fa is completed
@willemvd willemvd mentioned this issue Feb 25, 2017
Merged
@lunny lunny modified the milestones: 1.1.0, 1.x.x Feb 25, 2017
lunny pushed a commit that referenced this issue Feb 27, 2017
@willemvd @lunny
Link OAuth2 account to 2FA enabled account (fix #1050) (#1052)
8947b71 
* fixes #1050 where linking an account to a 2fa enabled account failed because we forgot to really link the account when 2fa is completed

* handle errors
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Link OAuth2 account to 2FA enabled account (fix #1050) willemvd/gitea
2 participants
@lunny @willemvd