Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inform participants on UI too #10473

Merged
merged 8 commits into from
Feb 28, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 26, 2020

fix #8243

@6543
Copy link
Member Author

6543 commented Feb 26, 2020

it would partialy close #9535 too

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 26, 2020
@6543
Copy link
Member Author

6543 commented Feb 26, 2020

@guillep2k this is the other way around ... instead of autosubscribe inform participants on UI too ..

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Feb 26, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 26, 2020
@guillep2k
Copy link
Member

Check CI 😉

models/issue.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Feb 27, 2020

@guillep2k for your comment (https://github.com/go-gitea/gitea/pull/10473/files#r384946335) I did a refactor f95baa0

@codecov-io
Copy link

codecov-io commented Feb 27, 2020

Codecov Report

Merging #10473 into master will decrease coverage by <.01%.
The diff coverage is 51.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10473      +/-   ##
==========================================
- Coverage   43.68%   43.67%   -0.01%     
==========================================
  Files         586      586              
  Lines       81495    81521      +26     
==========================================
+ Hits        35599    35605       +6     
- Misses      41484    41500      +16     
- Partials     4412     4416       +4
Impacted Files Coverage Δ
modules/setting/setting.go 44.07% <ø> (ø) ⬆️
modules/lfs/server.go 45.14% <0%> (-0.56%) ⬇️
modules/markup/html.go 79.6% <61.53%> (-0.3%) ⬇️
modules/indexer/stats/queue.go 62.5% <0%> (-18.75%) ⬇️
modules/indexer/stats/db.go 40.62% <0%> (-9.38%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0%> (-1.93%) ⬇️
modules/indexer/issues/indexer.go 57.53% <0%> (-1.37%) ⬇️
modules/process/manager.go 78.31% <0%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d082c9f...12c4656. Read the comment docs.

Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can live with the similarly-named functions until we can refactor the whole thing. Soon, my friend. Soon... 😄

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 27, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2020
@guillep2k guillep2k merged commit 694f446 into go-gitea:master Feb 28, 2020
@6543 6543 deleted the notify-participants-on-ui branch February 28, 2020 11:30
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inform participants on UI too / autosubscribe to issue
5 participants