Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reply on code review #10261

Merged
merged 6 commits into from
Feb 14, 2020
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 13, 2020

backport from #10227

lunny and others added 3 commits February 1, 2020 22:22
* Fix branch page pull request title and link error

* Fix ui
Co-authored-by: zeripath <art27@cantab.net>
@lunny lunny added the type/bug label Feb 13, 2020
@lunny lunny added this to the 1.10.4 milestone Feb 13, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 13, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 13, 2020
@6543
Copy link
Member

6543 commented Feb 13, 2020

3175:10 error 'submitReply' is defined but never used.

@lafriks lafriks merged commit e786f09 into go-gitea:release/v1.10 Feb 14, 2020
@lunny lunny deleted the lunny/fix_reply3 branch February 14, 2020 12:35
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 16, 2020
lafriks pushed a commit that referenced this pull request Feb 16, 2020
* v1.10.4 Changelog

* Add backport identifier for #10261

* Update CHANGELOG.md entry for #9884

* Workaround docker-library/postgres#658

* Update .drone.yml
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 16, 2020
* v1.10.4 Changelog

* Add backport identifier for go-gitea#10261

* Update CHANGELOG.md entry for go-gitea#9884
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 16, 2020
* v1.10.4 Changelog

* Add backport identifier for go-gitea#10261

* Update CHANGELOG.md entry for go-gitea#9884
techknowlogick pushed a commit that referenced this pull request Feb 16, 2020
* v1.10.4 Changelog

* Add backport identifier for #10261

* Update CHANGELOG.md entry for #9884
techknowlogick pushed a commit that referenced this pull request Feb 16, 2020
* v1.10.4 Changelog

* Add backport identifier for #10261

* Update CHANGELOG.md entry for #9884

Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants