Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Fix inconsistent label color format #10129

Merged
merged 7 commits into from Feb 9, 2020
Merged

[API] Fix inconsistent label color format #10129

merged 7 commits into from Feb 9, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 3, 2020 •
edited

fix #10127
and format code
and fix typo

@6543 6543 mentioned this pull request Feb 3, 2020
Closed
@6543 6543 changed the title [API] Inconsequent Lable Format [WIP] [API] Inconsequent Lable Format Feb 3, 2020
@6543
Copy link
Member Author

6543 commented Feb 3, 2020

models.NewLabel() has not a single check if input match!!! we need checks before incerting to DB anyway !!!

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 3, 2020
@codecov-io
Copy link

codecov-io commented Feb 3, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@a1d9b1e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10129   +/-   ##
=========================================
  Coverage          ?   43.64%           
=========================================
  Files             ?      576           
  Lines             ?    79673           
  Branches          ?        0           
=========================================
  Hits              ?    34777           
  Misses            ?    40606           
  Partials          ?     4290

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1d9b1e...3a918d2. Read the comment docs.

@guillep2k
Copy link
Member

Title suggestion:

[WIP] [API] Fix inconsistent label format

@6543 6543 changed the title [WIP] [API] Inconsequent Lable Format [WIP] [API] Fix inconsistent label format Feb 3, 2020
@6543 6543 changed the title [WIP] [API] Fix inconsistent label format [API] Fix inconsistent label format Feb 4, 2020
@6543
Copy link
Member Author

6543 commented Feb 4, 2020

OK this Fix and smal code reformat is now ready :)
not it Isn't a "simple solution" but all functions now validate Collor before changes go to DB :) usw ...

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Feb 4, 2020
@6543
Copy link
Member Author

6543 commented Feb 5, 2020

@guillep2k this is ready to revview :)

guillep2k
guillep2k reviewed Feb 5, 2020
View reviewed changes
models/issue_label.go Show resolved Hide resolved
routers/api/v1/repo/label.go Outdated Show resolved Hide resolved
models/issue_label.go Outdated Show resolved Hide resolved
@6543 6543 force-pushed the api-label-thing branch 2 times, most recently from 865a24a to 1dab172 Compare February 6, 2020 09:14
@6543
Copy link
Member Author

6543 commented Feb 6, 2020

@guillep2k done

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 7, 2020
@6543
Copy link
Member Author

6543 commented Feb 8, 2020

@lafriks can you look at this?

@6543 6543 changed the title [API] Fix inconsistent label format [API] Fix inconsistent label color format Feb 8, 2020
@lafriks
Copy link
Member

lafriks commented Feb 8, 2020

Drone fails

@6543
Copy link
Member Author

6543 commented Feb 8, 2020 •
edited

@lafriks unrelated (I didn't touched models/user.go!)

@6543
Copy link
Member Author

6543 commented Feb 8, 2020

@lafriks CI passed

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 9, 2020
@zeripath zeripath added this to the 1.12.0 milestone Feb 9, 2020
@zeripath zeripath merged commit e273817 into go-gitea:master Feb 9, 2020
@6543 6543 deleted the api-label-thing branch February 9, 2020 14:38
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks left review comments

@zeripath zeripath zeripath approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

[API] Inconsistent Label Format
6 participants
@6543 @codecov-io @guillep2k @lafriks @zeripath @GiteaBot