fix apple-touch-icon, regenerate images #10065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
approved these changes
Jan 29, 2020
GiteaBot
added
the
lgtm/need 1
Fixed semi-transparent pixels of apple-touch-icon.png. I had to manually exclude public/img/loading.png from the commit because it's an APNG and one of the tools destroys the animation.
This was referenced Jan 29, 2020
|
Why delete public/img/telegram.png ...? |
It wasn't deleted, just got smaller. |
|
Nothing is deleted here, just size-optimized. APNG issue is google/zopfli#118, by the way. |
|
Ok, github bin diff view is missleading |
6543
approved these changes
Jan 29, 2020
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #10065 +/- ##
==========================================
- Coverage 42.35% 42.31% -0.05%
==========================================
Files 618 618
Lines 80774 80850 +76
==========================================
- Hits 34213 34208 -5
- Misses 42352 42433 +81
Partials 4209 4209
Continue to review full report at Codecov.
|
|
@NiTRoeSE can you confirm it is working now? |
Yes i can confirm, looks good now. Thanks for your work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed semi-transparent pixels of apple-touch-icon.png.
I had to manually exclude public/img/loading.png from the commit because it's an APNG and one of the tools destroys the animation.