Skip to content

[Contrib] Change License Link to Full CC0 Legalcode (PP and TOS) #10057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bagasme
Copy link
Contributor

@bagasme bagasme commented Jan 29, 2020

As per title.

Edit: Apply requested changes from @techknowlogick. Still hotlink to CC site, but use /legalcode suffix instead.

Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 29, 2020
@codecov-io
Copy link

Codecov Report

Merging #10057 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10057      +/-   ##
==========================================
- Coverage   42.35%   42.34%   -0.01%     
==========================================
  Files         618      618              
  Lines       80774    80774              
==========================================
- Hits        34208    34203       -5     
- Misses      42358    42361       +3     
- Partials     4208     4210       +2
Impacted Files Coverage Δ
services/pull/patch.go 66.03% <0%> (-3.78%) ⬇️
modules/queue/workerpool.go 44.48% <0%> (-2.14%) ⬇️
modules/log/file.go 75.52% <0%> (-2.1%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/repo.go 49.66% <0%> (-0.14%) ⬇️
models/gpg_key.go 55.37% <0%> (+0.55%) ⬆️
routers/repo/view.go 39.47% <0%> (+0.87%) ⬆️
services/pull/check.go 56.64% <0%> (+1.39%) ⬆️
modules/queue/manager.go 62.05% <0%> (+1.53%) ⬆️
models/unit.go 39.5% <0%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ce91f...e5f6fc2. Read the comment docs.

Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m unsure about this change. I think it should remain the same and continue to link to CC official site, especially as we plan on moving away from GitHub.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 29, 2020
@bagasme
Copy link
Contributor Author

bagasme commented Jan 30, 2020

@techknowlogick So can the full legal code be shipped together?

@6543
Copy link
Member

6543 commented Jan 30, 2020

@bagasme bagasme changed the title [Contrib] Change License Link to options/license Raw Link [Contrib] Change License Link to Full CC0 Legalcode (PP and TOS) Jan 30, 2020
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Jan 30, 2020
@6543
Copy link
Member

6543 commented Apr 20, 2020

@bagasme ping

@bagasme
Copy link
Contributor Author

bagasme commented Apr 21, 2020

@6543 ok

@techknowlogick techknowlogick merged commit d9b5c21 into go-gitea:master Jun 3, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
…gitea#10057)

* Change license link to full (raw link) legal code on options/license

* Replace link to full legal code at CC site

* Update contrib/legal/tos.html.sample

Co-authored-by: techknowlogick <matti@mdranta.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants