10 Commits

Author	SHA1	Message	Date
zeripath	716fcfcf72	Make every not exist error unwrappable to a fs.ErrNotExist (#20891) ... A lot of our code is repeatedly testing if individual errors are specific types of Not Exist errors. This is repetitative and unnecesary. `Unwrap() error` provides a common way of labelling an error as a NotExist error and we can/should use this. This PR has chosen to use the common `io/fs` errors e.g. `fs.ErrNotExist` for our errors. This is in some ways not completely correct as these are not filesystem errors but it seems like a reasonable thing to do and would allow us to simplify a lot of our code to `errors.Is(err, fs.ErrNotExist)` instead of `package.IsErr...NotExist(err)` I am open to suggestions to use a different base error - perhaps `models/db.ErrNotExist` if that would be felt to be better. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: delvh <dev.lh@web.de>	2022-10-18 07:50:37 +02:00
qwerty287	a813c9d8f3	Allow creation of OAuth2 applications for orgs (#18084) ... Adds the settings pages to create OAuth2 apps also to the org settings and allows to create apps for orgs. Refactoring: the oauth2 related templates are shared for instance-wide/org/user, and the backend code uses `OAuth2CommonHandlers` to share code for instance-wide/org/user. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2022-10-09 20:07:41 +08:00
M Hickford	6a45a691c1	Ignore port for loopback redirect URIs (#21293) ... Following https://datatracker.ietf.org/doc/html/rfc8252#section-7.3 Fixes #21285	2022-09-29 00:19:55 +02:00
Balki	c138e76c1c	Fix panic when an invalid oauth2 name is passed (#20820)	2022-08-17 14:25:28 -04:00
Wim	cb50375e2b	Add more linters to improve code readability (#19989) ... Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability - nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length. - unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions - wastedassign - https://github.com/sanposhiho/wastedassign - wastedassign finds wasted assignment statements. - notlintlint - Reports ill-formed or insufficient nolint directives - stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent - excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005)	2022-06-20 12:02:49 +02:00
Lunny Xiao	fd7d83ace6	Move almost all functions' parameter db.Engine to context.Context (#19748) ... * Move almost all functions' parameter db.Engine to context.Context * remove some unnecessary wrap functions	2022-05-20 22:08:52 +08:00
6543	f41c2bec4c	Delete user related oauth stuff on user deletion too (#19677) ... * delete user related oauth stuff on user deletion too * extend doctor check-db-consistency	2022-05-11 13:16:35 +02:00
Lunny Xiao	772ad761eb	Fix some slice problems (incorrect slice length) (#19592)	2022-05-03 17:04:23 +08:00
Gusted	aa23f477b7	Use CryptoRandomBytes instead of CryptoRandomString (#18439) ... - Switch to use `CryptoRandomBytes` instead of `CryptoRandomString`, OAuth's secrets are copied pasted and don't need to avoid dubious characters etc. - `CryptoRandomBytes` gives  `CryptoRandomString` gives  possible states. - Add a prefix, such that code scanners can easily grep these in source code. - 32 Bytes + prefix	2022-02-04 18:03:15 +01:00
Lunny Xiao	de8e3948a5	Refactor auth package (#17962)	2022-01-02 21:12:35 +08:00