mirror/gitea
1
1
Fork 1
mirror of https://github.com/go-gitea/gitea.git synced 2024-11-19 01:14:05 +01:00
Code Issues
12,067 Commits 17 Branches 213 Tags 610 MiB
6fb7fb6cfc
Commit Graph

12067 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
6543
d21702475b
Fix git.Blob.DataAsync(): close pipe since we return a NopCloser (#16899) 
* make sure headGitRepo is closed on err too

* refactor

* Fix git.Blob.DataAsync(): exec cancel since we already read all bytes (close pipe since we return a NopCloser)
 2021-08-31 08:43:31 +01:00
6543
bb4cc876b1
Repare and Improve GetDiffRangeWithWhitespaceBehavior (#16894) 
* repare and improve GetDiffRangeWithWhitespaceBehavior

* Context with Timeout
 2021-08-31 06:16:23 +02:00
zeripath
f2b4b0f491
Remove ParseQueueConnStr as it is unused (#16878) 
Remove ParseQueueConnStr as `modules/nosql` has taken over all of its functions.

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-08-31 05:33:16 +02:00
6543
6d97befddf
Fix wiki raw commit diff/patch view (#16891) 2021-08-31 04:22:54 +02:00
Lunny Xiao
8d7704b5a2
Fix dump and restore respository (#16698) 
* Fix dump and restore

* return different error message for get commit

* Fix missing delete release attachment when deleting repository

* Fix ci and add some comments

Co-authored-by: zeripath <art27@cantab.net>
 2021-08-30 21:18:15 -04:00
zeripath
c0f5da3e1a
Prevent coverage break (#16887) 
* Prevent coverage break

There are repeated failures of our CI due to an intermittent issue with coverage.out
finishing with a spurious `0` on a single line.

This problem is very annoying and very hard to understand where it is coming from,
therefore as the problem appears random and without clear cause we should just strip
this line from our coverage.

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
 2021-08-31 01:41:08 +02:00
Richard Ulmer
87eb82cf52
Fix report card link (#16885) 2021-08-31 01:06:30 +02:00
zeripath
9119d24573
Ensure wiki repos are all closed (#16886) 
There are multiple places where wiki git repositories are not properly closed.

This PR ensures they are closed.

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-08-30 22:50:35 +02:00
6543
73394f435c
[API] List limited and private orgs if authentificated (#16866) 
* fix bug #16785 and similar

* code format

* CI.restart()
 2021-08-30 14:00:59 -04:00
zeripath
06b9d553bc
Timeout on flush in testing (#16864) 
* Timeout on flush in testing

At the end of each test the queues are flushed. At present there is no limit on the
length of time a flush can take which can lead to long flushes.

However, if the CI task is cancelled we lose the log information as to where the long
flush was taking place.

This PR simply adds a default time limit of 2 minutes - at which point an error will
be produced. This should allow us to more easily find the culprit.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* return better error

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: 6543 <6543@obermui.de>
 2021-08-30 00:27:51 -04:00
GiteaBot
b0ff429882 [skip ci] Updated translations via Crowdin 2021-08-30 00:04:50 +00:00
silverwind
360d8e7c23
Remove unused Fomantic sidebar module (#16853) 
* Remove unused Fomantic sidebar module

The [Sidebar](https://fomantic-ui.com/modules/sidebar.html) module seems
currently unused (at least I can't find any reference to it in templates
or js), so remove it from the Fomantic build.

* remove useless minified fomantic build files

* mark fomantic build files as being generated
 2021-08-29 21:57:07 +02:00
Patrick Schratz
968225e59c
update theme doc (#16860) 2021-08-29 14:26:43 -04:00
Lunny Xiao
d985d4bc2f
Paginate releases page & set default page size to 10 (#16857) 
* Add release default page and set it to 10

* use limit

Co-authored-by: 6543 <6543@obermui.de>
 2021-08-29 18:25:16 +02:00
zeripath
f5b0e2c9d2
Simplify split diff view generation and remove JS dependency (#16775) 
Gitea has relied on some slow JS code to match up added and deleted lines on the
diff pages. This can cause a considerable slow down on large diff pages.

This PR makes a small change meaning that the matching up can occur much more simply.

Partial fix #1351

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-08-29 15:28:04 +01:00
wxiaoguang
d24eb6e6ce
Add GoLand configuration in hacking on gitea (#16843) 
Co-authored-by: zeripath <art27@cantab.net>
 2021-08-28 23:25:08 -04:00
6543
7815f244d6
CI: rm unit-test-race step since its now coverd by unit-test too (#16856) 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2021-08-29 09:42:56 +08:00
GiteaBot
5e71b9c200 [skip ci] Updated translations via Crowdin 2021-08-29 00:04:59 +00:00
zeripath
c9c0475f4d
In Render tolerate not being passed a context (#16842) 
* In Render tolerate not being passed a context

It is possible for RenderString to be passed to an external renderer if markdown
is set to be rendered by an external renderer. No context is currently sent to these
meaning that this will error out.

Fix #16835

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Add Context to Repo calls for RenderString

All calls from routers can easily add the context - so add it.

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-08-28 21:15:56 +01:00
zeripath
90c0180447
Ensure that the default visibility is set on the user create page (#16845) 
Set the default visibility on the user create page.

Fix #16840

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-08-28 15:19:52 +01:00
Kyle Evans
cad70599a6
Refactor the fork service slightly to take ForkRepoOptions (#16744) 
* Refactor the fork service slightly to take ForkRepoOptions

This reduces the number of places we need to change if we want to add other
options during fork time.

Signed-off-by: Kyle Evans <kevans@FreeBSD.org>

* Fix integrations and tests after ForkRepository refactor

Signed-off-by: Kyle Evans <kevans@FreeBSD.org>

* Update OldRepo -> BaseRepo

Signed-off-by: Kyle Evans <kevans@FreeBSD.org>

* gofmt pass

Signed-off-by: Kyle Evans <kevans@FreeBSD.org>
 2021-08-28 16:37:14 +08:00
zeripath
1904941382
Add test to ensure that dumping of login sources remains correct (#16847) 
#16831 has occurred because of a missed regression. This PR adds a simple test to
try to prevent this occuring again.

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-08-28 04:25:27 +01:00
KN4CK3R
88abb0dc8a
Decoupled code from DefaultSigningKey (#16743) 
Decoupled code from `DefaultSigningKey`. Makes testing a little bit easier and is cleaner.
 2021-08-27 20:28:00 +01:00
zeripath
cd8db3a83d
Prevent "Race" detected in TestAdmin*User (#16830) 
These tests are missing the defer prefix.

Related #1441

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-08-27 15:00:37 +02:00
zeripath
e37342db0c
Add modals to Organization and Team remove/leave (#16471) 
* Add modals to Organization and Team remove/leave

Add confirmation modals to Organization and Team remove and leave.

Fix #16215

Signed-off-by: Andrew Thornton <art27@cantab.net>

* avoid for-in

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Revert "avoid for-in"

This reverts commit 2af9a6f9d46ed31b6fc6e3a29e695577dcf09f75.

* Apply suggestions from code review

Co-authored-by: silverwind <me@silverwind.io>

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2021-08-26 22:57:40 -04:00
GiteaBot
3289aceec2 [skip ci] Updated translations via Crowdin 2021-08-27 00:04:45 +00:00
Mura Li
b60e814055
Enable race detector for CI (#1441) 
* Enable race detector by default

Set RACE_ENABLED=0 to disable it when release

* Disable race detector for release builds

* use `true`

* fix

* debug issue

* fix

* verbose

* clean

* Fix wrong merge

* Fix coverage merge

Co-authored-by: Mura Li <typeless@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2021-08-26 16:50:04 +08:00
GiteaBot
c446901a5d [skip ci] Updated translations via Crowdin 2021-08-26 00:04:46 +00:00
zeripath
ba6baff696
Report the correct number of pushes on the feeds (#16811) 
* Report the correct number of pushes on the feeds

Since the number of commits in the Action table has been limited to 5
the number of commits reported on the feeds page is now incorrectly also
limited to 5. The correct number is available as the Len and this PR
changes this to report this.

Fix #16804

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Update templates/user/dashboard/feeds.tmpl

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2021-08-25 19:04:58 -04:00
Aliaksandr Mianzhynski
28ac4a7a87
Add EdDSA JWT signing algorithm (#16786) 
* Add EdDSA signing algorithm

* Fix typo

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2021-08-25 16:50:38 -04:00
Clar Fon
29b971b6d5
Actually compute proper foreground color for labels (#16729) 2021-08-25 12:55:47 -05:00
delvh
20efc6b56c
Unify migration descriptions (#16781) 
* Unify migration descriptions

* Clarify that pure Git migration differs from other migrations

Co-authored-by: Norwin <noerw@users.noreply.github.com>

* Use Pull Requests for Gitea migration

Co-authored-by: Norwin <noerw@users.noreply.github.com>
Co-authored-by: zeripath <art27@cantab.net>
 2021-08-25 21:47:05 +08:00
Lunny Xiao
b88dbe1208
Use a common quote to instead of check database type (#16817) 
`` ` `` will be converted to different database quote by xorm. So check database type is unnecessary.
 2021-08-25 13:23:34 +01:00
zeripath
697213bdb3
Add primary_key to issue_index (#16813) 
Make the group_id a primary key in issue_index. This already has an unique index
and therefore is a good candidate for becoming a primary key.

This PR also changes all other uses of this table to add the group_id as the
primary key.

Fix #16802

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-08-25 09:42:51 +01:00
zeripath
e891d68dd7
Prevent NPE on empty commit (#16812) 2021-08-24 19:33:23 -04:00
Lunny Xiao
4e761fa385
Fix branch pagination error (#16805) 
Fix #16801

Even if default branch is removed from the current page, but the total branches number should be still kept. So that the pagination calculation will be correct.
 2021-08-24 23:15:07 +01:00
Lunny Xiao
efaf109435
Add information for migrate failure (#16803) 
Improve the reporting of errors when there is a migration failure
 2021-08-24 18:46:55 +01:00
John Olheiser
648464b504
Add bundle download for repository (#14538) 
* Add bundle download

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Fix fmt

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Fix build tags

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Download specific commit

Signed-off-by: jolheiser <john.olheiser@gmail.com>
 2021-08-24 11:47:09 -05:00
GiteaBot
d22cb600ed [skip ci] Updated translations via Crowdin 2021-08-24 00:04:47 +00:00
zeripath
921afb57fb
Add missing return to handleSettingRemoteAddrError (#16794) 
There is a missing return in handleSettingRemoteAddrError which means
that the error page for repo settings is duplicately rendered.

Fix #16771

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2021-08-23 18:09:25 -04:00
zeripath
1cd4a3b963
Update caddyserver/certmagic (#16789) 
Fixes issue with windows users & letsencrypt

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2021-08-23 18:07:40 -04:00
zeripath
f31e7a67cf
Just use a slice when rendering file (#16774) 
Highlight currently uses a map which is memory inefficient. Switch to use a slice instead.

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-08-23 22:23:39 +01:00
zeripath
73defbbd1c
Ensure that template compilation panics are sent to the logs (#16788) 
Although panics within the rendering pipeline are caught and dealt with,
panics that occur before that starts are unprotected and will kill Gitea
without being sent to the logs.

This PR adds a basic recovery handler to catch panics that occur after
the logger is initialised and ensure that they're sent to the logger.

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-08-23 20:40:59 +01:00
GiteaBot
94f529af02 [skip ci] Updated translations via Crowdin 2021-08-23 00:04:31 +00:00
techknowlogick
db1e3d02a5
frontport: 1.15.0 changelog (#16772) 
* frontport: 1.15.0 changelog

* Update config.yaml
 2021-08-22 20:29:51 +01:00
wxiaoguang
b55c699c62
Alter issue/comment table TEXT fields to LONGTEXT (#16765) 
* Alter issue/comment table TEXT fields to LONGTEXT

* Use If not Switch

Co-authored-by: zeripath <art27@cantab.net>
 2021-08-22 23:33:05 +08:00
zeripath
7f85610942
Fix openidConnect source regression from #16544 (#16759) 
Unfortunately there is bug in #16544 meaning that openid connects aren't
being matched properly as the capitalisation in that PR is incorrect.

This PR changes the capitalisation back to what is expected.

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-08-22 10:17:05 +01:00
GiteaBot
208ae9e996 [skip ci] Updated licenses and gitignores 2021-08-22 00:06:14 +00:00
KN4CK3R
cee5f7c5e2
Add migrate from OneDev (#16356) 
* Use context to simplify logic.

* Added migration from OneDev.
This PR adds [OneDev](https://code.onedev.io/) as migration source.

Supported:
- [x] Milestones
- [x] Issues
- [x] Pull Requests
- [x] Comments
- [x] Reviews
- [x] Labels
 2021-08-22 00:47:45 +02:00
wxiaoguang
2d1935acc7
Upgrade go.mod go version to 1.16 (#16764) 2021-08-21 20:04:17 +01:00