1048 Commits

Author	SHA1	Message	Date
yp05327	5a7ab86b98	Avoid run change title process when the title is same (#27467) ... If user only changed the target branch or just did nothing and clicked the `Save` button, you will see the change log as following:  This makes no sense, so we should check whether the title is surely changed before run the `ChangeTitle`.	2023-10-06 18:00:53 +00:00
Eng Zer Jun	13d5d2e711	Remove redundant len check around loop (#27464) ... This pull request is a minor code cleanup. From the Go specification (https://go.dev/ref/spec#For_range): > "1. For a nil slice, the number of iterations is 0." > "3. If the map is nil, the number of iterations is 0." `len` returns 0 if the slice or map is nil (https://pkg.go.dev/builtin#len). Therefore, checking `len(v) > 0` before a loop is unnecessary. --- At the time of writing this pull request, there wasn't a lint rule that catches these issues. The closest I could find is https://staticcheck.dev/docs/checks/#S103 Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>	2023-10-06 14:49:37 +08:00
JakobDev	cc5df26680	Even more db.DefaultContext refactor (#27352) ... Part of #27065 --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: delvh <dev.lh@web.de>	2023-10-03 10:30:41 +00:00
Francesco Antognazza	bc21723717	Make Actions tasks/jobs timeouts configurable by the user (#27400) ... With this PR we added the possibility to configure the Actions timeouts values for killing tasks/jobs. Particularly this enhancement is closely related to the `act_runner` configuration reported below: ``` # The timeout for a job to be finished. # Please note that the Gitea instance also has a timeout (3h by default) for the job. # So the job could be stopped by the Gitea instance if it's timeout is shorter than this. timeout: 3h ``` --- Setting the corresponding key in the INI configuration file, it is possible to let jobs run for more than 3 hours. Signed-off-by: Francesco Antognazza <francesco.antognazza@gmail.com>	2023-10-02 23:09:26 +02:00
delvh	e709bc199f	Differentiate between push and pull mirror sync in progress (#27390) ... Previously, if you had both a push and a pull mirror, the message did not clarify if you've accidentally synchronized the wrong one. Additionally fixed two typos that were encountered while debugging. ## Screenshots  	2023-10-02 14:52:18 +00:00
Earl Warren	cb68e01e22	simplify issue deletion query (#27312) ... - There's no need for `In` to be used, as it's a single parameter that's being passed. Refs: https://codeberg.org/forgejo/forgejo/pulls/1521 (cherry picked from commit 4a4955f43ae7fc50cfe3b48409a0a10c82625a19) Co-authored-by: Gusted <postmaster@gusted.xyz>	2023-10-02 02:30:10 +00:00
CaiCandong	87aa552531	Fix unexpected context canceled when migrating repository (#27368) ... Fix #27363 Regression of #27089	2023-10-01 12:04:35 +00:00
CaiCandong	7ad31567cd	Fix ldap admin privileges update bug (#27051) ... When the user does not set a username lookup condition, LDAP will get an empty string `""` for the user, hence the following code ``` if isExist, err := user_model.IsUserExist(db.DefaultContext, 0, sr.Username) ``` The user presence determination will always be nonexistent, so updates to user information will never be performed. Fix #27049	2023-10-01 11:32:12 +00:00
Lunny Xiao	6e87a44034	Allow get release download files and lfs files with oauth2 token format (#26430) ... Fix #26165 Fix #25257	2023-10-01 10:41:52 +00:00
JakobDev	cf0df023be	More db.DefaultContext refactor (#27265) ... Part of #27065 This PR touches functions used in templates. As templates are not static typed, errors are harder to find, but I hope I catch it all. I think some tests from other persons do not hurt.	2023-09-29 12:12:54 +00:00
Dmitry Sharshakov	5e02e3b7ee	Add support for forking single branch (#25821) ... Fixes #25117 Add UI for choosing branch to fork Change default branch on single-branch forks  --------- Co-authored-by: Denys Konovalov <kontakt@denyskon.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-09-29 09:48:39 +08:00
JakobDev	1c039b4e1e	Fix Bug in Issue Config when only contact links are set (#26521) ... Blank Issues should be enabled if they are not explicit disabled through the `blank_issues_enabled` field of the Issue Config. The Implementation has currently a Bug: If you create a Issue Config file with only `contact_links` and without a `blank_issues_enabled` field, `blank_issues_enabled` is set to false by default. The fix is only one line, but I decided to also improve the tests to make sure there are no other problems with the Implementation. This is a bugfix, so it should be backported to 1.20.	2023-09-28 20:16:40 +08:00
Lunny Xiao	673cf6af76	make writing main test easier (#27270) ... This PR removed `unittest.MainTest` the second parameter `TestOptions.GiteaRoot`. Now it detects the root directory by current working directory. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-09-28 01:38:53 +00:00
JakobDev	7047df36d4	Another round of db.DefaultContext refactor (#27103) ... Part of #27065 --------- Co-authored-by: KN4CK3R <admin@oldschoolhack.me>	2023-09-25 13:17:37 +00:00
Nabapadma-sarker	8e23524b18	Fix PushEvent NullPointerException jenkinsci/github-plugin (#27203) ... Fixes #27202	2023-09-24 19:02:47 +00:00
Daniel Kilimnik	0ee7cbf725	Fix push mirror, wrong timestamp format (#27153) ... I noticed, that the push mirrors endpoint, is the only endpoint which returns the times in long format rather than as time.Time(). I think the behavior should be consistent across the project. ---- ## ⚠️ BREAKING ⚠️ This PR changes the time format used in API responses for all push_mirror endpoints which return a push mirror. --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-09-23 12:15:05 +00:00
JakobDev	28f9b313ba	Updates to the API for archived repos (#27149)	2023-09-21 23:43:29 +00:00
John Olheiser	7520cd678c	Fix release URL in webhooks (#27182)	2023-09-21 17:55:09 -05:00
delvh	707c69f399	Fix successful return value for SyncAndGetUserSpecificDiff (#27152) ... A function should not return an error when it is successful. Otherwise, things like https://discord.com/channels/322538954119184384/322538954119184384/1153705341620600833 happen…	2023-09-20 22:28:17 +02:00
wxiaoguang	2814f2fea1	Fix incorrect test code for error handling (#27139) ... If `assert.NoError` fails, it should return. Otherwise the code could still execute even if the error occurs.	2023-09-20 08:51:36 +08:00
silverwind	1b1c55f73f	Increase auth provider icon size on login page (#27122) ... Before, 20px: <img width="474" alt="Screenshot 2023-09-19 at 00 10 05" src="https://github.com/go-gitea/gitea/assets/115237/4bed4edb-219d-4844-9d3c-0d747033b09f"> After, 28px: <img width="576" alt="Screenshot 2023-09-19 at 00 20 40" src="https://github.com/go-gitea/gitea/assets/115237/f482ac09-38ae-4c84-80d9-0bd39b7f9772"> Dropdown in account settings is unchanged at 20px: <img width="157" alt="Screenshot 2023-09-19 at 00 09 11" src="https://github.com/go-gitea/gitea/assets/115237/9c998cdf-eeed-4118-9262-664faaa56092"> --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-09-19 21:47:13 +00:00
Earl Warren	f7c64976d5	services/wiki: Close() after error handling (#27129) ... Refs: https://codeberg.org/forgejo/forgejo/pulls/1385 Signed-off-by: Lars Lehtonen <lars.lehtonen@gmail.com> (cherry picked from commit 589e7d346f51de4a0e2c461b220c8cad34133b2f) Co-authored-by: Lars Lehtonen <lars.lehtonen@gmail.com>	2023-09-19 16:45:44 +02:00
wxiaoguang	8531ca0837	Make SSPI auth mockable (#27036) ... Before, the SSPI auth is only complied for Windows, it's difficult to test and it breaks a lot. Now, make the SSPI auth mockable and testable.	2023-09-17 23:32:56 +00:00
Lunny Xiao	47b878858a	Search branches (#27055) ... Resolve #25233 <img width="1315" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/3ba59b58-471a-4e1b-985c-87edac2268c0"> <img width="1297" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/b6caa12f-323b-4f70-9c44-ef91cb71a26c">	2023-09-17 08:24:40 +00:00
KN4CK3R	c766140dad	Add RemoteAddress to mirrors (#26952) ... This PR adds a new field `RemoteAddress` to both mirror types which contains the sanitized remote address for easier (database) access to that information. Will be used in the audit PR if merged.	2023-09-16 16:03:02 +00:00
JakobDev	f91dbbba98	Next round of db.DefaultContext refactor (#27089) ... Part of #27065	2023-09-16 14:39:12 +00:00
JakobDev	c548dde205	More refactoring of db.DefaultContext (#27083) ... Next step of #27065	2023-09-15 06:13:19 +00:00
JakobDev	76659b1114	Reduce usage of db.DefaultContext (#27073) ... Part of #27065 This reduces the usage of `db.DefaultContext`. I think I've got enough files for the first PR. When this is merged, I will continue working on this. Considering how many files this PR affect, I hope it won't take to long to merge, so I don't end up in the merge conflict hell. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-09-14 17:09:32 +00:00
Nanguan Lin	da50be7360	Replace 'userxx' with 'orgxx' in all test files when the user type is org (#27052) ... Currently 'userxx' and 'orgxx' are both used as username in test files when the user type is org, which is confusing. This PR replaces all 'userxx' with 'orgxx' when the user type is org(`user.type==1`). Some non-trivial changes 1. Rename `user3` dir to `org3` in `tests/git-repositories-meta` 2. Change `end` in `issue reference` because 'org3' is one char shorter than 'user3'  3. Change the search result number of `user/repo2` because `user3/repo21` can't be searched now  4. Change the first org name getting from API because the result is ordered by alphabet asc and now `org 17` is before `org25`   Other modifications are just find all and replace all. Unit tests with SQLite are all passed. --------- Co-authored-by: caicandong <1290147055@qq.com>	2023-09-14 02:59:53 +00:00
sebastian-sauer	e116ad4500	Load reviewer before sending notification (#27063) ... The [template](https://github.com/go-gitea/gitea/blob/main/templates/mail/issue/default.tmpl#L51) uses the Reviewer.Name property - this was not loaded. Fixes #27035	2023-09-13 19:48:36 +00:00
Nanguan Lin	cda97a7253	Update status and code index after changing the default branch (#27018) ... Fix #26723 Add `ChangeDefaultBranch` to the `notifier` interface and implement it in `indexerNotifier`. So when changing the default branch, `indexerNotifier` sends a message to the `indexer queue` to update the index. --------- Co-authored-by: techknowlogick <matti@mdranta.net>	2023-09-13 04:43:31 +00:00
KN4CK3R	591f586bf1	Extract auth middleware from service (#27028) ... Related #27027 Extract the router logic from `services/auth/middleware.go` into `routers/web` <-> `routers/common` <-> `routers/api`.	2023-09-12 08:15:16 +02:00
Lunny Xiao	e3ed67859a	Move some functions to service layer (#26969)	2023-09-08 21:09:23 +00:00
Lunny Xiao	9c0a3532a4	Add a new column schedule_id for action_run to track (#26975) ... Fix #26971 And the UI now will display it's scheduled but not triggered by a push. <img width="954" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/d211845c-457e-4c3e-af1f-a0d654d3f365">	2023-09-08 23:01:19 +08:00
Lunny Xiao	4f32abaf94	move repository deletion to service layer (#26948) ... Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-09-08 04:51:15 +00:00
Jack Hay	1a9953348c	Team invite url fix when registration disabled (#26950) ... This is a follow-on to https://github.com/go-gitea/gitea/pull/26550 and fixes the case where the team invite links to the registration page if it is disabled in settings.	2023-09-07 14:50:45 +00:00
Lunny Xiao	d1dca38a2a	Fix schedule actions still running even if workflow disalbed (#26939) ... Fix #26782	2023-09-07 10:25:46 +08:00
Lunny Xiao	b9df9fa2e2	Move createrepository from module to service layer (#26927) ... Repository creation depends on many models, so moving it to service layer is better.	2023-09-06 12:08:51 +00:00
FuXiaoHei	460a2b0edf	Artifacts retention and auto clean up (#26131) ... Currently, Artifact does not have an expiration and automatic cleanup mechanism, and this feature needs to be added. It contains the following key points: - [x] add global artifact retention days option in config file. Default value is 90 days. - [x] add cron task to clean up expired artifacts. It should run once a day. - [x] support custom retention period from `retention-days: 5` in `upload-artifact@v3`. - [x] artifacts link in actions view should be non-clickable text when expired.	2023-09-06 07:41:06 +00:00
yp05327	0850be6750	Fix the display of org level badges (#26504) ... Follow #24654 #22705 #24232 In some pages we still have missing badges, for example:   	2023-09-06 14:38:14 +08:00
Lunny Xiao	540bf9fa6d	Move notification interface to services layer (#26915) ... Extract from #22266	2023-09-05 18:37:47 +00:00
Sven Seeberg	5f7fa27a44	Improve LDAP group config documentation, fixes #21159 (#21227) ... Improve the wording of the LDAP group attributes documentation and expand the examples.	2023-09-05 13:18:53 -04:00
KN4CK3R	0eebeeec90	Remove Named interface (#26913) ... `Named` is implemented by every `Method` and future implementations should implement the method too.	2023-09-05 15:58:30 +00:00
KN4CK3R	a99b96cbcd	Refactor secrets modification logic (#26873) ... - Share code between web and api - Add some tests	2023-09-05 15:21:02 +00:00
Lunny Xiao	f064d716c3	Move feed notification service layer (#26908) ... Extract from #22266	2023-09-05 13:00:52 +00:00
Lunny Xiao	6c73c0da53	Move ui notification to service layer (#26907) ... Extract from #22266	2023-09-05 11:15:42 +00:00
Lunny Xiao	aa678b8098	Move indexer notification to service layer (#26906) ... Extract from #22266	2023-09-05 10:07:57 +00:00
Lunny Xiao	a66d883a18	Move mail notification logic to service layer (#26905) ... Extract from #22266	2023-09-05 17:26:59 +08:00
wxiaoguang	fc039167d2	Use Go 1.21 and update dependencies (#26878) ... To make sure Gitea's next release's lifecycle could have active Golang support. And min/max are builtin now.	2023-09-03 10:34:57 +00:00
wxiaoguang	e8aae43f56	Move web/api context related testing function into a separate package (#26859) ... Just like `models/unittest`, the testing helper functions should be in a separate package: `contexttest` And complete the TODO: > // TODO: move this function to other packages, because it depends on "models" package	2023-09-01 11:26:07 +00:00