1234 Commits

Author	SHA1	Message	Date
wxiaoguang	2df7563f31	Recommend/convert to use case-sensitive collation for MySQL/MSSQL (#28662) ... Mainly for MySQL/MSSQL. It is important for Gitea to use case-sensitive database charset collation. If the database is using a case-insensitive collation, Gitea will show startup error/warning messages, and show the errors/warnings on the admin panel's Self-Check page. Make `gitea doctor convert` work for MySQL to convert the collations of database & tables & columns. * Fix #28131 ## ⚠️ BREAKING ⚠️ It is not quite breaking, but it's highly recommended to convert the database&table&column to a consistent and case-sensitive collation.	2024-01-10 11:03:23 +00:00
Kyle D	54acf7b0d4	Normalize oauth email username (#28561)	2024-01-03 18:48:20 -06:00
wxiaoguang	e5d8c4b8d4	Avoid cycle-redirecting user/login page (#28636) ... Fix #28231, and remove some unused code. The `db.HasEngine` doesn't seem useful because the db engine is always initialized before web route.	2023-12-30 08:48:34 +00:00
wxiaoguang	f3999888c0	Refactor some legacy code and remove unused code (#28622) ... 1. use slices.Contains, remove Int64sContains 2. use HashEmail, remove base.EncodeMD5 3. remove BasicAuthEncode, IsLetter	2023-12-28 09:38:59 +00:00
katsu	42149ff1a8	fix wrong link in user and organization profile when using relative url (#28617) ... fix #28436. the doc https://docs.gitea.com/usage/profile-readme maybe also need to be updated to tell that the main branch is necessary,which means the following three conditions should be satisfied: - repo: **.profile** - branch: **[default branch]** - markdown: **README.md**	2023-12-27 08:32:27 +00:00
delvh	778ad795fd	Refactor deletion (#28610) ... Introduce the new generic deletion methods - `func DeleteByID[T any](ctx context.Context, id int64) (int64, error)` - `func DeleteByIDs[T any](ctx context.Context, ids ...int64) error` - `func Delete[T any](ctx context.Context, opts FindOptions) (int64, error)` So, we no longer need any specific deletion method and can just use the generic ones instead. Replacement of #28450 Closes #28450 --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2023-12-25 21:25:29 +01:00
wxiaoguang	b41925cee3	Refactor CORS handler (#28587) ... The CORS code has been unmaintained for long time, and the behavior is not correct. This PR tries to improve it. The key point is written as comment in code. And add more tests. Fix #28515 Fix #27642 Fix #17098	2023-12-25 20:13:18 +08:00
Jean-Baptiste Gomond	d0f24ff4ca	Added instance-level variables (#28115) ... This PR adds instance-level variables, and so closes #27726   	2023-12-25 07:28:59 +00:00
wxiaoguang	330aab47b3	Include heap pprof in diagnosis report to help debugging memory leaks (#28596)	2023-12-23 19:06:02 +00:00
Zettat123	907c97aabb	Fix `status_check_contexts` matching bug (#28582) ... Fix #28570 Follow #24633 --- Copied from https://github.com/go-gitea/gitea/issues/28570#issuecomment-1867327999 The feature introduced in #24633 should be compatible with `status_check_contexts`. However, if one or more of `status_check_contexts` is not a legal glob expressions, `glob.Compile` will fail and the contexts cannot match. 21229ed2c8/routers/web/repo/pull.go (L653-L663)	2023-12-22 13:29:50 +00:00
morphelinho	19869d1c11	Fix 405 method not allowed CORS / OIDC (#28583) ... Follow #28184 Follow #28515 Fix problem with 405 method not allowed for CORS wrt OIDC	2023-12-22 12:23:24 +00:00
KN4CK3R	3142693892	Use information from previous blame parts (#28572) ... Fixes #28545 `git blame` output can contain blocks without commit information if it was outputted before (the `0dafa97ea3f6d9662299579e5be1875cd28baaae 48 26 1` line): ``` fec25436488499df7231f63b857f66457c193d5c 24 25 1 author Bastien Montagne author-mail <bastien@blender.org> author-time 1660731031 author-tz +0200 committer Bastien Montagne committer-mail <bastien@blender.org> committer-time 1660731031 committer-tz +0200 summary LibOverride: Add Make/Reset/Clear entries to IDTemplate contextual menu. previous 839ece6477203382b7a7483062961540180ff1cd source/blender/editors/interface/interface_ops.c filename source/blender/editors/interface/interface_ops.c #include "BLT_translation.h" 0dafa97ea3f6d9662299579e5be1875cd28baaae 48 26 1 3d57bc4397fca53bc9702a27bbf50102827829b0 27 27 1 author Hans Goudey author-mail <hans@blender.org> author-time 1700131315 author-tz +0100 committer Hans Goudey committer-mail <hooglyboogly@noreply.localhost> committer-time 1700131315 committer-tz +0100 summary Cleanup: Move several blenkernel headers to C++ previous 451c054d9b7d3148a646caa5a72fb127a5b5c408 source/blender/editors/interface/interface_ops.cc filename source/blender/editors/interface/interface_ops.cc #include "BKE_context.hh" ``` This PR reuses data from the previous blame part to fill these gaps.	2023-12-21 22:48:18 +01:00
Lunny Xiao	e7cb8da2a8	Always enable caches (#28527) ... Nowadays, cache will be used on almost everywhere of Gitea and it cannot be disabled, otherwise some features will become unaviable. Then I think we can just remove the option for cache enable. That means cache cannot be disabled. But of course, we can still use cache configuration to set how should Gitea use the cache.	2023-12-19 09:29:05 +00:00
Lunny Xiao	4eb2a29910	Improve ObjectFormat interface (#28496) ... The 4 functions are duplicated, especially as interface methods. I think we just need to keep `MustID` the only one and remove other 3. ``` MustID(b []byte) ObjectID MustIDFromString(s string) ObjectID NewID(b []byte) (ObjectID, error) NewIDFromString(s string) (ObjectID, error) ``` Introduced the new interfrace method `ComputeHash` which will replace the interface `HasherInterface`. Now we don't need to keep two interfaces. Reintroduced `git.NewIDFromString` and `git.MustIDFromString`. The new function will detect the hash length to decide which objectformat of it. If it's 40, then it's SHA1. If it's 64, then it's SHA256. This will be right if the commitID is a full one. So the parameter should be always a full commit id. @AdamMajer Please review.	2023-12-19 07:20:47 +00:00
yp05327	4ea522fecf	Only check online runner when detecting matching runners in workflows (#28286) ... Mentioned: [#28277](https://github.com/go-gitea/gitea/issues/28277#issuecomment-1831325276) We should only check online runner when detecting matching runners in workflows, as if runner is not online, the workflow will not run. 	2023-12-18 16:06:19 +00:00
wxiaoguang	20929edc99	Add option to disable ambiguous unicode characters detection (#28454) ... * Close #24483 * Close #28123 * Close #23682 * Close #23149 (maybe more)	2023-12-17 14:38:54 +00:00
Lunny Xiao	408a484224	Adjust object format interface (#28469) ... - Remove `ObjectFormatID` - Remove function `ObjectFormatFromID`. - Use `Sha1ObjectFormat` directly but not a pointer because it's an empty struct. - Store `ObjectFormatName` in `repository` struct	2023-12-17 11:56:08 +00:00
Adam Majer	cbf923e87b	Abstract hash function usage (#28138) ... Refactor Hash interfaces and centralize hash function. This will allow easier introduction of different hash function later on. This forms the "no-op" part of the SHA256 enablement patch.	2023-12-13 21:02:00 +00:00
Lunny Xiao	717d0f5934	Do some missing checks (#28423)	2023-12-12 05:01:17 +00:00
Lunny Xiao	537fa69962	Second part of refactor `db.Find` (#28194) ... Continue of #27798 and move more functions to `db.Find` and `db.Count`.	2023-12-11 16:56:48 +08:00
yp05327	0abb5633e3	Fix commit status in repo list (#28412) ... Before:   `TestOrg/testactions` does have commit status, but won't display in `All` After:  Same to #26179.	2023-12-11 06:19:57 +00:00
Lunny Xiao	9a99c17a14	Fix missing check (#28406)	2023-12-10 21:37:10 +02:00
Lunny Xiao	aeb383025f	Also sync DB branches on push if necessary (#28361) ... Fix #28056 This PR will check whether the repo has zero branch when pushing a branch. If that, it means this repository hasn't been synced. The reason caused that is after user upgrade from v1.20 -> v1.21, he just push branches without visit the repository user interface. Because all repositories routers will check whether a branches sync is necessary but push has not such check. For every repository, it has two states, synced or not synced. If there is zero branch for a repository, then it will be assumed as non-sync state. Otherwise, it's synced state. So if we think it's synced, we just need to update branch/insert new branch. Otherwise do a full sync. So that, for every push, there will be almost no extra load added. It's high performance than yours. For the implementation, we in fact will try to update the branch first, if updated success with affect records > 0, then all are done. Because that means the branch has been in the database. If no record is affected, that means the branch does not exist in database. So there are two possibilities. One is this is a new branch, then we just need to insert the record. Another is the branches haven't been synced, then we need to sync all the branches into database.	2023-12-09 13:30:56 +00:00
Jason Song	beb71f5ef6	Include public repos in doer's dashboard for issue search (#28304) ... It will fix #28268 . <img width="1313" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/cb1e07d5-7a12-4691-a054-8278ba255bfc"> <img width="1318" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/4fd60820-97f1-4c2c-a233-d3671a5039e9"> ## ⚠️ BREAKING ⚠️ But need to give up some features: <img width="1312" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/281c0d51-0e7d-473f-bbed-216e2f645610"> However, such abandonment may fix #28055 . ## Backgroud When the user switches the dashboard context to an org, it means they want to search issues in the repos that belong to the org. However, when they switch to themselves, it means all repos they can access because they may have created an issue in a public repo that they don't own. <img width="286" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/182dcd5b-1c20-4725-93af-96e8dfae5b97"> It's a confusing design. Think about this: What does "In your repositories" mean when the user switches to an org? Repos belong to the user or the org? Whatever, it has been broken by #26012 and its following PRs. After the PR, it searches for issues in repos that the dashboard context user owns or has been explicitly granted access to, so it causes #28268. ## How to fix it It's not really difficult to fix it. Just extend the repo scope to search issues when the dashboard context user is the doer. Since the user may create issues or be mentioned in any public repo, we can just set `AllPublic` to true, which is already supported by indexers. The DB condition will also support it in this PR. But the real difficulty is how to count the search results grouped by repos. It's something like "search issues with this keyword and those filters, and return the total number and the top results. **Then, group all of them by repo and return the counts of each group.**" <img width="314" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/5206eb20-f8f5-49b9-b45a-1be2fcf679f4"> Before #26012, it was being done in the DB, but it caused the results to be incomplete (see the description of #26012). And to keep this, #26012 implement it in an inefficient way, just count the issues by repo one by one, so it cannot work when `AllPublic` is true because it's almost impossible to do this for all public repos. 1bfcdeef4c/modules/indexer/issues/indexer.go (L318-L338) ## Give up unnecessary features We may can resovle `TODO: use "group by" of the indexer engines to implement it`, I'm sure it can be done with Elasticsearch, but IIRC, Bleve and Meilisearch don't support "group by". And the real question is, does it worth it? Why should we need to know the counts grouped by repos? Let me show you my search dashboard on gitea.com. <img width="1304" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/2bca2d46-6c71-4de1-94cb-0c9af27c62ff"> I never think the long repo list helps anything. And if we agree to abandon it, things will be much easier. That is this PR. ## TODO I know it's important to filter by repos when searching issues. However, it shouldn't be the way we have it now. It could be implemented like this. <img width="1316" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/99ee5f21-cbb5-4dfe-914d-cb796cb79fbe"> The indexers support it well now, but it requires some frontend work, which I'm not good at. So, I think someone could help do that in another PR and merge this one to fix the bug first. Or please block this PR and help to complete it. Finally, "Switch dashboard context" is also a design that needs improvement. In my opinion, it can be accomplished by adding filtering conditions instead of "switching".	2023-12-07 13:26:18 +08:00
yp05327	ec90ee61ef	Fix object does not exist error when checking citation file (#28314) ... Fix #28264 `DataAsync()` will be called twice. Caused by https://github.com/go-gitea/gitea/pull/27958. I'm sorry, I didn't completely remove all unnecessary codes.	2023-12-06 16:51:01 +08:00
Lunny Xiao	09d5028442	Fix the runs will not be displayed bug when the main branch have no workflows but other branches have (#28359)	2023-12-06 01:13:59 +00:00
KN4CK3R	14354e4f8e	Read `previous` info from git blame (#28306) ... Fixes #28280 Reads the `previous` info from the `git blame` output instead of calculating it afterwards.	2023-12-01 01:26:52 +00:00
JakobDev	3618715fab	Add missing variable in tag list (#28305) ... This fixes a regression from #25859 If a tag has no Release, Gitea will show a Link to create a Release for the Tag if the User has the Permission to do this, but the variable to indicate that is no longer set. Used here: 1bfcdeef4c/templates/repo/tag/list.tmpl (L39-L41)	2023-11-30 16:26:56 +01:00
yp05327	8572e71a7f	Fix issue will be detected as pull request when checking `First-time contributor` (#28237) ... Fix #28224	2023-11-27 10:46:55 +00:00
Lunny Xiao	882e502327	Fix comment permissions (#28213) ... This PR will fix some missed checks for private repositories' data on web routes and API routes.	2023-11-25 17:21:21 +00:00
Lunny Xiao	df1e7d0067	Use db.Find instead of writing methods for every object (#28084) ... For those simple objects, it's unnecessary to write the find and count methods again and again.	2023-11-24 03:49:41 +00:00
wxiaoguang	7c0ab8b974	Make CORS work for oauth2 handlers (#28184) ... Fix #25473 Although there was `m.Post("/login/oauth/access_token", CorsHandler()...`, it never really worked, because it still lacks the "OPTIONS" handler.	2023-11-23 21:19:26 +08:00
Nanguan Lin	37ed92d6fd	Revert "Fix EOL handling in web editor" (#28101) ... Reverts go-gitea/gitea#27141 close #28097	2023-11-22 09:14:16 +00:00
JakobDev	08552f0076	Add edit option for README.md (#28071) ... Fix #28059 	2023-11-20 11:47:55 +00:00
yp05327	e88377470a	Fix project counter in organization/individual profile (#28068) ... Fix #28052 Before:   After:  	2023-11-18 11:02:42 +08:00
JakobDev	48b9d98593	Fix viewing wiki commit on empty repo (#28040) ... Fixes https://codeberg.org/forgejo/forgejo/issues/1758 For some weird reason we need to cast this nil.	2023-11-14 19:42:23 +08:00
6543	c6366089df	Dont leak private users via extensions (#28023)	2023-11-13 16:30:24 -06:00
yp05327	089ac06969	Improve profile for Organizations (#27982) ... Fixes some problems in #27955: - autofocus of the search box before: if access the home page will jump to the search box  after: will not jump to the search box  - incorrect display of overview tab before:  after:  - improve the permission check to the private profile repo In #26295, we simply added access control to the private profile. But if user have access to the private profile repo , we should also display the profile. - add a button which can jump to the repo list? I agree @wxiaoguang 's opinion here: https://github.com/go-gitea/gitea/pull/27955#issuecomment-1803178239 But it seems that this feature is sponsored. So can we add a button which can quickly jump to the repo list or just move profile to the `overview` page? --------- Co-authored-by: silverwind <me@silverwind.io>	2023-11-13 15:33:22 +01:00
6543	603573366a	Add Profile Readme for Organisations (#27955) ... https://blog.gitea.com/release-of-1.20.0/#-user-profile-readme-23260 (#23260) did introduce Profile Readme for Users. This makes it usable for Organisations:  --- *Sponsored by Kithara Software GmbH* --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>	2023-11-09 14:05:52 +00:00
6543	16ba16dbe9	Allow to set explore page default sort (#27951) ... as title --- *Sponsored by Kithara Software GmbH*	2023-11-09 10:11:45 +00:00
yp05327	f48a863b99	Fix citation error when the file size is larger than 1024 bytes (#27958) ... Mentioned in: https://github.com/go-gitea/gitea/pull/27931#issuecomment-1798016960 Same to #25131, so use the same method to fix this problem.	2023-11-08 06:40:12 +00:00
KN4CK3R	8557a9455b	Revert #27870 (#27917) ... Now that we have #27798 we don't need the check from #27870 anymore. With the check it's not possible to remove an inactive auth source from the user.	2023-11-06 06:09:34 +00:00
Lunny Xiao	1bf5527eac	Refactor Find Sources and fix bug when view a user who belongs to an unactive auth source (#27798) ... The steps to reproduce it. First, create a new oauth2 source. Then, a user login with this oauth2 source. Disable the oauth2 source. Visit users -> settings -> security, 500 will be displayed. This is because this page only load active Oauth2 sources but not all Oauth2 sources.	2023-11-03 01:41:00 +00:00
Lunny Xiao	0ba4ecc3bd	Fix http protocol auth (#27875)	2023-11-02 22:14:33 +08:00
KN4CK3R	e378545f30	Filter inactive auth sources (#27870) ... Fix nil access for inactive auth sources. > Render failed, failed to render template: user/settings/security/security, error: template error: builtin(static):user/settings/security/accountlinks:32:20 : executing "user/settings/security/accountlinks" at <$providerData.IconHTML>: nil pointer evaluating oauth2.Provider.IconHTML Code tries to access the auth source of an `ExternalLoginUser` but the list contains only the active auth sources.	2023-11-02 01:46:26 +02:00
Brecht Van Lommel	1756e30e10	Allow pull requests Manually Merged option to be used by non-admins (#27780) ... Currently this feature is only available to admins, but there is no clear reason why. If a user can actually merge pull requests, then this seems fine as well. This is useful in situations where direct pushes to the repository are commonly done by developers. --------- Co-authored-by: delvh <dev.lh@web.de>	2023-10-30 11:13:06 +08:00
853	e544a277fe	Fix the missing repo count in new team page and edit team page (#27743) ... Follow #26942 Before:   After:  	2023-10-25 13:55:56 +08:00
silverwind	ce83609ff6	Upgrade to golangci-lint@v1.55.0 (#27756) ... https://github.com/golangci/golangci-lint/releases/tag/v1.55.0	2023-10-24 02:54:59 +00:00
Nanguan Lin	61d94b247a	Fix `link-action` redirect network error (#27734) ... <img width="823" alt="image" src="https://github.com/go-gitea/gitea/assets/70063547/99da3d5a-c28a-4fd0-8ae0-88461a9142e2"> --------- Co-authored-by: 6543 <6543@obermui.de>	2023-10-23 20:34:17 +08:00
Nanguan Lin	881806a50b	Replace -1 with GhostUserID (#27703)	2023-10-20 14:43:08 +00:00
6543	adbc995c34	Show total TrackedTime on issue/pull/milestone lists (#26672) ... TODOs: - [x] write test for `GetIssueTotalTrackedTime` - [x] frontport kitharas template changes and make them mobile-friendly ---   --- *Sponsored by Kithara Software GmbH*	2023-10-19 14:08:31 +00:00
JakobDev	3dc0c962bf	Delete repos of org when purge delete user (#27273) ... Fixes https://codeberg.org/forgejo/forgejo/issues/1514 I had to remove `RenameOrganization` to avoid circular import. We should really add some foreign keys to the database.	2023-10-19 13:16:11 +00:00
Jason Song	0a2b93d411	Fix typo "GetLatestRunnerToken" (#27680)	2023-10-18 15:52:44 +00:00
yp05327	8abc1aae4a	Improve the list header in milestone page (#27302) ... The ui of list header in milestone page is not same as issue and pr list page. And they are using different template codes which can be merged into one. Before:     After:   --------- Co-authored-by: puni9869 <80308335+puni9869@users.noreply.github.com>	2023-10-18 00:03:42 +00:00
Lunny Xiao	cddf245c12	Replace more db.DefaultContext (#27628) ... Target #27065	2023-10-15 17:46:06 +02:00
Nanguan Lin	7480aacdad	Fix 404 when there is an internal version of package (#27615) ... close #27601 The Docker registry has an internal version, which leads to 404	2023-10-15 09:22:10 +00:00
JakobDev	76a85a4ce9	Final round of `db.DefaultContext` refactor (#27587) ... Last part of #27065	2023-10-14 08:37:24 +00:00
KN4CK3R	c6c829fe3f	Enhanced auth token / remember me (#27606) ... Closes #27455 > The mechanism responsible for long-term authentication (the 'remember me' cookie) uses a weak construction technique. It will hash the user's hashed password and the rands value; it will then call the secure cookie code, which will encrypt the user's name with the computed hash. If one were able to dump the database, they could extract those two values to rebuild that cookie and impersonate a user. That vulnerability exists from the date the dump was obtained until a user changed their password. > > To fix this security issue, the cookie could be created and verified using a different technique such as the one explained at https://paragonie.com/blog/2015/04/secure-authentication-php-with-long-term-persistence#secure-remember-me-cookies. The PR removes the now obsolete setting `COOKIE_USERNAME`.	2023-10-14 00:56:41 +00:00
JakobDev	328da56a28	Don't show Link to TOTP if not set up (#27585)	2023-10-11 20:12:54 +00:00
silverwind	73b63d9311	Replace ajax with fetch, improve image diff (#27267) ... 1. Dropzone attachment removal, pretty simple replacement 2. Image diff: The previous code fetched every image twice, once via `img[src]` and once via `$.ajax`. Now it's only fetched once and a second time only when necessary. The image diff code was partially rewritten. --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-10-11 12:34:21 +00:00
JakobDev	ebe803e514	Penultimate round of `db.DefaultContext` refactor (#27414) ... Part of #27065 --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2023-10-11 04:24:07 +00:00
Sergey Zolotarev	7b79be24ca	Fix panic in storageHandler (#27446) ... storageHandler() is written as a middleware but is used as an endpoint handler, and thus `next` is actually `nil`, which causes a null pointer dereference when a request URL does not match the pattern (where it calls `next.ServerHTTP()`). Example CURL command to trigger the panic: ``` curl -I "http://yourhost/gitea//avatars/a" ``` Fixes #27409 --- Note: the diff looks big but it's actually a small change - all I did was to remove the outer closure (and one level of indentation) ~and removed the HTTP method and pattern checks as they seem redundant because go-chi already does those checks~. You might want to check "Hide whitespace" when reviewing it. Alternative solution (a bit simpler): append `, misc.DummyOK` to the route declarations that utilize `storageHandler()` - this makes it return an empty response when the URL is invalid. I've tested this one and it works too. Or maybe it would be better to return a 400 error in that case (?)	2023-10-06 13:23:14 +00:00
Eng Zer Jun	13d5d2e711	Remove redundant `len` check around loop (#27464) ... This pull request is a minor code cleanup. From the Go specification (https://go.dev/ref/spec#For_range): > "1. For a nil slice, the number of iterations is 0." > "3. If the map is nil, the number of iterations is 0." `len` returns 0 if the slice or map is nil (https://pkg.go.dev/builtin#len). Therefore, checking `len(v) > 0` before a loop is unnecessary. --- At the time of writing this pull request, there wasn't a lint rule that catches these issues. The closest I could find is https://staticcheck.dev/docs/checks/#S103 Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>	2023-10-06 14:49:37 +08:00
wxiaoguang	9f8d59858a	Refactor system setting (#27000) ... This PR reduces the complexity of the system setting system. It only needs one line to introduce a new option, and the option can be used anywhere out-of-box. It is still high-performant (and more performant) because the config values are cached in the config system.	2023-10-05 09:08:19 +08:00
Lunny Xiao	fe68bbeea0	When comparing with an non-exist repository, return 404 but 500 (#27437)	2023-10-04 13:59:03 +00:00
JakobDev	cc5df26680	Even more `db.DefaultContext` refactor (#27352) ... Part of #27065 --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: delvh <dev.lh@web.de>	2023-10-03 10:30:41 +00:00
delvh	e709bc199f	Differentiate between `push` and `pull` `mirror sync in progress` (#27390) ... Previously, if you had both a push and a pull mirror, the message did not clarify if you've accidentally synchronized the wrong one. Additionally fixed two typos that were encountered while debugging. ## Screenshots  	2023-10-02 14:52:18 +00:00
wxiaoguang	e4313feefd	Document the line-number counting behavior (#27386) ... Ref #27377	2023-10-02 07:23:18 +00:00
puni9869	50070550a8	Hide archived labels when filtering by labels on the issue list (#27115) ... Followup https://github.com/go-gitea/gitea/pull/26820 ## Archived labels UI for issue filter and issue filter actions for issues/pull request pages. Changed: * Enhanced the Issue filter and Issue filter actions UI page to seamlessly incorporate a list of archived labels. * Pagination functionality is same as before. If archived label checkbox is checked then we are adding a query string`archived=true` in the url to save the state of page. * Issue filter actions menu is separated into different template. * Adding the archived flag in issue url labels. * Pull Request page is also work the same. Outsourced: * Defer the implementation of specialized handling for archived labels to upcoming pull requests. This step will be undertaken subsequent to the successful merge of this pull request. Screenshots ### Issue page <img width="1360" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/d7efb2ef-5b2b-449d-83f0-d430a32ec432"> ### Issue page with label filter on archived label checkbox when not checked --> No archived label is there in list <img width="1249" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/ceea68ef-91f2-4693-910f-2e25e236bfc9"> ### Issue page with label filter on archived label checkbox when checked --> Show archived label in the list. <img width="710" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/2414d26b-2079-4c3c-bd9e-f2f5411bcabf"> ### Issue page with label filter on issue action menu on archived label checkbox when checked --> Show archived label in the list. <img width="409" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/259cac87-3e21-4778-99a2-a6a0b8c81178"> ### Applied the archived=true in Issue labels when archived checkbox is checked. <img width="984" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/657ce3db-c0ae-402e-b12d-3b580d3c2ed0"> --- Part of https://github.com/go-gitea/gitea/issues/25237 --------- Signed-off-by: puni9869 <punitinani1@hotmail.com> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Giteabot <teabot@gitea.io>	2023-10-01 09:04:39 -04:00
Lunny Xiao	6e87a44034	Allow get release download files and lfs files with oauth2 token format (#26430) ... Fix #26165 Fix #25257	2023-10-01 10:41:52 +00:00
yp05327	393193a3e0	Fix repo count in org action settings (#27245) ... Only in org action settings, repo count is missing Before:    In other setting page:  After:   	2023-09-29 15:46:07 +00:00
Panagiotis "Ivory" Vasilopoulos	65e09a303e	Introduce fixes and more rigorous tests for 'Show on a map' feature (#26803) ... This change introduces a fix for the PR #26214 to set the UserLocationMapURL correctly.	2023-09-29 14:57:06 +00:00
6543	2a2b0cb1d2	rename TotalTimes() to TotalTimesForEachUser() (#27261) ... make function name more descriptive as it would otherwise imply it could be used for e.g. #26672 too ... --- *Sponsored by Kithara Software GmbH*	2023-09-29 13:04:14 +00:00
JakobDev	cf0df023be	More `db.DefaultContext` refactor (#27265) ... Part of #27065 This PR touches functions used in templates. As templates are not static typed, errors are harder to find, but I hope I catch it all. I think some tests from other persons do not hurt.	2023-09-29 12:12:54 +00:00
yp05327	3945c26722	Improve tree not found page (#26570) ... Before:  After:  In Github: https://github.com/yp05327/test/blob/main/test.drawio Updated: UI changed   --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2023-09-29 07:42:39 +00:00
Dmitry Sharshakov	5e02e3b7ee	Add support for forking single branch (#25821) ... Fixes #25117 Add UI for choosing branch to fork Change default branch on single-branch forks  --------- Co-authored-by: Denys Konovalov <kontakt@denyskon.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-09-29 09:48:39 +08:00
Zettat123	3fcad582c9	Improvements of releases list and tags list (#25859) ... Follow #23465 and #25624 This PR introduces the following improvements: - We do not need to call `GetTags` to get tags because tags have been loaded by `RepoAssignment` ef90fdbd1d/modules/context/repo.go (L663-L668) - Similarly, the number of tags and releases also have been loaded by `RepoAssignment`, so the related code has been removed from the handlers. The query condition of `GetReleaseCountByRepoID` in `RepoAssignment` has been changed to include draft releases. ef90fdbd1d/modules/context/repo.go (L538-L551) - `releasesOrTags` function has been removed. The code for rendering releases list and tags list moved to `Releases` and `TagList` respectively.	2023-09-28 13:21:47 +00:00
wxiaoguang	72c68177ab	Improve issue history dialog and make poster can delete their own history (#27323) ... Fix #27313 (see the comment) And some UI improvements: ### Before   ### After   	2023-09-28 08:43:20 +00:00
Lunny Xiao	673cf6af76	make writing main test easier (#27270) ... This PR removed `unittest.MainTest` the second parameter `TestOptions.GiteaRoot`. Now it detects the root directory by current working directory. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-09-28 01:38:53 +00:00
Lunny Xiao	3b2da7e4ae	Redefine the meaning of column is_active to make Actions Registration Token generation easier (#27143) ... Partially Fix #25041 This PR redefined the meaning of column `is_active` in table `action_runner_token`. Before this PR, `is_active` means whether it has been used by any runner. If it's true, other runner cannot use it to register again. In this PR, `is_active` means whether it's validated to be used to register runner. And if it's true, then it can be used to register runners until it become false. When creating a new `is_active` register token, any previous tokens will be set `is_active` to false.	2023-09-27 05:37:48 +00:00
JakobDev	7047df36d4	Another round of `db.DefaultContext` refactor (#27103) ... Part of #27065 --------- Co-authored-by: KN4CK3R <admin@oldschoolhack.me>	2023-09-25 13:17:37 +00:00
silverwind	3a187eace5	Fix EOL handling in web editor (#27141) ... Fixes https://github.com/go-gitea/gitea/issues/27136. This does the following for Monaco's EOL setting: 1. Use editorconfig setting if present 2. Use the file's dominant line ending as detected by monaco, which uses LF for empty file	2023-09-24 19:51:02 +00:00
JakobDev	28f9b313ba	Updates to the API for archived repos (#27149)	2023-09-21 23:43:29 +00:00
hazy	74a5db03fd	Fix: treat tab "overview" as "repositories" in user profiles without readme (#27124) ... Beginning since 2af30f715e, Gitea has a 500 error when visiting a user profile with `?tab=overview` in the URL when the user doesn't have a `.profile/README.md`, because the backend code assumes that if the tab is overview a profile repository must exist, and checks that the repository is nil aren't done. In this PR I treat `?tab=overview` the same as if no tab is set in the URL, which corrects this behaviour- Now, when visiting `?tab=overview`, if `.profile/README.md` exists on that user's profile it'll show that as it should, otherwise it'll show the repositories tab. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-09-20 01:48:44 +00:00
Earl Warren	fc09c30081	fix pagination for followers and following (#27127) ... - Use the correct total amount for pagination. Thereby correctly show the pagination bare when there's more than one page of followers/followings. Refs: https://codeberg.org/forgejo/forgejo/pulls/1477 (cherry picked from commit c1a136318be3bf72511bed108f2d67f2cf34e1b8) Co-authored-by: Gusted <postmaster@gusted.xyz>	2023-09-19 15:24:54 +00:00
wxiaoguang	8531ca0837	Make SSPI auth mockable (#27036) ... Before, the SSPI auth is only complied for Windows, it's difficult to test and it breaks a lot. Now, make the SSPI auth mockable and testable.	2023-09-17 23:32:56 +00:00
Lunny Xiao	47b878858a	Search branches (#27055) ... Resolve #25233 <img width="1315" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/3ba59b58-471a-4e1b-985c-87edac2268c0"> <img width="1297" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/b6caa12f-323b-4f70-9c44-ef91cb71a26c">	2023-09-17 08:24:40 +00:00
KN4CK3R	ed64f1c2b8	Support `.git-blame-ignore-revs` file (#26395) ... Closes #26329 This PR adds the ability to ignore revisions specified in the `.git-blame-ignore-revs` file in the root of the repository.  The banner is displayed in this case. I intentionally did not add a UI way to bypass the ignore file (same behaviour as Github) but you can add `?bypass-blame-ignore=true` to the url manually. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-09-16 17:42:34 +00:00
KN4CK3R	c766140dad	Add `RemoteAddress` to mirrors (#26952) ... This PR adds a new field `RemoteAddress` to both mirror types which contains the sanitized remote address for easier (database) access to that information. Will be used in the audit PR if merged.	2023-09-16 16:03:02 +00:00
JakobDev	f91dbbba98	Next round of `db.DefaultContext` refactor (#27089) ... Part of #27065	2023-09-16 14:39:12 +00:00
JakobDev	efecbbaca1	Fix NPE when editing OAuth2 applications (#27078) ... Fixes #27072 It looks like there are some cases where `ContextUser` is not set here --------- Co-authored-by: techknowlogick <matti@mdranta.net>	2023-09-16 09:13:26 +00:00
JakobDev	c548dde205	More refactoring of `db.DefaultContext` (#27083) ... Next step of #27065	2023-09-15 06:13:19 +00:00
JakobDev	76659b1114	Reduce usage of `db.DefaultContext` (#27073) ... Part of #27065 This reduces the usage of `db.DefaultContext`. I think I've got enough files for the first PR. When this is merged, I will continue working on this. Considering how many files this PR affect, I hope it won't take to long to merge, so I don't end up in the merge conflict hell. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-09-14 17:09:32 +00:00
JakobDev	8d0343e028	Fix issue templates when blank isses are disabled (#27061) ... Fixes #27060 --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: delvh <dev.lh@web.de>	2023-09-14 14:20:16 +00:00
Lunny Xiao	198a9ca635	Display all user types and org types on admin management UI (#27050) ... Follow #24026 <img width="1049" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/d3fc5159-b5e7-411a-b6f8-4a111a027e6b"> --------- Co-authored-by: delvh <dev.lh@web.de>	2023-09-14 06:53:36 +00:00
puni9869	e0aacc7624	Show the repo count in code tab on both user profile and org page. (#27048) ... as title Screenshot before User Profile page <img width="1367" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/24e79689-ba2f-4c85-b591-fe5621746965"> after <img width="1346" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/754a7ee8-c2f0-424d-9ba8-be38a48140aa"> Org page <img width="1354" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/c96178d8-664f-45c5-a162-f4df5690d9d0"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-09-13 18:47:35 +08:00
Dmitry Sharshakov	63b53af933	Show OpenID Connect and OAuth on signup page (#20242) ... Fix #19809 --------- Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com> Co-authored-by: jackHay22 <jack@allspice.io>	2023-09-13 05:14:21 +00:00
Nanguan Lin	cda97a7253	Update status and code index after changing the default branch (#27018) ... Fix #26723 Add `ChangeDefaultBranch` to the `notifier` interface and implement it in `indexerNotifier`. So when changing the default branch, `indexerNotifier` sends a message to the `indexer queue` to update the index. --------- Co-authored-by: techknowlogick <matti@mdranta.net>	2023-09-13 04:43:31 +00:00
jladbrook	e33f112e01	resolve issue with sort icons on admin/users and admin/runners (#24360) ... Fixes #24327 to avoid the sort icon changing the table header over multiple lines and adds missing sort icons on the runners page.	2023-09-12 12:26:51 +00:00
KN4CK3R	591f586bf1	Extract auth middleware from service (#27028) ... Related #27027 Extract the router logic from `services/auth/middleware.go` into `routers/web` <-> `routers/common` <-> `routers/api`.	2023-09-12 08:15:16 +02:00
Lunny Xiao	ebff0513db	Fix context cache bug & enable context cache for dashabord commits' authors (#26991) ... Unfortunately, when a system setting hasn't been stored in the database, it cannot be cached. Meanwhile, this PR also uses context cache for push email avatar display which should avoid to read user table via email address again and again. According to my local test, this should reduce dashboard elapsed time from 150ms -> 80ms .	2023-09-11 10:14:01 +00:00
Lunny Xiao	e3ed67859a	Move some functions to service layer (#26969)	2023-09-08 21:09:23 +00:00
Lunny Xiao	4f32abaf94	move repository deletion to service layer (#26948) ... Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-09-08 04:51:15 +00:00
Lunny Xiao	f20e317d6d	Improve hint when uploading a too large avatar (#26935) ... Fix #26390 --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: silverwind <me@silverwind.io>	2023-09-07 13:35:45 +00:00
CaiCandong	a78c2eae24	Replace `util.SliceXxx` with `slices.Xxx` (#26958)	2023-09-07 09:37:47 +00:00
Nanguan Lin	1ee4882b88	Fix the missing repo count (#26942) ... The commit (958d148043) forgot two pages 😝  BTW, the `leave` button is in a weird position	2023-09-07 01:44:47 +00:00
Lunny Xiao	b9df9fa2e2	Move createrepository from module to service layer (#26927) ... Repository creation depends on many models, so moving it to service layer is better.	2023-09-06 12:08:51 +00:00
merlleu	a7d9a70552	allow "latest" to be used in release vTag when downloading file (#26748) ... Hello, In the discord I saw [someone](https://discord.com/channels/322538954119184384/1069795723178160168/1145061200644800514) complaining that you can't use the "latest" keyword as release tag to download a specific file: In his example: https://www.uberwald.me/gitea/public/fvtt-ecryme/releases/latest/system.json However the latest keyword works for the release page, so I think it's a good thing to implement this on the release attachment download url too. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-09-06 11:06:04 +00:00
JakobDev	958d148043	Show always repo count in header (#26842) ... A few pages don't load the repo count of an user/org, so it is not shown in the header. This happens mostly on org pages, but the package settings applies to the user page as well. Before:  After:  Seen on #26826 Regression of #25928	2023-09-06 08:49:36 +00:00
FuXiaoHei	460a2b0edf	Artifacts retention and auto clean up (#26131) ... Currently, Artifact does not have an expiration and automatic cleanup mechanism, and this feature needs to be added. It contains the following key points: - [x] add global artifact retention days option in config file. Default value is 90 days. - [x] add cron task to clean up expired artifacts. It should run once a day. - [x] support custom retention period from `retention-days: 5` in `upload-artifact@v3`. - [x] artifacts link in actions view should be non-clickable text when expired.	2023-09-06 07:41:06 +00:00
yp05327	0850be6750	Fix the display of org level badges (#26504) ... Follow #24654 #22705 #24232 In some pages we still have missing badges, for example:   	2023-09-06 14:38:14 +08:00
Lunny Xiao	540bf9fa6d	Move notification interface to services layer (#26915) ... Extract from #22266	2023-09-05 18:37:47 +00:00
techknowlogick	084eacb5d4	fetch emails of currently displayed user on admin page (#26918) ... Currently, this fetches the emails from the user viewing the page. This PR changes it to show the emails from the user whose page it is.	2023-09-05 17:56:21 +00:00
KN4CK3R	a99b96cbcd	Refactor secrets modification logic (#26873) ... - Share code between web and api - Add some tests	2023-09-05 15:21:02 +00:00
Jack Hay	9881b8a4e2	Add more descriptive error on forgot password page (#26848) ... ## Changes - Forces flashed error to render immediately when forgot password code is incorrect or has expired. - Adds a link back to the `forgot_password` page so that the user can restart the process (in the event that their link has expired)	2023-09-01 16:15:39 +00:00
wxiaoguang	e8aae43f56	Move web/api context related testing function into a separate package (#26859) ... Just like `models/unittest`, the testing helper functions should be in a separate package: `contexttest` And complete the TODO: > // TODO: move this function to other packages, because it depends on "models" package	2023-09-01 11:26:07 +00:00
Jack Hay	c0ab7070e5	Update team invitation email link (#26550) ... Co-authored-by: Kyle D <kdumontnu@gmail.com> Co-authored-by: Jonathan Tran <jonnytran@gmail.com>	2023-08-31 16:26:13 +00:00
JakobDev	3cae50e841	Redirect from `{repo}/issues/new` to `{repo}/issues/new/choose` when blank issues are disabled (#26813) ... You can currently visit `{repo}/issues/new` and create a blank issue, even if it's disabled. This PR fixes this, Fixes https://codeberg.org/forgejo/forgejo/issues/1356 Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-31 15:36:25 +00:00
Denys Konovalov	5b5bb8d354	User details page (#26713) ... This PR implements a proposal to clean up the admin users table by moving some information out to a separate user details page (which also displays some additional information). Other changes: - move edit user page from `/admin/users/{id}` to `/admin/users/{id}/edit` -> `/admin/users/{id}` now shows the user details page - show if user is instance administrator as a label instead of a separate column - separate explore users template into a page- and a shared one, to make it possible to use it on the user details page - fix issue where there was no margin between alert message and following content on admin pages <details> <summary>Screenshots</summary>   </details> Partially resolves #25939 --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-31 11:21:18 +02:00
KN4CK3R	5315153059	Use `Set[Type]` instead of `map[Type]bool/struct{}`. (#26804)	2023-08-30 06:55:25 +00:00
yp05327	915cabdb14	Fix context filter has no effect in dashboard (#26695) ... Fix #26686	2023-08-29 12:46:52 +00:00
CaiCandong	c576b50441	Fix being unable to use a repo that prohibits accepting PRs as a PR source. (#26785) ... ## Description Sometimes, we need to use an upstream mirror repository to update the current development repository, but mirror repositories are prohibited from PR. It should not appear in `merge to,` but it can appear in `pull from.` Fix #24585 #26193 #26781 Related #24183 Many thanks to @apnote for assisting me in reproducing this bug! ## ScreenShot --- ### Before <img src="https://github.com/go-gitea/gitea/assets/50507092/3d76c376-1f54-45b9-80c9-6ba8319d6a9a" width="400px"> <img src="https://github.com/go-gitea/gitea/assets/50507092/fbfd9f7f-421f-4a2e-9a3e-f2958bbf3312" width="400px"> ### After <img src="https://github.com/go-gitea/gitea/assets/50507092/e6984524-4f61-4310-b795-4d8598bd8963" width="400px"> <img src="https://github.com/go-gitea/gitea/assets/50507092/04065b44-78d7-4721-bf31-0f1674150727" width="400px">	2023-08-29 12:07:15 +03:00
Lunny Xiao	476b9d1589	Use docs.gitea.com instead of docs.gitea.io (#26739)	2023-08-27 11:59:12 +00:00
Chongyi Zheng	43652746f2	Move `modules/mirror` to `services` (#26737) ... To solve the cyclic imports in a better way Closes #20261	2023-08-27 10:24:45 +08:00
wxiaoguang	412e5c0946	Make web context initialize correctly for different cases (#26726) ... The web context (modules/context.Context) is quite complex, it's difficult for the callers to initialize correctly. This PR introduces a `NewWebContext` function, to make sure the web context have the same behavior for different cases.	2023-08-25 19:07:42 +08:00
yp05327	d2e4039def	Add `member`, `collaborator`, `contributor`, and `first-time contributor` roles and tooltips (#26658) ... GitHub like role descriptor    --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2023-08-24 13:06:17 +08:00
yp05327	7e30986667	Remove ref name in PR commits page (#25876) ... The branch name display here is based on the repo's default branch which is not correct.  For example, if I changed the default branch, the branch name here will also be changed:   you can confirm this in : https://try.gitea.io/yp05327/testrepo/pulls/1/commits I think we do not need to display branch name here, as we already have the branch info above. 	2023-08-24 01:31:54 +00:00
wxiaoguang	e8b990999f	Make "link-action" backend code respond correct JSON content (#26680) ... Otherwise the `link-action` JS code couldn't parse the response. Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-23 17:36:57 +08:00
Jason Song	5db21ce7e1	Fix counting and filtering on the dashboard page for issues (#26657) ... This PR has multiple parts, and I didn't split them because it's not easy to test them separately since they are all about the dashboard page for issues. 1. Support counting issues via indexer to fix #26361 2. Fix repo selection so it also fixes #26653 3. Keep keywords in filter links. The first two are regressions of #26012. After: https://github.com/go-gitea/gitea/assets/9418365/71dfea7e-d9e2-42b6-851a-cc081435c946 Thanks to @CaiCandong for helping with some tests.	2023-08-23 02:29:17 +00:00
yp05327	a4a567f29f	Check disabled workflow when rerun jobs (#26535) ... In GitHub, we can not rerun jobs if the workflow is disabled. --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-08-22 10:30:02 +08:00
yp05327	f6e7798405	Add link to job details and tooltip to commit status in repo list in dashboard (#26326) ... Tooltip:  Link to the target job: 	2023-08-21 15:26:10 +08:00
a1012112796	f00fdd1abd	fix reopen logic for agit flow pull request (#26399) ... the head branch is meaningless for a agit flow pull request, so should not check it when reopen it. related: #24231 fix #26334 Signed-off-by: a1012112796 <1012112796@qq.com>	2023-08-19 11:29:34 +02:00
Jason Song	b658f2c61b	Return empty when searching issues with no repos (#26545)	2023-08-17 12:42:17 -05:00
CaiCandong	940f997512	Fix label filter between `all` and `no` (#26557) ... Regression of https://github.com/go-gitea/gitea/pull/25886. # Description For `labelIDs`: 9afcb0e046/routers/web/repo/issue.go (L171-L174) - `nil` mean no filter - `[0]` mean `no label` filter When `selectLabels == "0"`, labelIDs should be `[0]` rather than `nil` # Before: https://github.com/go-gitea/gitea/assets/50507092/3dac5075-6da0-4769-ba20-48a56f4063c0 # After: https://github.com/go-gitea/gitea/assets/50507092/ff79fd4c-b02e-4dfb-9309-ae7851f4dcdb Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-17 13:19:24 +00:00
Jason Song	c179ab4236	Fix "issueReposQueryPattern does not match query" (#26556) ... Fix `https://github.com/go-gitea/gitea/pull/26545#discussion_r1295734340` --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-17 12:38:02 +00:00
wxiaoguang	c6b92c84fe	Sync repo's IsEmpty status correctly (#26517) ... Close #26509	2023-08-17 04:43:39 +00:00
yp05327	bc930f332f	Fix typo of RunerOwnerID (#26508)	2023-08-15 23:10:40 +00:00
yp05327	7f8028e5a1	Fix display problems of members and teams unit (#26363) ... Fix: - display member count and team count in the menu bar  - Also display member unit in the menu bar if there are no hidden members in public org  - hidden member board when there's no seeable members. In this org, we only have hidden members:  We will hidden the member board when doer is not the member of this org  Before:  If you click the number in the members board, you will access the members page, which is not expected.  --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-15 16:00:35 +02:00
a1012112796	19872063a3	add disable workflow feature (#26413) ... As title, that's simmilar with github.   --------- Signed-off-by: a1012112796 <1012112796@qq.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Jason Song <i@wolfogre.com>	2023-08-14 15:14:30 +00:00
puni9869	cafce3b4b5	Allow to archive labels (#26478) ... ## Archived labels This adds the structure to allow for archived labels. Archived labels are, just like closed milestones or projects, a medium to hide information without deleting it. It is especially useful if there are outdated labels that should no longer be used without deleting the label entirely. ## Changes 1. UI and API have been equipped with the support to mark a label as archived 2. The time when a label has been archived will be stored in the DB ## Outsourced for the future There's no special handling for archived labels at the moment. This will be done in the future. ## Screenshots   Part of https://github.com/go-gitea/gitea/issues/25237 --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-08-14 11:56:14 +02:00
silverwind	56b6b2b88e	Fix tooltip of commit select button (#26472) ... Previously, the tooltip for this button was only shown after opening and closing it once because it was only set after the server response, now it shows before opening it.	2023-08-14 02:16:40 +00:00
Earl Warren	50fc22eecf	Add ThreadID parameter for Telegram webhooks (#25996) ... Telegram has recently implemented threads (channels) for group chats. Co-authored-by: neveraskedtoexist <matikot415@gmail.com>	2023-08-13 14:00:06 +00:00
Denys Konovalov	ab78c39e41	Refactor project templates (#26448) ... This PR refactors a bunch of projects-related code, mostly the templates. The following things were done: - rename boards to columns in frontend code - use the new `ctx.Locale.Tr` method - cleanup template, remove useless newlines, classes, comments - merge org-/user and repo level project template together - move "new column" button into project toolbar - move issue card (shared by projects and pinned issues) to shared template, remove useless duplicated styles - add search function to projects (to make the layout more similar to milestones list where it is inherited from 😆) - maybe more changes I forgot I've done 😆 Closes #24893 After:    --------- Co-authored-by: silverwind <me@silverwind.io>	2023-08-12 10:30:28 +00:00
yp05327	9fc68b680f	Fix 404 error when remove self from an organization (#26362) ... Same to #24322 Not only `leave` action but also `remove` action should check whether user still belongs to the org.	2023-08-12 07:02:22 +00:00
Denys Konovalov	46660f1614	remove unnecessary explore org template (#26459)	2023-08-11 16:07:04 -04:00
JakobDev	f3fbb7c67d	Count only visible repos on profile (#25928) ... Fixes #25914	2023-08-11 13:08:05 -04:00
Lunny Xiao	e7cbb0e7c9	Fix wrong middleware sequence (#26428)	2023-08-10 12:51:46 +02:00
wxiaoguang	a370efc13f	Use template context function for avatar rendering (#26385) ... Introduce `AvatarUtils`, no need to pass `$.Context` to every sub-template, and simplify the template helper functions.	2023-08-10 11:19:39 +08:00
Lunny Xiao	36eb3c433a	Add transaction when creating pull request created dirty data (#26259) ... Fix #26129 Replace #26258 This PR will introduce a transaction on creating pull request so that if some step failed, it will rollback totally. And there will be no dirty pull request exist. --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-10 02:39:21 +00:00
wxiaoguang	a85a862804	Fix admin queue page title (#26409) ... Fix #26408 ``` # locale_en-US.ini [admin] monitor.queues = Queues ``` --------- Co-authored-by: silverwind <me@silverwind.io>	2023-08-10 02:05:37 +00:00
Denys Konovalov	63ab92d797	Pre-register OAuth2 applications for git credential helpers (#26291) ... This PR is an extended implementation of #25189 and builds upon the proposal by @hickford in #25653, utilizing some ideas proposed internally by @wxiaoguang. Mainly, this PR consists of a mechanism to pre-register OAuth2 applications on startup, which can be enabled or disabled by modifying the `[oauth2].DEFAULT_APPLICATIONS` parameter in app.ini. The OAuth2 applications registered this way are being marked as "locked" and neither be deleted nor edited over UI to prevent confusing/unexpected behavior. Instead, they're being removed if no longer enabled in config.  The implemented mechanism can also be used to pre-register other OAuth2 applications in the future, if wanted. Co-authored-by: hickford <mirth.hickford@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> --------- Co-authored-by: M Hickford <mirth.hickford@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-08-09 14:24:07 +02:00
wxiaoguang	c2e0143bfe	Introduce ctx.PathParamRaw to avoid incorrect unescaping (#26392) ... Fix #26389 And complete an old TODO: `ctx.Params does un-escaping,..., which is incorrect.`	2023-08-09 14:57:45 +08:00
wxiaoguang	4fc4f6e634	Refactor "editorconfig" (#26391) ... There are 2 kinds of ".Editorconfig" in code, one is `JSON string` for the web edtior, another is `*editorconfig.Editorconfig` for the file rendering (used by `TabSizeClass`) This PR distinguish them with different names. And by the way, change the default tab size from 8 to 4, I think few people would like to use 8-size tabs nowadays.	2023-08-08 10:44:19 +00:00
wxiaoguang	71d253f42e	Remove unnecessary template helper DisableGravatar (#26386) ... And one "AllowedUserVisibilityModes" was missing, add it. Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-08 08:29:14 +00:00
wxiaoguang	6913053223	Start using template context function (#26254) ... Before: * `{{.locale.Tr ...}}` * `{{$.locale.Tr ...}}` * `{{$.root.locale.Tr ...}}` * `{{template "sub" .}}` * `{{template "sub" (dict "locale" $.locale)}}` * `{{template "sub" (dict "root" $)}}` * ..... With context function: only need to `{{ctx.Locale.Tr ...}}` The "ctx" could be considered as a super-global variable for all templates including sub-templates. To avoid potential risks (any bug in the template context function package), this PR only starts using "ctx" in "head.tmpl" and "footer.tmpl" and it has a "DataRaceCheck". If there is anything wrong, the code can be fixed or reverted easily.	2023-08-08 01:22:47 +00:00
KN4CK3R	0c6ae61229	Allow package cleanup from admin page (#25307) ... Until now expired package data gets deleted daily by a cronjob. The admin page shows the size of all packages and the size of unreferenced data. The users (#25035, #20631) expect the deletion of this data if they run the cronjob from the admin page but the job only deletes data older than 24h. This PR adds a new button which deletes all expired data.  --------- Co-authored-by: silverwind <me@silverwind.io>	2023-08-08 00:46:10 +00:00
Lunny Xiao	f5dbac9d36	Use more `IssueList` instead of `[]*Issue` (#26369)	2023-08-07 19:26:40 +00:00
CaiCandong	24fbf4e059	Fix nil pointer dereference error when open link with invalid pull index (#26353) ... fix #26331 Before:  After: 	2023-08-07 11:43:18 +08:00
yp05327	945a0cb96b	Add highlight to selected repos in milestone dashboard (#26300) ... Before:  After:  Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-04 15:16:56 +00:00
Nicholas Pease	6a7a5ea32a	Do not show Profile README when repository is private (#26295) ... As mentioned in the original thread (#23260) and in the enhancements PR #24753, this PR ensures the .profile repository is public before the README file is shown. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-04 14:45:33 +00:00
Kerwin Bryant	865d2221c0	Add `Retry` button when creating a mirror-repo fails (#26228) ... fixed #26156 * Added a retry button in the frontend (only displayed when the status is abnormal) * After clicking Retry, the backend adds the task back to the task queue   --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-08-04 10:21:32 +08:00
yp05327	6832a8eb06	Add locale for deleted head branch (#26296) ... As title. It will be displayed in: 	2023-08-03 22:07:15 +00:00
puni9869	ab388deb0e	Allow editing push mirrors after creation (#26151) ... Allow users to edit the sync interval for existing push mirrors. Currently, there is no way to modify the interval once the mirror is created. <details> <summary>Screenshots</summary> ## Before <img width="936" alt="Screenshot 2023-07-26 at 9 31 21 AM" src="https://github.com/go-gitea/gitea/assets/80308335/35b8a40c-4320-474c-a866-1dea0f1fa0de"> ## After <img width="945" alt="Screenshot 2023-07-26 at 9 44 40 AM" src="https://github.com/go-gitea/gitea/assets/80308335/ee12e12f-0f68-4feb-90eb-33366f5997d3"> ### On hover <img width="247" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/2f32de45-bd50-4150-9623-3be2ef3ea7f8"> <img width="237" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/49f4ab4d-ccff-4489-80ce-a9788a73c3bb"> <img width="245" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/165fc888-9d48-438a-b730-d4beb12122af"> ### Edit modal <img width="905" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/2a7ca24b-4f36-4e0e-9799-39f2ecc46413"> ### Only valid times are allowed <img width="728" alt="Screenshot 2023-07-26 at 9 50 01 AM" src="https://github.com/go-gitea/gitea/assets/80308335/ced6d330-c235-4e29-8f17-28daddcf1444"> <img width="853" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/8636f62a-70d1-4684-a3e8-b205adc03580"> </details> Fixes #21295 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-08-01 16:00:59 +00:00
Zettat123	9a65d011f6	Some fixes of the prompt of new branches (#26257) ... Related to #26239 This PR makes some fixes: - do not show the prompt for mirror repos and repos with pull request units disabled - use `commit_time` instead of `updated_unix`, as `commit_time` is the real time when the branch was pushed	2023-08-01 07:25:11 +00:00
Panagiotis "Ivory" Vasilopoulos	d58c542579	Add 'Show on a map' button to Location in profile, fix layout (#26214) ... Not too important, but I think that it'd be a pretty neat touch. Also fixes some layout bugs introduced by a previous PR. --------- Co-authored-by: Gusted <postmaster@gusted.xyz> Co-authored-by: Caesar Schinas <caesar@caesarschinas.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-07-31 08:44:45 +00:00
Jason Song	1e76a824bc	Refactor and enhance issue indexer to support both searching, filtering and paging (#26012) ... Fix #24662. Replace #24822 and #25708 (although it has been merged) ## Background In the past, Gitea supported issue searching with a keyword and conditions in a less efficient way. It worked by searching for issues with the keyword and obtaining limited IDs (as it is heavy to get all) on the indexer (bleve/elasticsearch/meilisearch), and then querying with conditions on the database to find a subset of the found IDs. This is why the results could be incomplete. To solve this issue, we need to store all fields that could be used as conditions in the indexer and support both keyword and additional conditions when searching with the indexer. ## Major changes - Redefine `IndexerData` to include all fields that could be used as filter conditions. - Refactor `Search(ctx context.Context, kw string, repoIDs []int64, limit, start int, state string)` to `Search(ctx context.Context, options *SearchOptions)`, so it supports more conditions now. - Change the data type stored in `issueIndexerQueue`. Use `IndexerMetadata` instead of `IndexerData` in case the data has been updated while it is in the queue. This also reduces the storage size of the queue. - Enhance searching with Bleve/Elasticsearch/Meilisearch, make them fully support `SearchOptions`. Also, update the data versions. - Keep most logic of database indexer, but remove `issues.SearchIssueIDsByKeyword` in `models` to avoid confusion where is the entry point to search issues. - Start a Meilisearch instance to test it in unit tests. - Add unit tests with almost full coverage to test Bleve/Elasticsearch/Meilisearch indexer. --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2023-07-31 06:28:53 +00:00
JakobDev	aba9096999	Show image size on view page (#25884) ... This simply shows the Image size on the view page. This is useful, if you search a image with a specific size. 	2023-07-31 05:04:45 +00:00
caicandong	983167cf49	Fix pull request check list is limited (#26179) ... In the original implementation, we can only get the first 30 records of the commit status (the default paging size), if the commit status is more than 30, it will lead to the bug #25990. I made the following two changes. - On the page, use the ` db.ListOptions{ListAll: true}` parameter instead of `db.ListOptions{}` - The `GetLatestCommitStatus` function makes a determination as to whether or not a pager is being used. fixed #25990	2023-07-31 02:21:09 +00:00
caicandong	fd836ff68b	Fix unable to display individual-level project (#26198) ... As title Before:  After:  fix #26189	2023-07-29 15:35:53 +00:00
Zettat123	b33cf4fabc	Fix access check for org-level project (#26182) ... Fix #25934 Add `ignoreGlobal` parameter to `reqUnitAccess` and only check global disabled units when `ignoreGlobal` is true. So the org-level projects and user-level projects won't be affected by global disabled `repo.projects` unit.	2023-07-29 14:13:24 +00:00
sebastian-sauer	55532061c8	Add commits dropdown in PR files view and allow commit by commit review (#25528) ... This PR adds a new dropdown to select a commit or a commit range (shift-click like github) of a Pull Request. After selection of a commit only the changes of this commit will be shown. When selecting a range of commits the diff of this range is shown. This allows to review a PR commit by commit or by viewing only commit ranges. The "Show changes since your last review" mechanism github uses is implemented, too. When reviewing a single commit or a commit range the "Viewed" functionality is disabled. ## Screenshots ### The commit dropdown  ### Selecting a commit range  ### Show changes of a single commit only  ### Show changes of a commit range  Fixes https://github.com/go-gitea/gitea/issues/20989 Fixes https://github.com/go-gitea/gitea/issues/19263 --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: delvh <dev.lh@web.de>	2023-07-28 21:18:12 +02:00
delvh	bd6ef71854	Show branches and tags that contain a commit (#25180) ... Now, you can see for a commit which existing branches and tags contain it. You first have to click on the `load branches and tags` button, they are not preloaded by default. All branches and tags are ordered descending by creation date. You can even see without much hassle if the given commit is already part of the default branch. Closes #25152 ## Screenshots ### Initial  ### Loaded  --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-07-27 12:47:41 +02:00
cassiozareck	73fb1ecdcf	Fixing redirection issue for logged-in users (#26105) ... This PR addresses an issue where logged-in users get redirected to the homepage when trying to access a URL with the redirect_to parameter. The issue was traced back to a middleware function in services/auth/middleware.go that redirects logged-in users to the homepage. This function didn't account the redirect_to parameter. The fix modifies the middleware function to check for this case and redirect the user to the specified URL instead of the homepage. Closes: #26005 --------- Signed-off-by: cassiozareck <cassiomilczareck@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-07-27 13:08:51 +08:00
yp05327	1c6c38fa6e	Improve display of Labels/Projects/Assignees sort options (#25886) ... Labels: Before: (no highlights)  After:   Projects: Before: (no highlights)  After:   Assignee: Before: (no highlights)  After:  	2023-07-26 13:00:50 +00:00
wxiaoguang	dcd3a63128	Move web JSON functions to web context and simplify code (#26132) ... The JSONRedirect/JSONOK/JSONError functions were put into "Base" context incorrectly, it would cause abuse. Actually, they are for "web context" only, so, move them to the correct place. And by the way, use them to simplify old code: +75 -196	2023-07-26 06:04:01 +00:00
Lunny Xiao	5dc37ef97a	Display deprecated warning in admin panel pages as well as in the log file (#26094) ... This PR includes #26007 's changes but have a UI to prompt administrator about the deprecated settings as well as the log or console warning. Then users will have enough time to notice the problem and don't have surprise like before. <img width="1293" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/c33355f0-1ea7-4fb3-ad43-cd23cd15391d"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-07-26 03:53:37 +00:00
JakobDev	6598d0291c	Allow Organisations to have a E-Mail (#25082) ... Resolves #25057 This adds a E-Mail field to Organisations. The E-Mail is just shown on the Profile when it is visited by a logged in User. The E-mail is not used for something else. **Screenshots:**   --------- Co-authored-by: Denys Konovalov <kontakt@denyskon.de> Co-authored-by: Denys Konovalov <privat@denyskon.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-25 08:26:27 +00:00
Bo-Yi Wu	44781f9f5c	Implement auto-cancellation of concurrent jobs if the event is push (#25716) ... - cancel running jobs if the event is push - Add a new function `CancelRunningJobs` to cancel all running jobs of a run - Update `FindRunOptions` struct to include `Ref` field and update its condition in `toConds` function - Implement auto cancellation of running jobs in the same workflow in `notify` function related task: https://github.com/go-gitea/gitea/pull/22751/ --------- Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com> Signed-off-by: appleboy <appleboy.tw@gmail.com> Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: delvh <dev.lh@web.de>	2023-07-25 11:15:55 +08:00
delvh	f3d41c61eb	Remove `db.DefaultContext` in `routers/` and `cmd/` (#26076) ... Now, the only remaining usages of `models.db.DefaultContext` are in - `modules` - `models` - `services`	2023-07-23 23:47:27 -04:00
Lunny Xiao	b167f35113	Add context parameter to some database functions (#26055) ... To avoid deadlock problem, almost database related functions should be have ctx as the first parameter. This PR do a refactor for some of these functions.	2023-07-22 22:14:27 +08:00
Lunny Xiao	c42b71877e	Fix branch list auth (#26041) ... The public repositories' branch list dropdown will return wrong because it requires login wrongly. Caused by #25719	2023-07-22 11:47:06 +00:00
wxiaoguang	52fb936773	Serve pre-defined files in "public", add "security.txt", add CORS header for ".well-known" (#25974) ... Replace #25892 Close #21942 Close #25464 Major changes: 1. Serve "robots.txt" and ".well-known/security.txt" in the "public" custom path * All files in "public/.well-known" can be served, just like "public/assets" 3. Add a test for ".well-known/security.txt" 4. Simplify the "FileHandlerFunc" logic, now the paths are consistent so the code can be simpler 5. Add CORS header for ".well-known" endpoints 6. Add logs to tell users they should move some of their legacy custom public files ``` 2023/07/19 13:00:37 cmd/web.go:178:serveInstalled() [E] Found legacy public asset "img" in CustomPath. Please move it to /work/gitea/custom/public/assets/img 2023/07/19 13:00:37 cmd/web.go:182:serveInstalled() [E] Found legacy public asset "robots.txt" in CustomPath. Please move it to /work/gitea/custom/public/robots.txt ``` This PR is not breaking. --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-21 12:14:20 +00:00
HesterG	2f0e79e639	Use frontend fetch for branch dropdown component (#25719) ... - Send request to get branch/tag list, use loading icon when waiting for response. - Only fetch when the first time branch/tag list shows. - For backend, removed assignment to `ctx.Data["Branches"]` and `ctx.Data["Tags"]` from `context/repo.go` and passed these data wherever needed. - Changed some `v-if` to `v-show` and used native `svg` as mentioned in https://github.com/go-gitea/gitea/pull/25719#issuecomment-1631712757 to improve perfomance when there are a lot of branches. - Places Used the dropdown component: Repo Home Page <img width="1429" alt="Screen Shot 2023-07-06 at 12 17 51" src="https://github.com/go-gitea/gitea/assets/17645053/6accc7b6-8d37-4e88-ae1a-bd2b3b927ea0"> Commits Page <img width="1431" alt="Screen Shot 2023-07-06 at 12 18 34" src="https://github.com/go-gitea/gitea/assets/17645053/2d0bf306-d1e2-45a8-a784-bc424879f537"> Specific commit -> operations -> cherry-pick <img width="758" alt="Screen Shot 2023-07-06 at 12 23 28" src="https://github.com/go-gitea/gitea/assets/17645053/1e557948-3881-4e45-a625-8ef36d45ae2d"> Release Page <img width="1433" alt="Screen Shot 2023-07-06 at 12 25 05" src="https://github.com/go-gitea/gitea/assets/17645053/3ec82af1-15a4-4162-a50b-04a9502161bb"> - Demo https://github.com/go-gitea/gitea/assets/17645053/d45d266b-3eb0-465a-82f9-57f78dc5f9f3 - Note: UI of dropdown menu could be improved in another PR as it should apply to more dropdown menus. Fix #14180 --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-07-21 11:20:04 +00:00
Lunny Xiao	037c9895a7	Support copy protected branch from template repository (#25889) ... Fix #14303	2023-07-21 12:32:47 +08:00
FuXiaoHei	f3d293d2bb	Actions Artifacts support uploading multiple files and directories (#24874) ... current actions artifacts implementation only support single file artifact. To support multiple files uploading, it needs: - save each file to each db record with same run-id, same artifact-name and proper artifact-path - need change artifact uploading url without artifact-id, multiple files creates multiple artifact-ids - support `path` in download-artifact action. artifact should download to `{path}/{artifact-path}`. - in repo action view, it provides zip download link in artifacts list in summary page, no matter this artifact contains single or multiple files.	2023-07-21 10:42:01 +08:00
wxiaoguang	9b25bfa8f4	Remove redundant "RouteMethods" method (#26024) ... The `RouteMethods` is mainly an alias for `Methods` with different argument order. Remove it to keep the "route.go" code clear	2023-07-21 00:43:49 +02:00
wxiaoguang	af22f33a93	Fix the route for pull-request's authors (#26016) ... Close #25906  Succeeded logs: ``` [I] router: completed GET /root/test/issues/posters?&q=%20&_=1689853025011 for [::1]:59271, 200 OK in 127.7ms @ repo/issue.go:3505(repo.IssuePosters) [I] router: completed GET /root/test/pulls/posters?&q=%20&_=1689853968204 for [::1]:59269, 200 OK in 94.3ms @ repo/issue.go:3509(repo.PullPosters) ```	2023-07-20 12:41:28 +00:00
Noah Snelson	df55f9b189	Add a link to OpenID Issuer URL in WebFinger response (#26000) ... This change adds an entry to the `links` field of the `/.well-known/webfinger` response. The new entry points to the `appURL` as an OpenID issuer. This is consistent with the output of `/.well-known/openid-configuration`, which also uses the value of `appURL`. This change is required for Tailscale SSO to work, as it uses the OpenID Issuer URL when querying the Tailscale user email during signup/login ([docs](https://tailscale.com/kb/1240/sso-custom-oidc/#webfinger-setup)).	2023-07-20 16:02:45 +08:00
Earl Warren	e20f8f0977	Improve profile readme rendering (#25988) ... - Tell the renderer to use the `document` mode, so it's consistent with other renderers. - Use the same padding as `.file-view.markup`, so it's consistent with other containers that contain markup rendering. - Resolves https://codeberg.org/forgejo/forgejo/issues/833 Co-authored-by: Gusted <postmaster@gusted.xyz>	2023-07-19 22:22:32 +00:00
harryzcy	0f9f6567bb	Bump github.com/golang-jwt/jwt to v5 (#25975) ... Bumping `github.com/golang-jwt/jwt` from v4 to v5. `github.com/golang-jwt/jwt` v5 is bringing some breaking changes: - standard `Valid()` method on claims is removed. It's replaced by `ClaimsValidator` interface implementing `Validator()` method instead, which is called after standard validation. Gitea doesn't seem to be using this logic. - `jwt.Token` has a field `Valid`, so it's checked in `ParseToken` function in `services/auth/source/oauth2/token.go` --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-19 09:57:10 +00:00
wxiaoguang	50e14699d3	Update path related documents (#25417) ... Update WorkPath/WORK_PATH related documents, remove out-dated information. Remove "StaticRootPath" on the admin config display page, because few end user really need it, it only causes misconfiguration.  Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-19 11:22:57 +02:00
wxiaoguang	236c645bf1	Refactor "Content" for file uploading (#25851) ... Before: the concept "Content string" is used everywhere. It has some problems: 1. Sometimes it means "base64 encoded content", sometimes it means "raw binary content" 2. It doesn't work with large files, eg: uploading a 1G LFS file would make Gitea process OOM This PR does the refactoring: use "ContentReader" / "ContentBase64" instead of "Content" This PR is not breaking because the key in API JSON is still "content": `` ContentBase64 string `json:"content"` ``	2023-07-18 18:14:47 +00:00
Jason Song	29e959fd00	Ignore `runs-on` with expressions when warning no matched runners (#25917) ... Fix #25905 Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-17 18:19:53 +02:00
yp05327	3add4ca216	Fix incorrect milestone count when provide a keyword (#25880) ... You can confirm this issue in: https://try.gitea.io/yp05327/testrepo/milestones?state=open&q=a There's no milestone, but the count is 1. 	2023-07-16 03:43:51 +00:00
yp05327	ec35af470c	Avoid opening/closing PRs which are already merged (#25883) ... We can select PRs to open/close them by one click, but we forgot to check whether it is merged. You can get an opening merged PR:  You can confirm this in: https://try.gitea.io/yp05327/testrepo/pulls/5	2023-07-15 22:10:49 +00:00
wxiaoguang	9672085d94	Fix "Flash" message usage (#25895) ... Resolve https://github.com/go-gitea/gitea/pull/25820/files#r1264309059	2023-07-15 11:52:03 +03:00
yp05327	dc679fc9fa	Fix incorrect release count (#25879) ... Release count is not correct: https://try.gitea.io/yp05327/testrepo/tags  https://try.gitea.io/yp05327/testrepo/releases  https://try.gitea.io/yp05327/testrepo/releases/tag/testtag  We already have correct release count, no need to calculate it again. c5e187c389/modules/context/repo.go (L547) Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-14 08:47:17 +00:00
yp05327	52f46919dc	Add error info if no user can fork the repo (#25820) ... Before: (Owner list is empty)  After: (Disable the button and show the error info) 	2023-07-14 15:56:20 +08:00
hiifong	4628aa5251	fix incorrect repo url when changed the case of ownername (#25733) ... When only the case of the username changes and the new username is consistent with the lowercase username of the old user name, update the owner name of the repo, and keep the original logic consistent with other conditions. example: your username is `gitea`, lowercase username is `gitea`,repo url is `.../gitea/{repo}`, you changed username to `Gitea` or `GiTea` or other, but the lowercase username is still `gitea`, the repo url is still `.../gitea/{repo}`. this pr fixed it,keep username and repo url consistent. Before:   After:  	2023-07-14 13:42:10 +08:00
Denys Konovalov	eec45b43db	move issue filters to shared template (#25729) ... Issue filters are being used on repo list page and on milestone issues page, and the code is mostly duplicated. This PR does the following changes: - move issue filters into a shared template - allow filtering milestone issues by project, so no need to hide this filter on milestone issues page - remove some dead code (e. g. issue actions in milestone issues template) - fix label filter dropdown width --------- Co-authored-by: 6543 <6543@obermui.de>	2023-07-13 20:00:38 +00:00
yp05327	8b89563bf1	Fix empty project displayed in issue sidebar (#25802) ... Before:  After:  This issue comes from the change in #25468. `LoadProject` will always return at least one record, so we use `ProjectID` to check whether an issue is linked to a project in the old code. As other `issue.LoadXXX` functions, we need to check the return value from `xorm.Session.Get`. In recent unit tests, we only test `issueList.LoadAttributes()` but don't test `issue.LoadAttributes()`. So I added a new test for `issue.LoadAttributes()` in this PR. --------- Co-authored-by: Denys Konovalov <privat@denyskon.de>	2023-07-12 16:10:35 +02:00
yp05327	44572e9243	Fix incorrect oldest sort in project list (#25806) ... sort type `oldest` should be `Asc`. Added a test for this.	2023-07-11 20:47:50 +02:00
Lunny Xiao	2f31d2d56c	Exclude default branch from pushed branch hint (#25795) ... When pushing to default branch, no pushing hint should be prompt. Fix #25778 --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-10 11:18:55 +00:00
Lunny Xiao	0fd1672ae4	For API attachments, use API URL (#25639) ... Fix #25257 --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-10 09:31:19 +00:00
sebastian-sauer	d2c3a90ee2	Show edit title button on commits tab of PR, too (#25791) ... All 3 tabs of the PR (Conversation, Commits and Files changed) should show the edit title button. Before this commit the edit button was not shown on commits tab Screenshots: After:  Before:  Just for reference the edit button in files changed tab:  Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-10 09:05:59 +02:00
wxiaoguang	84c78650cc	Fix notification list bugs (#25781) ... Fix #25627 1. `ctx.Data["Link"]` should use relative URL but not AppURL 2. The `data-params` is incorrect because it doesn't contain "page". JS can simply use "window.location.search" to construct the AJAX URL 3. The `data-xxx` and `id` in notification_subscriptions.tmpl were copied&pasted, they don't have affect.	2023-07-09 18:42:31 +00:00
Lunny Xiao	6375419468	Newly pushed branches hints on repository home page (#25715) ... This PR will display a pull request creation hint on the repository home page when there are newly created branches with no pull request. Only the recent 6 hours and 2 updated branches will be displayed. Inspired by #14003 Replace #14003 Resolves #311 Resolves #13196 Resolves #23743 co-authored by @kolaente	2023-07-08 05:19:00 +02:00
techknowlogick	cb01b8691d	Add open/closed field support for issue index (#25708) ... A couple of notes: * Future changes should refactor arguments into a struct * This filtering only is supported by meilisearch right now * Issue index number is bumped which will cause a re-index	2023-07-07 17:10:13 +00:00
wxiaoguang	128d77a3a0	Following up fixes for "Fix inconsistent user profile layout across tabs" (#25739) ... Follow https://github.com/go-gitea/gitea/pull/25625#issuecomment-1621577816 1. Fix the incorrect "project view" layout 2. Fix the "follow/unfollow" link on "packages" and "projects" tab Before:  After:  --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-07 17:27:12 +02:00
6543	8995046110	Less naked returns (#25713) ... just a step towards #25655 and some related refactoring	2023-07-07 05:31:56 +00:00
puni9869	2af30f715e	Fix inconsistent user profile layout across tabs (#25625) ... Fix ::User Profile Page Project Tab Have Inconsistent Layout and Style Added the big_avator for consistency in the all header_items tabs. Fixes: #24871 > ### Description > in the user profile page the `Packages` and `Projects` tab have small icons for user but other tabs have bigger profile picture with user info: > > ### Screenshots > ### **For Packages And Projects:** >  > > ### **For Other Tabs:** >  > ## Before  ## After changes Project View <img width="1394" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/95d181d7-8e61-496d-9899-7b825c91ad56"> Packages View <img width="1378" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/7f5fd60f-6b18-4fa8-8c56-7b0d45d1a610"> ## Org view for projects page <img width="1385" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/6400dc89-a5ae-4f0a-831b-5b6efa020d89"> ## Org view for packages page <img width="1387" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/4e1e9ffe-1e4b-4334-8657-de11b5fd31d0"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: silverwind <me@silverwind.io>	2023-07-06 18:59:24 +00:00
Jason Song	3c05aa4927	Check `ctx.Written()` for `GetActionIssue` (#25698) ... Fix #25697. Just avoid panic, maybe there's another bug to trigger this case. --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-05 18:52:12 +00:00
Lunny Xiao	90b3b3dbf8	Fix tags header and pretty format numbers (#25624) ... This caused by #23465	2023-07-05 04:11:42 +00:00
silverwind	88f835192d	Replace `interface{}` with `any` (#25686) ... Result of running `perl -p -i -e 's#interface\{\}#any#g' **/*` and `make fmt`. Basically the same [as golang did](2580d0e08d).	2023-07-04 18:36:08 +00:00
Zettat123	ff140d4050	Fix the nil pointer when assigning issues to projects (#25665) ... Fixes #25649 Caused by #25468	2023-07-04 10:26:24 +00:00
Lunny Xiao	0403bd989f	Log the real reason when authentication fails (but don't show the user) (#25414)	2023-07-03 18:39:38 -04:00
KN4CK3R	c890454769	Add direct serving of package content (#25543) ... Fixes #24723 Direct serving of content aka HTTP redirect is not mentioned in any of the package registry specs but lots of official registries do that so it should be supported by the usual clients.	2023-07-03 15:33:28 +02:00
wxiaoguang	45bc180a15	Make "cancel" buttons have proper type in modal forms (#25618) ... Replace #25446, fix #25438 All "cancel" buttons which do not have "type" should not submit the form, should not be triggered by "Enter". This is a complete fix for all modal dialogs. The major change is "modules/aria/modal.js", "devtest" related code is for demo/test purpose.	2023-07-03 14:04:50 +08:00
Lunny Xiao	7735da1c66	Display branch commit status (#25608) ... Fix #10388 This PR adds a status icon for every branch which has a status check for the latest commit on branch list page. <img width="1313" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/727cd540-d03a-40c6-a7dd-e87c118af0ac">	2023-07-03 03:32:21 +00:00
Lunny Xiao	807c9712ef	Get latest commit statuses from database instead of git data on dashboard for repositories (#25605) ... related #24638	2023-07-03 01:53:05 +00:00
hiifong	36f1fa7792	Support displaying diff stats in PR tab bar (#25387) ... Fix #25326 --------- Co-authored-by: silverwind <me@silverwind.io>	2023-07-03 01:00:28 +00:00
Lunny Xiao	aab7cb6750	Move some files under repo/setting (#25585) ... There are too many files under `routers/web/repo` and the file `routers/web/repo/setting.go` is too big. This PR move all setting related routers' body functions under `routers/web/repo/setting` and also split `routers/web/repo/setting.go`	2023-07-02 08:59:32 +08:00
KN4CK3R	cf2356062f	Redirect to package after version deletion (#25594) ... Related #25559 Current behaviour: 1. Deletion of a package version 2. Redirect to the owners package list New behaviour: 1. Deletion of a package version 2.1. If there are more versions available, redirect to the package again 2.2. If there are no versions available, redirect to the owners package list	2023-06-29 17:01:14 +00:00
Lunny Xiao	6e19484f4d	Sync branches into databases (#22743) ... Related #14180 Related #25233 Related #22639 Close #19786 Related #12763 This PR will change all the branches retrieve method from reading git data to read database to reduce git read operations. - [x] Sync git branches information into database when push git data - [x] Create a new table `Branch`, merge some columns of `DeletedBranch` into `Branch` table and drop the table `DeletedBranch`. - [x] Read `Branch` table when visit `code` -> `branch` page - [x] Read `Branch` table when list branch names in `code` page dropdown - [x] Read `Branch` table when list git ref compare page - [x] Provide a button in admin page to manually sync all branches. - [x] Sync branches if repository is not empty but database branches are empty when visiting pages with branches list - [x] Use `commit_time desc` as the default FindBranch order by to keep consistent as before and deleted branches will be always at the end. --------- Co-authored-by: Jason Song <i@wolfogre.com>	2023-06-29 10:03:20 +00:00
HesterG	c6f1fb1c6d	Use fetch form action for lock/unlock/pin/unpin on sidebar (#25380) ... Before: <img width="364" alt="Screen Shot 2023-06-20 at 11 59 11" src="https://github.com/go-gitea/gitea/assets/17645053/ad284b7e-8d21-43be-b178-bbcfd37cb5bd"> Might trigger many posts when keep clicking the buttons above. <img width="448" alt="Screen Shot 2023-06-20 at 11 52 28" src="https://github.com/go-gitea/gitea/assets/17645053/a60aa6ac-af74-45e4-b13a-512b436b81b0"> <img width="678" alt="Screen Shot 2023-06-20 at 11 52 37" src="https://github.com/go-gitea/gitea/assets/17645053/d6662700-3643-4cc7-a2ec-64e1c0f5fbdb"> After (PR sidebar, Same for issue): https://github.com/go-gitea/gitea/assets/17645053/9df3ad1f-e29c-439b-8bde-e6b917d63cc6 For delete, it is using `base/modal_actions_confirm` subtemplate, and we might need another general solution for this (maybe add another attribute to the subtemplate or something) --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-06-29 04:16:04 +00:00
Vitaliy Filippov	f0b773e0ce	Support downloading raw task logs (#24451) ... Hi! This pull request adds support for downloading raw task logs for Gitea Actions, similar to Github Actions It looks like the following: 	2023-06-29 10:58:56 +08:00
a1012112796	4aba8a6a5f	Split lfs size from repository size (#22900) ... releated to #21820 - Split `Size` in repository table as two new colunms, one is `GitSize` for git size, the other is `LFSSize` for lfs data. still store full size in `Size` colunm. - Show full size on ui, but show each of them by a `title`; example:  - Return full size in api response. --------- Signed-off-by: a1012112796 <1012112796@qq.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: DmitryFrolovTri <23313323+DmitryFrolovTri@users.noreply.github.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-28 22:41:02 +00:00
wxiaoguang	ddf96f68cc	Use JSON response for "user/logout" (#25522) ... The request sent to "user/logout" is from "link-action", it expects to get JSON response.	2023-06-26 21:36:10 +02:00
Lunny Xiao	083818cb85	Improve loadprojects for issue list (#25468)	2023-06-24 15:31:28 +00:00
wxiaoguang	62ab55bacc	Improve wiki sidebar and TOC (#25460) ... Close #20976 Close #20975 1. Fix the bug: the TOC in footer was incorrectly rendered as main content's TOC 2. Fix the layout: on mobile, the TOC is put above the main content, while the sidebar is put below the main content 3. Auto collapse the TOC on mobile ps: many styles of "wiki.css" are moved from old css files, so leave nits to following PRs.	2023-06-23 15:51:43 -04:00
Jason Song	375fd15fbf	Refactor indexer (#25174) ... Refactor `modules/indexer` to make it more maintainable. And it can be easier to support more features. I'm trying to solve some of issue searching, this is a precursor to making functional changes. Current supported engines and the index versions: | engines | issues | code | | - | - | - | | db | Just a wrapper for database queries, doesn't need version | - | | bleve | The version of index is **2** | The version of index is **6** | | elasticsearch | The old index has no version, will be treated as version **0** in this PR | The version of index is **1** | | meilisearch | The old index has no version, will be treated as version **0** in this PR | - | ## Changes ### Split Splited it into mutiple packages ```text indexer ├── internal │   ├── bleve │   ├── db │   ├── elasticsearch │   └── meilisearch ├── code │   ├── bleve │   ├── elasticsearch │   └── internal └── issues ├── bleve ├── db ├── elasticsearch ├── internal └── meilisearch ``` - `indexer/interanal`: Internal shared package for indexer. - `indexer/interanal/[engine]`: Internal shared package for each engine (bleve/db/elasticsearch/meilisearch). - `indexer/code`: Implementations for code indexer. - `indexer/code/internal`: Internal shared package for code indexer. - `indexer/code/[engine]`: Implementation via each engine for code indexer. - `indexer/issues`: Implementations for issues indexer. ### Deduplication - Combine `Init/Ping/Close` for code indexer and issues indexer. - ~Combine `issues.indexerHolder` and `code.wrappedIndexer` to `internal.IndexHolder`.~ Remove it, use dummy indexer instead when the indexer is not ready. - Duplicate two copies of creating ES clients. - Duplicate two copies of `indexerID()`. ### Enhancement - [x] Support index version for elasticsearch issues indexer, the old index without version will be treated as version 0. - [x] Fix spell of `elastic_search/ElasticSearch`, it should be `Elasticsearch`. - [x] Improve versioning of ES index. We don't need `Aliases`: - Gitea does't need aliases for "Zero Downtime" because it never delete old indexes. - The old code of issues indexer uses the orignal name to create issue index, so it's tricky to convert it to an alias. - [x] Support index version for meilisearch issues indexer, the old index without version will be treated as version 0. - [x] Do "ping" only when `Ping` has been called, don't ping periodically and cache the status. - [x] Support the context parameter whenever possible. - [x] Fix outdated example config. - [x] Give up the requeue logic of issues indexer: When indexing fails, call Ping to check if it was caused by the engine being unavailable, and only requeue the task if the engine is unavailable. - It is fragile and tricky, could cause data losing (It did happen when I was doing some tests for this PR). And it works for ES only. - Just always requeue the failed task, if it caused by bad data, it's a bug of Gitea which should be fixed. --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-23 12:37:56 +00:00
6543	b0215c40cd	Store and use seconds for timeline time comments (#25392) ... this will allow us to fully localize it later PS: we can not migrate back as the old value was a one-way conversion prepare for #25213 --- *Sponsored by Kithara Software GmbH*	2023-06-23 12:12:39 +00:00
Jason Song	174213530d	Fix `Permission` in API returned repository struct (#25388) ... The old code generates `structs.Repository.Permissions` with only `access.Permission.AccessMode`, however, it should check the units too, or the value could be incorrect. For example, `structs.Repository.Permissions.Push` could be false even the doer has write access to code unit. Should fix https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128 (Not reported by it, I just found it when I was looking into this bug) --- Review tips: The major changes are - `modules/structs/repo.go` https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7 - `services/convert/repository.go` https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101 And other changes are passive.	2023-06-22 13:08:08 +00:00
sebastian-sauer	25455bc670	Show outdated comments in files changed tab (#24936) ... If enabled show a clickable label in the comment. A click on the label opens the Conversation tab with the comment focussed - there you're able to view the old diff (or original diff the comment was created on). **Screenshots**   When resolved and outdated:  Option to enable/disable this (stored in user settings - default is disabled):   fixes #24913 --------- Co-authored-by: silverwind <me@silverwind.io>	2023-06-21 16:08:12 +00:00
wxiaoguang	2cdf260f42	Refactor path & config system (#25330) ... # The problem There were many "path tricks": * By default, Gitea uses its program directory as its work path * Gitea tries to use the "work path" to guess its "custom path" and "custom conf (app.ini)" * Users might want to use other directories as work path * The non-default work path should be passed to Gitea by GITEA_WORK_DIR or "--work-path" * But some Gitea processes are started without these values * The "serv" process started by OpenSSH server * The CLI sub-commands started by site admin * The paths are guessed by SetCustomPathAndConf again and again * The default values of "work path / custom path / custom conf" can be changed when compiling # The solution * Use `InitWorkPathAndCommonConfig` to handle these path tricks, and use test code to cover its behaviors. * When Gitea's web server runs, write the WORK_PATH to "app.ini", this value must be the most correct one, because if this value is not right, users would find that the web UI doesn't work and then they should be able to fix it. * Then all other sub-commands can use the WORK_PATH in app.ini to initialize their paths. * By the way, when Gitea starts for git protocol, it shouldn't output any log, otherwise the git protocol gets broken and client blocks forever. The "work path" priority is: WORK_PATH in app.ini > cmd arg --work-path > env var GITEA_WORK_DIR > builtin default The "app.ini" searching order is: cmd arg --config > cmd arg "work path / custom path" > env var "work path / custom path" > builtin default ## ⚠️ BREAKING If your instance's "work path / custom path / custom conf" doesn't meet the requirements (eg: work path must be absolute), Gitea will report a fatal error and exit. You need to set these values according to the error log. ---- Close #24818 Close #24222 Close #21606 Close #21498 Close #25107 Close #24981 Maybe close #24503 Replace #23301 Replace #22754 And maybe more	2023-06-21 13:50:26 +08:00
HesterG	1454f9dafc	Add actor and status dropdowns to run list (#25118) ... Part of #25042 1. Added actor and status dropdowns first in case something is offtrack and PR is too large. 2. Also added "No results matched." and "The workflow has no runs yet.", and "No results matched." will show if there is no filter results and there is no workflows (with [reference to github action](https://github.com/go-gitea/gitea/actions/workflows/files-changed.yml?query=actor%3AGiteaBot)) Demo: https://github.com/go-gitea/gitea/assets/17645053/6e76292c-4c1f-450d-8b48-99944cfc920c TODOs: - [x] Get available status (same as those in `aggregateJobStatus`) instead of getting from database - [x] Use `JOIN` to get actors, actors order by name - [x] Make self on top	2023-06-21 04:25:14 +00:00
sillyguodong	35a653d7ed	Support configuration variables on Gitea Actions (#24724) ... Co-Author: @silverwind @wxiaoguang Replace: #24404 See: - [defining configuration variables for multiple workflows](https://docs.github.com/en/actions/learn-github-actions/variables#defining-configuration-variables-for-multiple-workflows) - [vars context](https://docs.github.com/en/actions/learn-github-actions/contexts#vars-context) Related to: - [x] protocol: https://gitea.com/gitea/actions-proto-def/pulls/7 - [x] act_runner: https://gitea.com/gitea/act_runner/pulls/157 - [x] act: https://gitea.com/gitea/act/pulls/43 #### Screenshoot Create Variable:   Workflow: ```yaml test_vars: runs-on: ubuntu-latest steps: - name: Print Custom Variables run: echo "${{ vars.test_key }}" - name: Try to print a non-exist var run: echo "${{ vars.NON_EXIST_VAR }}" ``` Actions Log:  --- This PR just implement the org / user (depends on the owner of the current repository) and repo level variables, The Environment level variables have not been implemented. Because [Environment](https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment#about-environments) is a module separate from `Actions`. Maybe it would be better to create a new PR to do it. --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-20 22:54:15 +00:00
Lunny Xiao	54259dbf37	Fix blank dir message when uploading files from web editor (#25391) ... Fix #7883	2023-06-20 19:58:03 +00:00
wxiaoguang	b4e4b7ad51	Make backend code respond correct JSON when creating PR (#25353) ... Fix #25351	2023-06-19 08:25:36 +00:00
wxiaoguang	a1c5057fe8	Batch delete issue and improve tippy opts (#25253) ... 1. Add "batch delete" button for selected issues, close #22273 2. Address the review in https://github.com/go-gitea/gitea/pull/25219#discussion_r1229266083	2023-06-19 15:46:50 +08:00
wxiaoguang	4e2f1ee58d	Refactor web package and context package (#25298) ... 1. The "web" package shouldn't depends on "modules/context" package, instead, let each "web context" register themselves to the "web" package. 2. The old Init/Free doesn't make sense, so simplify it * The ctx in "Init(ctx)" is never used, and shouldn't be used that way * The "Free" is never called and shouldn't be called because the SSPI instance is shared --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-18 09:59:09 +02:00
wxiaoguang	b71cb7acdc	Use fetch to send requests to create issues/comments (#25258) ... Follow #23290 Network error won't make content lost. And this is a much better approach than "loading-button". The UI is not perfect and there are still some TODOs, they can be done in following PRs, not a must in this PR's scope. <details>  </details>	2023-06-16 06:32:43 +00:00
JakobDev	a305c37e62	Show if File is Executable (#25287) ... This simply shows if a File has the executable Permission  --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-16 07:46:12 +02:00
wxiaoguang	73ae71824d	Show OAuth2 errors to end users (#25261) ... Partially fix #23936   	2023-06-15 01:12:50 +00:00
HesterG	a43ea22479	Change form actions to fetch for submit review box (#25219) ... Co-author: @wxiaoguang Close #25096 The way to fix it in this PR is to change form submit to fetch using formData, and add flags to avoid post repeatedly. Should be able to apply to more forms that have the same issue after this PR. In the demo below, 'approve' is clicked several times, and then 'comment' is clicked several time after 'request changes' clicked. After: https://github.com/go-gitea/gitea/assets/17645053/beabeb1d-fe66-4b76-b048-4f022b4e83a0 Update: screenshots from /devtest >  > >  > >  --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-06-14 16:01:37 +08:00
Lunny Xiao	d6dd6d641b	Fix all possible setting error related storages and added some tests (#23911) ... Follow up #22405 Fix #20703 This PR rewrites storage configuration read sequences with some breaks and tests. It becomes more strict than before and also fixed some inherit problems. - Move storage's MinioConfig struct into setting, so after the configuration loading, the values will be stored into the struct but not still on some section. - All storages configurations should be stored on one section, configuration items cannot be overrided by multiple sections. The prioioty of configuration is `[attachment]` > `[storage.attachments]` | `[storage.customized]` > `[storage]` > `default` - For extra override configuration items, currently are `SERVE_DIRECT`, `MINIO_BASE_PATH`, `MINIO_BUCKET`, which could be configured in another section. The prioioty of the override configuration is `[attachment]` > `[storage.attachments]` > `default`. - Add more tests for storages configurations. - Update the storage documentations. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-06-14 11:42:38 +08:00
sillyguodong	8228751c55	Support changing labels of Actions runner without re-registration (#24806) ... close #24540 related: - Protocol: https://gitea.com/gitea/actions-proto-def/pulls/9 - Runner side: https://gitea.com/gitea/act_runner/pulls/201 changes: - Add column of `labels` to table `action_runner`, and combine the value of `agent_labels` and `custom_labels` column to `labels` column. - Store `labels` when registering `act_runner`. - Update `labels` when `act_runner` starting and calling `Declare`. - Users cannot modify the `custom labels` in edit page any more. other changes: - Store `version` when registering `act_runner`. - If runner is latest version, parse version from `Declare`. But older version runner still parse version from request header.	2023-06-13 22:28:31 +08:00
yp05327	22a39bb961	Fix profile render when the README.md size is larger than 1024 bytes (#25131) ... Fixes https://github.com/go-gitea/gitea/issues/25094 `GetBlobContent` will only get the first 1024 bytes, if the README.md size is larger than 1024 bytes, We can not render the rest of them. After this fix, we should provide the limited size to read when call `GetBlobContent`. After:  --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-06-13 09:02:25 +00:00
Lunny Xiao	feb38da259	Fix bug for code search if code is disabled (#25173) ... Fix https://github.com/go-gitea/gitea/pull/24189/files#r1224144768	2023-06-09 19:02:33 +00:00
Vladimir Buyanov	3bdd48016f	Add codeowners feature (#24910) ... Hello. This PR adds a github like configuration for the CODEOWNERS file. Resolves: #10161	2023-06-08 16:56:05 +08:00