mirror/gitea
1
1
Fork 1
mirror of https://github.com/go-gitea/gitea.git synced 2024-11-16 02:13:25 +01:00
Code Issues

Remove unnecessary loading of settings in update hook (#9496)

Browse Source 
This PR simply makes update an empty command rather than needlessly load the settings for each reference.
This commit is contained in:
zeripath 2019-12-27 15:21:33 +00:00 committed by GitHub
parent 3d5f31f77d
commit 154424623a
Signed by: GitHub
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
cmd/hook.go
View File

@ -181,18 +181,7 @@ Gitea or set your environment appropriately.`, "")
}
func runHookUpdate(c *cli.Context) error {
if len(os.Getenv("SSH_ORIGINAL_COMMAND")) == 0 {
if setting.OnlyAllowPushIfGiteaEnvironmentSet {
fail(`Rejecting changes as Gitea environment not set.
If you are pushing over SSH you must push with a key managed by
Gitea or set your environment appropriately.`, "")
} else {
return nil
}
}
setup("hooks/update.log", false)
// Update is empty and is kept only for backwards compatibility
return nil
}