mirror of
https://github.com/git/git.git
synced 2024-11-18 04:04:11 +01:00
04724222d5
When dumping a cache-tree, we sprintf sub-tree names directly into a fixed-size buffer, which can overflow. We can trivially fix this by converting to xsnprintf to at least notice and die. This probably should handle arbitrary-sized names, but there's not much point. It's used only by the test scripts, so the trivial fix is enough. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
68 lines
1.6 KiB
C
68 lines
1.6 KiB
C
#include "cache.h"
|
|
#include "tree.h"
|
|
#include "cache-tree.h"
|
|
|
|
|
|
static void dump_one(struct cache_tree *it, const char *pfx, const char *x)
|
|
{
|
|
if (it->entry_count < 0)
|
|
printf("%-40s %s%s (%d subtrees)\n",
|
|
"invalid", x, pfx, it->subtree_nr);
|
|
else
|
|
printf("%s %s%s (%d entries, %d subtrees)\n",
|
|
sha1_to_hex(it->sha1), x, pfx,
|
|
it->entry_count, it->subtree_nr);
|
|
}
|
|
|
|
static int dump_cache_tree(struct cache_tree *it,
|
|
struct cache_tree *ref,
|
|
const char *pfx)
|
|
{
|
|
int i;
|
|
int errs = 0;
|
|
|
|
if (!it || !ref)
|
|
/* missing in either */
|
|
return 0;
|
|
|
|
if (it->entry_count < 0) {
|
|
/* invalid */
|
|
dump_one(it, pfx, "");
|
|
dump_one(ref, pfx, "#(ref) ");
|
|
}
|
|
else {
|
|
dump_one(it, pfx, "");
|
|
if (hashcmp(it->sha1, ref->sha1) ||
|
|
ref->entry_count != it->entry_count ||
|
|
ref->subtree_nr != it->subtree_nr) {
|
|
/* claims to be valid but is lying */
|
|
dump_one(ref, pfx, "#(ref) ");
|
|
errs = 1;
|
|
}
|
|
}
|
|
|
|
for (i = 0; i < it->subtree_nr; i++) {
|
|
char path[PATH_MAX];
|
|
struct cache_tree_sub *down = it->down[i];
|
|
struct cache_tree_sub *rdwn;
|
|
|
|
rdwn = cache_tree_sub(ref, down->name);
|
|
xsnprintf(path, sizeof(path), "%s%.*s/", pfx, down->namelen, down->name);
|
|
if (dump_cache_tree(down->cache_tree, rdwn->cache_tree, path))
|
|
errs = 1;
|
|
}
|
|
return errs;
|
|
}
|
|
|
|
int main(int ac, char **av)
|
|
{
|
|
struct index_state istate;
|
|
struct cache_tree *another = cache_tree();
|
|
if (read_cache() < 0)
|
|
die("unable to read index file");
|
|
istate = the_index;
|
|
istate.cache_tree = another;
|
|
cache_tree_update(&istate, WRITE_TREE_DRY_RUN);
|
|
return dump_cache_tree(active_cache_tree, another, "");
|
|
}
|