mirror of
https://github.com/git/git.git
synced 2024-05-24 08:26:29 +02:00
95d3c4f546
Currently the update hook invoked by receive-pack has its stdin connected to the pushing client. The hook shouldn't attempt to read from this stream, and doing so may consume data that was meant for receive-pack. Instead we should give the update hook /dev/null as its stdin, ensuring that it always receives EOF and doesn't disrupt the protocol if it attempts to read any data. The post-update hook is similar, as it gets invoked with /dev/null on stdin to prevent the hook from reading data from the client. Previously we had invoked it with stdout also connected to /dev/null, throwing away anything on stdout, to prevent client protocol errors. Instead we should redirect stdout to stderr, like we do with the update hook. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
23 lines
594 B
C
23 lines
594 B
C
#ifndef RUN_COMMAND_H
|
|
#define RUN_COMMAND_H
|
|
|
|
#define MAX_RUN_COMMAND_ARGS 256
|
|
enum {
|
|
ERR_RUN_COMMAND_FORK = 10000,
|
|
ERR_RUN_COMMAND_EXEC,
|
|
ERR_RUN_COMMAND_WAITPID,
|
|
ERR_RUN_COMMAND_WAITPID_WRONG_PID,
|
|
ERR_RUN_COMMAND_WAITPID_SIGNAL,
|
|
ERR_RUN_COMMAND_WAITPID_NOEXIT,
|
|
};
|
|
|
|
#define RUN_COMMAND_NO_STDIN 1
|
|
#define RUN_GIT_CMD 2 /*If this is to be git sub-command */
|
|
#define RUN_COMMAND_STDOUT_TO_STDERR 4
|
|
int run_command_v_opt(const char **argv, int opt);
|
|
int run_command_v(const char **argv);
|
|
int run_command_opt(int opt, const char *cmd, ...);
|
|
int run_command(const char *cmd, ...);
|
|
|
|
#endif
|