mirror of
https://github.com/git/git.git
synced 2024-05-09 10:16:08 +02:00
e885a84f1b
Many functions take an argv/argc pair, but never actually look at argc. This makes it useless at best (we use the NULL sentinel in argv to find the end of the array), and misleading at worst (what happens if the argc count does not match the argv NULL?). In each of these instances, the argv NULL does match the argc count, so there are no bugs here. But let's tighten the interfaces to make it harder to get wrong (and to reduce some -Wunused-parameter complaints). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
33 lines
762 B
C
33 lines
762 B
C
#include "test-tool.h"
|
|
#include "submodule-config.h"
|
|
|
|
static void die_usage(const char **argv, const char *msg)
|
|
{
|
|
fprintf(stderr, "%s\n", msg);
|
|
fprintf(stderr, "Usage: %s <submodulepath> <config name>\n", argv[0]);
|
|
exit(1);
|
|
}
|
|
|
|
int cmd__submodule_nested_repo_config(int argc, const char **argv)
|
|
{
|
|
struct repository subrepo;
|
|
const struct submodule *sub;
|
|
|
|
if (argc < 3)
|
|
die_usage(argv, "Wrong number of arguments.");
|
|
|
|
setup_git_directory();
|
|
|
|
sub = submodule_from_path(the_repository, &null_oid, argv[1]);
|
|
if (repo_submodule_init(&subrepo, the_repository, sub)) {
|
|
die_usage(argv, "Submodule not found.");
|
|
}
|
|
|
|
/* Read the config of _child_ submodules. */
|
|
print_config_from_gitmodules(&subrepo, argv[2]);
|
|
|
|
submodule_free(the_repository);
|
|
|
|
return 0;
|
|
}
|