1
0
mirror of https://github.com/git/git.git synced 2024-09-28 08:49:45 +02:00
git/vcs-svn
Jonathan Nieder e7d04ee147 vcs-svn: make reading of properties binary-safe
svn-fe errors out on revision 59151 of the ASF repository:

 fatal: invalid dump: unexpected end of file

The proximate cause is a property with an embedded NUL character.
Previously such anomalies were ignored but commit c9d1c8ba
(2010-12-28) introduced a check strlen(val) == len to avoid reading
uninitialized data when a property list ends early and unfortunately
this test does not distinguish between "foo" followed by EOF and the
string "foo\0bar\0baz".

Fix it by using buffer_read_binary to read to a strbuf and checking
the actual length read.  Most consumers of properties still use
C-style strings, so in practice an author or log message with embedded
NULs will be truncated, but a least this way svn-fe won't error out
(fixing the regression).

Reported-by: David Barr <david.barr@cordelta.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
2011-03-26 00:15:10 -05:00
..
fast_export.c vcs-svn: use strbuf for author, UUID, and URL 2011-03-22 18:01:48 -05:00
fast_export.h vcs-svn: use strbuf for author, UUID, and URL 2011-03-22 18:01:48 -05:00
LICENSE
line_buffer.c
line_buffer.h
line_buffer.txt
obj_pool.h
repo_tree.c vcs-svn: use strbuf for author, UUID, and URL 2011-03-22 18:01:48 -05:00
repo_tree.h vcs-svn: use strbuf for author, UUID, and URL 2011-03-22 18:01:48 -05:00
string_pool.c
string_pool.h
string_pool.txt
svndump.c vcs-svn: make reading of properties binary-safe 2011-03-26 00:15:10 -05:00
svndump.h
trp.h
trp.txt