mirror of
https://github.com/git/git.git
synced 2024-06-02 22:16:11 +02:00
7a98d9ab00
Extend the the release_revisions() function so that it frees the "cmdline" in the "struct rev_info". This in combination with a preceding change to free "commits" and "mailmap" means that we can whitelist another test under "TEST_PASSES_SANITIZE_LEAK=true". There was a proposal in [1] to do away with xstrdup()-ing this add_rev_cmdline(), perhaps that would be worthwhile, but for now let's just free() it. We could also make that a "char *" in "struct rev_cmdline_entry" itself, but since we own it let's expose it as a constant to outside callers. I proposed that in [2] but have since changed my mind. See14d30cdfc0(ref-filter: fix memory leak in `free_array_item()`, 2019-07-10),c514c62a4f(checkout: fix leak of non-existent branch names, 2020-08-14) and other log history hits for "free((char *)" for prior art. This includes the tests we had false-positive passes on before my6798b08e84(perl Git.pm: don't ignore signalled failure in _cmd_close(), 2022-02-01), now they pass for real. Since there are 66 tests matching t/t[0-9]*git-svn*.sh it's easier to list those that don't pass than to touch most of those 66. So let's introduce a "TEST_FAILS_SANITIZE_LEAK=true", which if set in the tests won't cause lib-git-svn.sh to set "TEST_PASSES_SANITIZE_LEAK=true. This change also marks all the tests that we removed "TEST_FAILS_SANITIZE_LEAK=true" from in an earlier commit due to removing the UNLEAK() from cmd_format_patch(), we can now assert that its API use doesn't leak any "struct rev_info" memory. This change also made commit "t5503-tagfollow.sh" pass on current master, but that would regress when combined with ps/fetch-atomic-fixup'sde004e848a(t5503: simplify setup of test which exercises failure of backfill, 2022-03-03) (through no fault of that topic, that change started using "git clone" in the test, which has an outstanding leak). Let's leave that test out for now to avoid in-flight semantic conflicts. 1. https://lore.kernel.org/git/YUj%2FgFRh6pwrZalY@carlos-mbp.lan/ 2. https://lore.kernel.org/git/87o88obkb1.fsf@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
390 lines
10 KiB
Bash
Executable File
390 lines
10 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='rev-list/rev-parse --glob'
|
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
commit () {
|
|
test_tick &&
|
|
echo $1 > foo &&
|
|
git add foo &&
|
|
git commit -m "$1"
|
|
}
|
|
|
|
compare () {
|
|
# Split arguments on whitespace.
|
|
git $1 $2 >expected &&
|
|
git $1 $3 >actual &&
|
|
test_cmp expected actual
|
|
}
|
|
|
|
test_expect_success 'setup' '
|
|
|
|
commit main &&
|
|
git checkout -b subspace/one main &&
|
|
commit one &&
|
|
git checkout -b subspace/two main &&
|
|
commit two &&
|
|
git checkout -b subspace-x main &&
|
|
commit subspace-x &&
|
|
git checkout -b other/three main &&
|
|
commit three &&
|
|
git checkout -b someref main &&
|
|
commit some &&
|
|
git checkout main &&
|
|
commit topic_2 &&
|
|
git tag foo/bar main &&
|
|
commit topic_3 &&
|
|
git update-ref refs/remotes/foo/baz main &&
|
|
commit topic_4 &&
|
|
git update-ref refs/remotes/upstream/one subspace/one &&
|
|
git update-ref refs/remotes/upstream/two subspace/two &&
|
|
git update-ref refs/remotes/upstream/x subspace-x &&
|
|
git tag qux/one subspace/one &&
|
|
git tag qux/two subspace/two &&
|
|
git tag qux/x subspace-x
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=refs/heads/subspace/*' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--glob=refs/heads/subspace/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=heads/subspace/*' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--glob=heads/subspace/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=refs/heads/subspace/' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--glob=refs/heads/subspace/"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=heads/subspace/' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--glob=heads/subspace/"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=heads/subspace' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--glob=heads/subspace"
|
|
|
|
'
|
|
|
|
test_expect_failure 'rev-parse accepts --glob as detached option' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--glob heads/subspace"
|
|
|
|
'
|
|
|
|
test_expect_failure 'rev-parse is not confused by option-like glob' '
|
|
|
|
compare rev-parse "main" "--glob --symbolic main"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --branches=subspace/*' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--branches=subspace/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --branches=subspace/' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--branches=subspace/"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --branches=subspace' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--branches=subspace"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=heads/subspace/* --glob=heads/other/*' '
|
|
|
|
compare rev-parse "subspace/one subspace/two other/three" "--glob=heads/subspace/* --glob=heads/other/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=heads/someref/* main' '
|
|
|
|
compare rev-parse "main" "--glob=heads/someref/* main"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=heads/*' '
|
|
|
|
compare rev-parse "main other/three someref subspace-x subspace/one subspace/two" "--glob=heads/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --tags=foo' '
|
|
|
|
compare rev-parse "foo/bar" "--tags=foo"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --remotes=foo' '
|
|
|
|
compare rev-parse "foo/baz" "--remotes=foo"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude with --branches' '
|
|
compare rev-parse "--exclude=*/* --branches" "main someref subspace-x"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude with --all' '
|
|
compare rev-parse "--exclude=refs/remotes/* --all" "--branches --tags"
|
|
'
|
|
|
|
test_expect_success 'rev-parse accumulates multiple --exclude' '
|
|
compare rev-parse "--exclude=refs/remotes/* --exclude=refs/tags/* --all" --branches
|
|
'
|
|
|
|
test_expect_success 'rev-parse --branches clears --exclude' '
|
|
compare rev-parse "--exclude=* --branches --branches" "--branches"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --tags clears --exclude' '
|
|
compare rev-parse "--exclude=* --tags --tags" "--tags"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --all clears --exclude' '
|
|
compare rev-parse "--exclude=* --all --all" "--all"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude=glob with --branches=glob' '
|
|
compare rev-parse "--exclude=subspace-* --branches=sub*" "subspace/one subspace/two"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude=glob with --tags=glob' '
|
|
compare rev-parse "--exclude=qux/? --tags=qux/*" "qux/one qux/two"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude=glob with --remotes=glob' '
|
|
compare rev-parse "--exclude=upstream/? --remotes=upstream/*" "upstream/one upstream/two"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude=ref with --branches=glob' '
|
|
compare rev-parse "--exclude=subspace-x --branches=sub*" "subspace/one subspace/two"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude=ref with --tags=glob' '
|
|
compare rev-parse "--exclude=qux/x --tags=qux/*" "qux/one qux/two"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude=ref with --remotes=glob' '
|
|
compare rev-parse "--exclude=upstream/x --remotes=upstream/*" "upstream/one upstream/two"
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude=glob with --branches=glob' '
|
|
compare rev-list "--exclude=subspace-* --branches=sub*" "subspace/one subspace/two"
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude=glob with --tags=glob' '
|
|
compare rev-list "--exclude=qux/? --tags=qux/*" "qux/one qux/two"
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude=glob with --remotes=glob' '
|
|
compare rev-list "--exclude=upstream/? --remotes=upstream/*" "upstream/one upstream/two"
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude=ref with --branches=glob' '
|
|
compare rev-list "--exclude=subspace-x --branches=sub*" "subspace/one subspace/two"
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude=ref with --tags=glob' '
|
|
compare rev-list "--exclude=qux/x --tags=qux/*" "qux/one qux/two"
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude=ref with --remotes=glob' '
|
|
compare rev-list "--exclude=upstream/x --remotes=upstream/*" "upstream/one upstream/two"
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=refs/heads/subspace/*' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--glob=refs/heads/subspace/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob refs/heads/subspace/*' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--glob refs/heads/subspace/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list not confused by option-like --glob arg' '
|
|
|
|
compare rev-list "main" "--glob -0 main"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=heads/subspace/*' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--glob=heads/subspace/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=refs/heads/subspace/' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--glob=refs/heads/subspace/"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=heads/subspace/' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--glob=heads/subspace/"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=heads/subspace' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--glob=heads/subspace"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --branches=subspace/*' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--branches=subspace/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --branches=subspace/' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--branches=subspace/"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --branches=subspace' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--branches=subspace"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --branches' '
|
|
|
|
compare rev-list "main subspace-x someref other/three subspace/one subspace/two" "--branches"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=heads/someref/* main' '
|
|
|
|
compare rev-list "main" "--glob=heads/someref/* main"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=heads/subspace/* --glob=heads/other/*' '
|
|
|
|
compare rev-list "subspace/one subspace/two other/three" "--glob=heads/subspace/* --glob=heads/other/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=heads/*' '
|
|
|
|
compare rev-list "main other/three someref subspace-x subspace/one subspace/two" "--glob=heads/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --tags=foo' '
|
|
|
|
compare rev-list "foo/bar" "--tags=foo"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --tags' '
|
|
|
|
compare rev-list "foo/bar qux/x qux/two qux/one" "--tags"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --remotes=foo' '
|
|
|
|
compare rev-list "foo/baz" "--remotes=foo"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude with --branches' '
|
|
compare rev-list "--exclude=*/* --branches" "main someref subspace-x"
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude with --all' '
|
|
compare rev-list "--exclude=refs/remotes/* --all" "--branches --tags"
|
|
'
|
|
|
|
test_expect_success 'rev-list accumulates multiple --exclude' '
|
|
compare rev-list "--exclude=refs/remotes/* --exclude=refs/tags/* --all" --branches
|
|
'
|
|
|
|
test_expect_success 'rev-list should succeed with empty output on empty stdin' '
|
|
git rev-list --stdin </dev/null >actual &&
|
|
test_must_be_empty actual
|
|
'
|
|
|
|
test_expect_success 'rev-list should succeed with empty output with all refs excluded' '
|
|
git rev-list --exclude=* --all >actual &&
|
|
test_must_be_empty actual
|
|
'
|
|
|
|
test_expect_success 'rev-list should succeed with empty output with empty --all' '
|
|
(
|
|
test_create_repo empty &&
|
|
cd empty &&
|
|
git rev-list --all >actual &&
|
|
test_must_be_empty actual
|
|
)
|
|
'
|
|
|
|
test_expect_success 'rev-list should succeed with empty output with empty glob' '
|
|
git rev-list --glob=does-not-match-anything >actual &&
|
|
test_must_be_empty actual
|
|
'
|
|
|
|
test_expect_success 'rev-list should succeed with empty output when ignoring missing' '
|
|
git rev-list --ignore-missing $ZERO_OID >actual &&
|
|
test_must_be_empty actual
|
|
'
|
|
|
|
test_expect_success 'shortlog accepts --glob/--tags/--remotes' '
|
|
|
|
compare shortlog "subspace/one subspace/two" --branches=subspace &&
|
|
compare shortlog \
|
|
"main subspace-x someref other/three subspace/one subspace/two" \
|
|
--branches &&
|
|
compare shortlog main "--glob=heads/someref/* main" &&
|
|
compare shortlog "subspace/one subspace/two other/three" \
|
|
"--glob=heads/subspace/* --glob=heads/other/*" &&
|
|
compare shortlog \
|
|
"main other/three someref subspace-x subspace/one subspace/two" \
|
|
"--glob=heads/*" &&
|
|
compare shortlog foo/bar --tags=foo &&
|
|
compare shortlog "foo/bar qux/one qux/two qux/x" --tags &&
|
|
compare shortlog foo/baz --remotes=foo
|
|
|
|
'
|
|
|
|
test_expect_failure 'shortlog accepts --glob as detached option' '
|
|
|
|
compare shortlog \
|
|
"main other/three someref subspace-x subspace/one subspace/two" \
|
|
"--glob heads/*"
|
|
|
|
'
|
|
|
|
test_expect_failure 'shortlog --glob is not confused by option-like argument' '
|
|
|
|
compare shortlog main "--glob -e main"
|
|
|
|
'
|
|
|
|
test_done
|