mirror of
https://github.com/git/git.git
synced 2024-11-18 04:43:52 +01:00
41ac414ea2
Originally, test_expect_failure was designed to be the opposite
of test_expect_success, but this was a bad decision. Most tests
run a series of commands that leads to the single command that
needs to be tested, like this:
test_expect_{success,failure} 'test title' '
setup1 &&
setup2 &&
setup3 &&
what is to be tested
'
And expecting a failure exit from the whole sequence misses the
point of writing tests. Your setup$N that are supposed to
succeed may have failed without even reaching what you are
trying to test. The only valid use of test_expect_failure is to
check a trivial single command that is expected to fail, which
is a minority in tests of Porcelain-ish commands.
This large-ish patch rewrites all uses of test_expect_failure to
use test_expect_success and rewrites the condition of what is
tested, like this:
test_expect_success 'test title' '
setup1 &&
setup2 &&
setup3 &&
! this command should fail
'
test_expect_failure is redefined to serve as a reminder that
that test *should* succeed but due to a known breakage in git it
currently does not pass. So if git-foo command should create a
file 'bar' but you discovered a bug that it doesn't, you can
write a test like this:
test_expect_failure 'git-foo should create bar' '
rm -f bar &&
git foo &&
test -f bar
'
This construct acts similar to test_expect_success, but instead
of reporting "ok/FAIL" like test_expect_success does, the
outcome is reported as "FIXED/still broken".
Signed-off-by: Junio C Hamano <gitster@pobox.com>
54 lines
665 B
Bash
Executable File
54 lines
665 B
Bash
Executable File
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2006 Catalin Marinas
|
|
#
|
|
|
|
test_description='git apply trying to add an ending line.
|
|
|
|
'
|
|
. ./test-lib.sh
|
|
|
|
# setup
|
|
|
|
cat >test-patch <<\EOF
|
|
diff --git a/file b/file
|
|
--- a/file
|
|
+++ b/file
|
|
@@ -1,2 +1,3 @@
|
|
a
|
|
b
|
|
+c
|
|
EOF
|
|
|
|
echo 'a' >file
|
|
echo 'b' >>file
|
|
echo 'c' >>file
|
|
|
|
test_expect_success setup \
|
|
'git update-index --add file'
|
|
|
|
# test
|
|
|
|
test_expect_success 'apply at the end' \
|
|
'! git apply --index test-patch'
|
|
|
|
cat >test-patch <<\EOF
|
|
diff a/file b/file
|
|
--- a/file
|
|
+++ b/file
|
|
@@ -1,2 +1,3 @@
|
|
+a
|
|
b
|
|
c
|
|
EOF
|
|
|
|
echo >file 'a
|
|
b
|
|
c'
|
|
git update-index file
|
|
|
|
test_expect_success 'apply at the beginning' \
|
|
'! git apply --index test-patch'
|
|
|
|
test_done
|