mirror of
https://github.com/git/git.git
synced 2024-05-23 14:56:12 +02:00
6c62f01552
'git for-each-repo --config=X' should return success without calling any subcommands when the config key 'X' has no value. The current implementation instead segfaults. A user could run into this issue if they used 'git maintenance start' to initialize their cron schedule using 'git for-each-repo --config=maintenance.repo ...' but then using 'git maintenance unregister' to remove the config option. (Note: 'git maintenance stop' would remove the config _and_ remove the cron schedule.) Add a simple test to ensure this works. Use 'git help --no-such-option' as the potential subcommand to ensure that we will hit a failure if the subcommand is ever run. Reported-by: Andreas Bühmann <dev@uuml.de> Helped-by: Eric Sunshine <sunshine@sunshineco.com> Helped-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Derrick Stolee <dstolee@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
66 lines
1.5 KiB
C
66 lines
1.5 KiB
C
#include "cache.h"
|
|
#include "config.h"
|
|
#include "builtin.h"
|
|
#include "parse-options.h"
|
|
#include "run-command.h"
|
|
#include "string-list.h"
|
|
|
|
static const char * const for_each_repo_usage[] = {
|
|
N_("git for-each-repo --config=<config> <command-args>"),
|
|
NULL
|
|
};
|
|
|
|
static int run_command_on_repo(const char *path,
|
|
void *cbdata)
|
|
{
|
|
int i;
|
|
struct child_process child = CHILD_PROCESS_INIT;
|
|
struct strvec *args = (struct strvec *)cbdata;
|
|
|
|
child.git_cmd = 1;
|
|
strvec_pushl(&child.args, "-C", path, NULL);
|
|
|
|
for (i = 0; i < args->nr; i++)
|
|
strvec_push(&child.args, args->v[i]);
|
|
|
|
return run_command(&child);
|
|
}
|
|
|
|
int cmd_for_each_repo(int argc, const char **argv, const char *prefix)
|
|
{
|
|
static const char *config_key = NULL;
|
|
int i, result = 0;
|
|
const struct string_list *values;
|
|
struct strvec args = STRVEC_INIT;
|
|
|
|
const struct option options[] = {
|
|
OPT_STRING(0, "config", &config_key, N_("config"),
|
|
N_("config key storing a list of repository paths")),
|
|
OPT_END()
|
|
};
|
|
|
|
argc = parse_options(argc, argv, prefix, options, for_each_repo_usage,
|
|
PARSE_OPT_STOP_AT_NON_OPTION);
|
|
|
|
if (!config_key)
|
|
die(_("missing --config=<config>"));
|
|
|
|
for (i = 0; i < argc; i++)
|
|
strvec_push(&args, argv[i]);
|
|
|
|
values = repo_config_get_value_multi(the_repository,
|
|
config_key);
|
|
|
|
/*
|
|
* Do nothing on an empty list, which is equivalent to the case
|
|
* where the config variable does not exist at all.
|
|
*/
|
|
if (!values)
|
|
return 0;
|
|
|
|
for (i = 0; !result && i < values->nr; i++)
|
|
result = run_command_on_repo(values->items[i].string, &args);
|
|
|
|
return result;
|
|
}
|