1
0
mirror of https://github.com/git/git.git synced 2024-10-02 18:11:45 +02:00
git/perl/Git
Matthieu Moy b3275838d9 pager: remove 'S' from $LESS by default
By default, Git used to set $LESS to -FRSX if $LESS was not set by
the user. The FRX flags actually make sense for Git (F and X because
sometimes the output Git pipes to less is short, and R because Git
pipes colored output). The S flag (chop long lines), on the other
hand, is not related to Git and is a matter of user preference. Git
should not decide for the user to change LESS's default.

More specifically, the S flag harms users who review untrusted code
within a pager, since a patch looking like:

    -old code;
    +new good code; [... lots of tabs ...] malicious code;

would appear identical to:

    -old code;
    +new good code;

Users who prefer the old behavior can still set the $LESS environment
variable to -FRSX explicitly, or set core.pager to 'less -S'.

The documentation in config.txt is made a bit longer to keep both an
example setting the 'S' flag (needed to recover the old behavior)
and an example showing how to unset a flag set by Git.

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2014-05-07 13:41:04 -07:00
..
SVN pager: remove 'S' from $LESS by default 2014-05-07 13:41:04 -07:00
I18N.pm Correct common spelling mistakes in comments and tests 2013-04-12 13:38:40 -07:00
IndexInfo.pm Move Git::IndexInfo into its own file. 2012-07-27 22:36:17 +00:00
SVN.pm code and test: fix misuses of "nor" 2014-03-31 15:29:33 -07:00