mirror of
https://github.com/git/git.git
synced 2024-05-20 13:26:08 +02:00
7c10605d2c
Built-in merge tools contain a hard-coded assumption about whether or not a tool's exit code can be trusted to determine the success or failure of a merge. Tools whose exit codes are not trusted contain calls to check_unchanged() in their merge_cmd() functions. A problem with this is that the trustExitCode configuration is not honored for built-in tools. Teach built-in tools to honor the trustExitCode configuration. Extend run_merge_cmd() so that it is responsible for calling check_unchanged() when a tool's exit code cannot be trusted. Remove check_unchanged() calls from scriptlets since they are no longer responsible for calling it. When no configuration is present, exit_code_trustable() is checked to see whether the exit code should be trusted. The default implementation returns false. Tools whose exit codes can be trusted override exit_code_trustable() to true. Reported-by: Dun Peal <dunpealer@gmail.com> Signed-off-by: David Aguilar <davvid@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
26 lines
663 B
Plaintext
26 lines
663 B
Plaintext
diff_cmd () {
|
|
"$merge_tool_path" "$LOCAL" "$REMOTE" >/dev/null 2>&1
|
|
}
|
|
|
|
merge_cmd () {
|
|
# Adding $(pwd)/ in front of $MERGED should not be necessary.
|
|
# However without it, DeltaWalker (at least v1.9.8 on Windows)
|
|
# crashes with a JRE exception. The DeltaWalker user manual,
|
|
# shows $(pwd)/ whenever the '-merged' options is given.
|
|
# Adding it here seems to work around the problem.
|
|
if $base_present
|
|
then
|
|
"$merge_tool_path" "$LOCAL" "$REMOTE" "$BASE" -merged="$(pwd)/$MERGED"
|
|
else
|
|
"$merge_tool_path" "$LOCAL" "$REMOTE" -merged="$(pwd)/$MERGED"
|
|
fi >/dev/null 2>&1
|
|
}
|
|
|
|
translate_merge_tool_path () {
|
|
echo DeltaWalker
|
|
}
|
|
|
|
exit_code_trustable () {
|
|
true
|
|
}
|