mirror of
https://github.com/git/git.git
synced 2024-05-27 18:06:36 +02:00
9081a421a6
The "checkout" command is one of the main sources of leaks in the test
suite, let's fix the common ones by not leaking from the "struct
branch_info".
Doing this is rather straightforward, albeit verbose, we need to
xstrdup() constant strings going into the struct, and free() the ones
we clobber as we go along.
This also means that we can delete previous partial leak fixes in this
area, i.e. the "path_to_free" accounting added by 96ec7b1e70 (Convert
resolve_ref+xstrdup to new resolve_refdup function, 2011-12-13).
There was some discussion about whether "we should retain the "const
char *" here and cast at free() time, or have it be a "char *". Since
this is not a public API with any sort of API boundary let's use
"char *", as is already being done for the "refname" member of the
same struct.
The tests to mark as passing were found with:
rm .prove; GIT_SKIP_TESTS=t0027 prove -j8 --state=save t[0-9]*.sh :: --immediate
# apply & compile this change
prove -j8 --state=failed :: --immediate
I.e. the ones that were newly passing when the --state=failed command
was run. I left out "t3040-subprojects-basic.sh" and
"t4131-apply-fake-ancestor.sh" to to optimization-level related
differences similar to the ones noted in[1], except that these would
be something the current 'linux-leaks' job would run into.
1. https://lore.kernel.org/git/cover-v3-0.6-00000000000-20211022T175227Z-avarab@gmail.com/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
70 lines
1.7 KiB
Bash
Executable File
70 lines
1.7 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='checkout and pathspecs/refspecs ambiguities'
|
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'setup' '
|
|
echo hello >world &&
|
|
echo hello >all &&
|
|
git add all world &&
|
|
git commit -m initial &&
|
|
git branch world
|
|
'
|
|
|
|
test_expect_success 'reference must be a tree' '
|
|
test_must_fail git checkout $(git hash-object ./all) --
|
|
'
|
|
|
|
test_expect_success 'branch switching' '
|
|
test "refs/heads/main" = "$(git symbolic-ref HEAD)" &&
|
|
git checkout world -- &&
|
|
test "refs/heads/world" = "$(git symbolic-ref HEAD)"
|
|
'
|
|
|
|
test_expect_success 'checkout world from the index' '
|
|
echo bye > world &&
|
|
git checkout -- world &&
|
|
git diff --exit-code --quiet
|
|
'
|
|
|
|
test_expect_success 'non ambiguous call' '
|
|
git checkout all
|
|
'
|
|
|
|
test_expect_success 'allow the most common case' '
|
|
git checkout world &&
|
|
test "refs/heads/world" = "$(git symbolic-ref HEAD)"
|
|
'
|
|
|
|
test_expect_success 'check ambiguity' '
|
|
test_must_fail git checkout world all
|
|
'
|
|
|
|
test_expect_success 'check ambiguity in subdir' '
|
|
mkdir sub &&
|
|
# not ambiguous because sub/world does not exist
|
|
git -C sub checkout world ../all &&
|
|
echo hello >sub/world &&
|
|
# ambiguous because sub/world does exist
|
|
test_must_fail git -C sub checkout world ../all
|
|
'
|
|
|
|
test_expect_success 'disambiguate checking out from a tree-ish' '
|
|
echo bye > world &&
|
|
git checkout world -- world &&
|
|
git diff --exit-code --quiet
|
|
'
|
|
|
|
test_expect_success 'accurate error message with more than one ref' '
|
|
test_must_fail git checkout HEAD main -- 2>actual &&
|
|
test_i18ngrep 2 actual &&
|
|
test_i18ngrep "one reference expected, 2 given" actual
|
|
'
|
|
|
|
test_done
|