git/free.cocci at 96d4b17bd6610275c3ae9d810f1557abaf168a23 - git - git.dotya.ml

mirror/git

mirror of https://github.com/git/git.git synced 2024-11-19 09:54:09 +01:00

René Scharfe 76d8d45ffb coccinelle: polish FREE_AND_NULL rules

There are two rules for using FREE_AND_NULL in free.cocci, one for
pointer types and one for expressions.  Both cause coccinelle to remove
empty lines and even newline characters between replacements for some
reason; consecutive "free(x);/x=NULL;" sequences end up as multiple
FREE_AND_NULL calls on the same time.

Remove the type rule, as the expression rule already covers it, and
rearrange the lines of the latter to place the addition of FREE_AND_NULL
between the removals, which causes coccinelle to leave surrounding
whitespace untouched.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

2017-06-29 10:46:16 -07:00

19 lines

146 B

Plaintext

Raw Blame History

 @@
 expression E;
 @@
 - if (E)
   free(E);
 @@
 expression E;
 @@
 - if (!E)
   free(E);
 @@
 expression E;
 @@
 - free(E);
 + FREE_AND_NULL(E);
 - E = NULL;