mirror of
https://github.com/git/git.git
synced 2024-05-24 23:36:12 +02:00
6798b08e84
Fix misbehavior in Git.pm that dates back to the very first version of the library in git.git added inb1edc53d06(Introduce Git.pm (v4), 2006-06-24). When we fail to execute a command we shouldn't ignore all signals, those can happen e.g. if abort() is called, or if the command segfaults. Because of this we'd consider e.g. a command that died due to LSAN exiting with abort() successful, as is the case with the tests listed as running successfully with SANITIZE=leak in9081a421a6(checkout: fix "branch info" memory leaks, 2021-11-16). We did run them successfully, but only because we ignored these errors. This was then made worse by the use of "abort_on_error=1" for LSAN added in85b81b35ff(test-lib: set LSAN_OPTIONS to abort by default, 2017-09-05). Doing that makes sense, but without providing that option we'd have a "$? >> 8" of "23" on failure, with abort_on_error=1 we'll get "0". All of our tests pass even without the SIGPIPE exception being added here, but as the code appears to have been trying to ignore it let's keep ignoring it for now. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
33 lines
798 B
Bash
Executable File
33 lines
798 B
Bash
Executable File
#!/bin/sh
|
|
test_description='git svn rmdir'
|
|
|
|
. ./lib-git-svn.sh
|
|
|
|
test_expect_success 'initialize repo' '
|
|
mkdir import &&
|
|
(
|
|
cd import &&
|
|
mkdir -p deeply/nested/directory/number/1 &&
|
|
mkdir -p deeply/nested/directory/number/2 &&
|
|
echo foo >deeply/nested/directory/number/1/file &&
|
|
echo foo >deeply/nested/directory/number/2/another &&
|
|
svn_cmd import -m "import for git svn" . "$svnrepo"
|
|
)
|
|
'
|
|
|
|
test_expect_success 'mirror via git svn' '
|
|
git svn init "$svnrepo" &&
|
|
git svn fetch &&
|
|
git checkout -f -b test-rmdir remotes/git-svn
|
|
'
|
|
|
|
test_expect_success 'Try a commit on rmdir' '
|
|
git rm -f deeply/nested/directory/number/2/another &&
|
|
git commit -a -m "remove another" &&
|
|
git svn set-tree --rmdir HEAD &&
|
|
svn_cmd ls -R "$svnrepo" | grep ^deeply/nested/directory/number/1
|
|
'
|
|
|
|
|
|
test_done
|