mirror of
https://github.com/git/git.git
synced 2024-11-19 05:54:18 +01:00
c2e86addb8
Fix warnings from 'make check'. - These files don't include 'builtin.h' causing sparse to complain that cmd_* isn't declared: builtin/clone.c:364, builtin/fetch-pack.c:797, builtin/fmt-merge-msg.c:34, builtin/hash-object.c:78, builtin/merge-index.c:69, builtin/merge-recursive.c:22 builtin/merge-tree.c:341, builtin/mktag.c:156, builtin/notes.c:426 builtin/notes.c:822, builtin/pack-redundant.c:596, builtin/pack-refs.c:10, builtin/patch-id.c:60, builtin/patch-id.c:149, builtin/remote.c:1512, builtin/remote-ext.c:240, builtin/remote-fd.c:53, builtin/reset.c:236, builtin/send-pack.c:384, builtin/unpack-file.c:25, builtin/var.c:75 - These files have symbols which should be marked static since they're only file scope: submodule.c:12, diff.c:631, replace_object.c:92, submodule.c:13, submodule.c:14, trace.c:78, transport.c:195, transport-helper.c:79, unpack-trees.c:19, url.c:3, url.c:18, url.c:104, url.c:117, url.c:123, url.c:129, url.c:136, thread-utils.c:21, thread-utils.c:48 - These files redeclare symbols to be different types: builtin/index-pack.c:210, parse-options.c:564, parse-options.c:571, usage.c:49, usage.c:58, usage.c:63, usage.c:72 - These files use a literal integer 0 when they really should use a NULL pointer: daemon.c:663, fast-import.c:2942, imap-send.c:1072, notes-merge.c:362 While we're in the area, clean up some unused #includes in builtin files (mostly exec_cmd.h). Signed-off-by: Stephen Boyd <bebarino@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
116 lines
2.6 KiB
C
116 lines
2.6 KiB
C
#include "cache.h"
|
|
#include "sha1-lookup.h"
|
|
#include "refs.h"
|
|
#include "commit.h"
|
|
|
|
static struct replace_object {
|
|
unsigned char sha1[2][20];
|
|
} **replace_object;
|
|
|
|
static int replace_object_alloc, replace_object_nr;
|
|
|
|
static const unsigned char *replace_sha1_access(size_t index, void *table)
|
|
{
|
|
struct replace_object **replace = table;
|
|
return replace[index]->sha1[0];
|
|
}
|
|
|
|
static int replace_object_pos(const unsigned char *sha1)
|
|
{
|
|
return sha1_pos(sha1, replace_object, replace_object_nr,
|
|
replace_sha1_access);
|
|
}
|
|
|
|
static int register_replace_object(struct replace_object *replace,
|
|
int ignore_dups)
|
|
{
|
|
int pos = replace_object_pos(replace->sha1[0]);
|
|
|
|
if (0 <= pos) {
|
|
if (ignore_dups)
|
|
free(replace);
|
|
else {
|
|
free(replace_object[pos]);
|
|
replace_object[pos] = replace;
|
|
}
|
|
return 1;
|
|
}
|
|
pos = -pos - 1;
|
|
if (replace_object_alloc <= ++replace_object_nr) {
|
|
replace_object_alloc = alloc_nr(replace_object_alloc);
|
|
replace_object = xrealloc(replace_object,
|
|
sizeof(*replace_object) *
|
|
replace_object_alloc);
|
|
}
|
|
if (pos < replace_object_nr)
|
|
memmove(replace_object + pos + 1,
|
|
replace_object + pos,
|
|
(replace_object_nr - pos - 1) *
|
|
sizeof(*replace_object));
|
|
replace_object[pos] = replace;
|
|
return 0;
|
|
}
|
|
|
|
static int register_replace_ref(const char *refname,
|
|
const unsigned char *sha1,
|
|
int flag, void *cb_data)
|
|
{
|
|
/* Get sha1 from refname */
|
|
const char *slash = strrchr(refname, '/');
|
|
const char *hash = slash ? slash + 1 : refname;
|
|
struct replace_object *repl_obj = xmalloc(sizeof(*repl_obj));
|
|
|
|
if (strlen(hash) != 40 || get_sha1_hex(hash, repl_obj->sha1[0])) {
|
|
free(repl_obj);
|
|
warning("bad replace ref name: %s", refname);
|
|
return 0;
|
|
}
|
|
|
|
/* Copy sha1 from the read ref */
|
|
hashcpy(repl_obj->sha1[1], sha1);
|
|
|
|
/* Register new object */
|
|
if (register_replace_object(repl_obj, 1))
|
|
die("duplicate replace ref: %s", refname);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void prepare_replace_object(void)
|
|
{
|
|
static int replace_object_prepared;
|
|
|
|
if (replace_object_prepared)
|
|
return;
|
|
|
|
for_each_replace_ref(register_replace_ref, NULL);
|
|
replace_object_prepared = 1;
|
|
}
|
|
|
|
/* We allow "recursive" replacement. Only within reason, though */
|
|
#define MAXREPLACEDEPTH 5
|
|
|
|
const unsigned char *lookup_replace_object(const unsigned char *sha1)
|
|
{
|
|
int pos, depth = MAXREPLACEDEPTH;
|
|
const unsigned char *cur = sha1;
|
|
|
|
if (!read_replace_refs)
|
|
return sha1;
|
|
|
|
prepare_replace_object();
|
|
|
|
/* Try to recursively replace the object */
|
|
do {
|
|
if (--depth < 0)
|
|
die("replace depth too high for object %s",
|
|
sha1_to_hex(sha1));
|
|
|
|
pos = replace_object_pos(cur);
|
|
if (0 <= pos)
|
|
cur = replace_object[pos]->sha1[1];
|
|
} while (0 <= pos);
|
|
|
|
return cur;
|
|
}
|