mirror of
https://github.com/git/git.git
synced 2024-06-13 04:57:02 +02:00
c65d18cb52
Fix a memory leak that's been with us since this code was added inca02465b41(push: use remote.$name.push as a refmap, 2013-12-03). The "remote = remote_get(...)" added in the same commit would seem to leak based only on the context here, but that function is a wrapper for sticking the remotes we fetch into "the_repository->remote_state". Seefd3cb0501e(remote: move static variables into per-repository struct, 2021-11-17) for the addition of code in repository.c that free's the "remote" allocated here. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
46 lines
1.3 KiB
Bash
Executable File
46 lines
1.3 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='test disabling of git-over-ssh in clone/fetch'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
. "$TEST_DIRECTORY/lib-proto-disable.sh"
|
|
|
|
setup_ssh_wrapper
|
|
|
|
test_expect_success 'setup repository to clone' '
|
|
test_commit one &&
|
|
mkdir remote &&
|
|
git init --bare remote/repo.git &&
|
|
git push remote/repo.git HEAD
|
|
'
|
|
|
|
test_proto "host:path" ssh "remote:repo.git"
|
|
test_proto "ssh://" ssh "ssh://remote$PWD/remote/repo.git"
|
|
test_proto "git+ssh://" ssh "git+ssh://remote$PWD/remote/repo.git"
|
|
|
|
# Don't even bother setting up a "-remote" directory, as ssh would generally
|
|
# complain about the bogus option rather than completing our request. Our
|
|
# fake wrapper actually _can_ handle this case, but it's more robust to
|
|
# simply confirm from its output that it did not run at all.
|
|
test_expect_success 'hostnames starting with dash are rejected' '
|
|
test_must_fail git clone ssh://-remote/repo.git dash-host 2>stderr &&
|
|
! grep ^ssh: stderr
|
|
'
|
|
|
|
test_expect_success 'setup repo with dash' '
|
|
git init --bare remote/-repo.git &&
|
|
git push remote/-repo.git HEAD
|
|
'
|
|
|
|
test_expect_success 'repo names starting with dash are rejected' '
|
|
test_must_fail git clone remote:-repo.git dash-path 2>stderr &&
|
|
! grep ^ssh: stderr
|
|
'
|
|
|
|
test_expect_success 'full paths still work' '
|
|
git clone "remote:$PWD/remote/-repo.git" dash-path
|
|
'
|
|
|
|
test_done
|