mirror of
https://github.com/git/git.git
synced 2024-05-23 07:56:24 +02:00
aab4043851
When we "switch" to another local repository to run the server side of a fetch or push, we must clear the variables in local_repo_env so that our local $GIT_DIR, etc, do not pollute the upload-pack or receive-pack that is executing in the "remote" repository. We have never done so for ssh connections. For the most part, nobody has noticed because ssh will not pass unknown environment variables by default. However, it is not out of the question for a user to configure ssh to pass along GIT_* variables using SendEnv/AcceptEnv. We can demonstrate the problem by using "git -c" on a local command and seeing its impact on a remote repository. This config ends up in $GIT_CONFIG_PARAMETERS. In the local case, the config has no impact, but in the ssh transport, it does (our test script has a fake ssh that passes through all environment variables; this isn't normal, but does simulate one possible setup). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
35 lines
817 B
Bash
Executable File
35 lines
817 B
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='check environment showed to remote side of transports'
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'set up "remote" push situation' '
|
|
test_commit one &&
|
|
git config push.default current &&
|
|
git init remote
|
|
'
|
|
|
|
test_expect_success 'set up fake ssh' '
|
|
GIT_SSH_COMMAND="f() {
|
|
cd \"\$TRASH_DIRECTORY\" &&
|
|
eval \"\$2\"
|
|
}; f" &&
|
|
export GIT_SSH_COMMAND &&
|
|
export TRASH_DIRECTORY
|
|
'
|
|
|
|
# due to receive.denyCurrentBranch=true
|
|
test_expect_success 'confirm default push fails' '
|
|
test_must_fail git push remote
|
|
'
|
|
|
|
test_expect_success 'config does not travel over same-machine push' '
|
|
test_must_fail git -c receive.denyCurrentBranch=false push remote
|
|
'
|
|
|
|
test_expect_success 'config does not travel over ssh push' '
|
|
test_must_fail git -c receive.denyCurrentBranch=false push host:remote
|
|
'
|
|
|
|
test_done
|