mirror of
https://github.com/git/git.git
synced 2024-05-28 11:36:10 +02:00
1df15f8dee
clear_##slabname() frees only the memory allocated for a commit slab itself, but entries in the commit slab might own additional memory outside the slab that should be freed as well. We already have (at least) one such commit slab, and this patch series is about to add one more. To free all additional memory owned by entries on the commit slab the user of such a slab could iterate over all commits it knows about, peek whether there is a valid entry associated with each commit, and free the additional memory, if any. Or it could rely on intimate knowledge about the internals of the commit slab implementation, and could itself iterate directly through all entries in the slab, and free the additional memory. Or it could just leak the additional memory... Introduce deep_clear_##slabname() to allow releasing memory owned by commit slab entries by invoking the 'void free_fn(elemtype *ptr)' function specified as parameter for each entry in the slab. Use it in get_shallow_commits() in 'shallow.c' to replace an open-coded iteration over a commit slab's entries. Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Derrick Stolee <dstolee@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
45 lines
1.4 KiB
C
45 lines
1.4 KiB
C
#ifndef COMMIT_SLAB_HDR_H
|
|
#define COMMIT_SLAB_HDR_H
|
|
|
|
/* allocate ~512kB at once, allowing for malloc overhead */
|
|
#ifndef COMMIT_SLAB_SIZE
|
|
#define COMMIT_SLAB_SIZE (512*1024-32)
|
|
#endif
|
|
|
|
#define declare_commit_slab(slabname, elemtype) \
|
|
\
|
|
struct slabname { \
|
|
unsigned slab_size; \
|
|
unsigned stride; \
|
|
unsigned slab_count; \
|
|
elemtype **slab; \
|
|
}
|
|
|
|
/*
|
|
* Statically initialize a commit slab named "var". Note that this
|
|
* evaluates "stride" multiple times! Example:
|
|
*
|
|
* struct indegree indegrees = COMMIT_SLAB_INIT(1, indegrees);
|
|
*
|
|
*/
|
|
#define COMMIT_SLAB_INIT(stride, var) { \
|
|
COMMIT_SLAB_SIZE / sizeof(**((var).slab)) / (stride), \
|
|
(stride), 0, NULL \
|
|
}
|
|
|
|
#define declare_commit_slab_prototypes(slabname, elemtype) \
|
|
\
|
|
void init_ ##slabname## _with_stride(struct slabname *s, unsigned stride); \
|
|
void init_ ##slabname(struct slabname *s); \
|
|
void clear_ ##slabname(struct slabname *s); \
|
|
void deep_clear_ ##slabname(struct slabname *s, void (*free_fn)(elemtype *ptr)); \
|
|
elemtype *slabname## _at_peek(struct slabname *s, const struct commit *c, int add_if_missing); \
|
|
elemtype *slabname## _at(struct slabname *s, const struct commit *c); \
|
|
elemtype *slabname## _peek(struct slabname *s, const struct commit *c)
|
|
|
|
#define define_shared_commit_slab(slabname, elemtype) \
|
|
declare_commit_slab(slabname, elemtype); \
|
|
declare_commit_slab_prototypes(slabname, elemtype)
|
|
|
|
#endif /* COMMIT_SLAB_HDR_H */
|