mirror of
https://github.com/git/git.git
synced 2024-06-08 15:56:35 +02:00
c641ca6707
The code for a newly added path assumed that the path was a normal file, and thus checked for there being a directory still being in the way of the file. Note that since unpack_trees() does path-in-the-way checks already, the only way for there to be a directory in the way at this point in the code, is if there is some kind of D/F conflict in the merge. For a submodule addition on HEAD's side of history, the submodule would have already been present. This means that we do expect there to be a directory present but should not consider it to be "in the way"; instead, it's the expected submodule. So, when there's a submodule addition from HEAD's side, don't bother checking the working copy for a directory in the way. Signed-off-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
50 lines
1.1 KiB
Bash
Executable File
50 lines
1.1 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='cherry-pick can handle submodules'
|
|
|
|
. ./test-lib.sh
|
|
. "$TEST_DIRECTORY"/lib-submodule-update.sh
|
|
|
|
KNOWN_FAILURE_CHERRY_PICK_SEES_EMPTY_COMMIT=1
|
|
KNOWN_FAILURE_NOFF_MERGE_DOESNT_CREATE_EMPTY_SUBMODULE_DIR=1
|
|
KNOWN_FAILURE_NOFF_MERGE_ATTEMPTS_TO_MERGE_REMOVED_SUBMODULE_FILES=1
|
|
test_submodule_switch "git cherry-pick"
|
|
|
|
test_expect_success 'unrelated submodule/file conflict is ignored' '
|
|
test_create_repo sub &&
|
|
|
|
touch sub/file &&
|
|
git -C sub add file &&
|
|
git -C sub commit -m "add a file in a submodule" &&
|
|
|
|
test_create_repo a_repo &&
|
|
(
|
|
cd a_repo &&
|
|
>a_file &&
|
|
git add a_file &&
|
|
git commit -m "add a file" &&
|
|
|
|
git branch test &&
|
|
git checkout test &&
|
|
|
|
mkdir sub &&
|
|
>sub/content &&
|
|
git add sub/content &&
|
|
git commit -m "add a regular folder with name sub" &&
|
|
|
|
echo "123" >a_file &&
|
|
git add a_file &&
|
|
git commit -m "modify a file" &&
|
|
|
|
git checkout master &&
|
|
|
|
git submodule add ../sub sub &&
|
|
git submodule update sub &&
|
|
git commit -m "add a submodule info folder with name sub" &&
|
|
|
|
git cherry-pick test
|
|
)
|
|
'
|
|
|
|
test_done
|