mirror of
https://github.com/git/git.git
synced 2024-05-25 04:16:09 +02:00
9081a421a6
The "checkout" command is one of the main sources of leaks in the test
suite, let's fix the common ones by not leaking from the "struct
branch_info".
Doing this is rather straightforward, albeit verbose, we need to
xstrdup() constant strings going into the struct, and free() the ones
we clobber as we go along.
This also means that we can delete previous partial leak fixes in this
area, i.e. the "path_to_free" accounting added by 96ec7b1e70 (Convert
resolve_ref+xstrdup to new resolve_refdup function, 2011-12-13).
There was some discussion about whether "we should retain the "const
char *" here and cast at free() time, or have it be a "char *". Since
this is not a public API with any sort of API boundary let's use
"char *", as is already being done for the "refname" member of the
same struct.
The tests to mark as passing were found with:
rm .prove; GIT_SKIP_TESTS=t0027 prove -j8 --state=save t[0-9]*.sh :: --immediate
# apply & compile this change
prove -j8 --state=failed :: --immediate
I.e. the ones that were newly passing when the --state=failed command
was run. I left out "t3040-subprojects-basic.sh" and
"t4131-apply-fake-ancestor.sh" to to optimization-level related
differences similar to the ones noted in[1], except that these would
be something the current 'linux-leaks' job would run into.
1. https://lore.kernel.org/git/cover-v3-0.6-00000000000-20211022T175227Z-avarab@gmail.com/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
108 lines
2.4 KiB
Bash
Executable File
108 lines
2.4 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='read-tree -u --reset'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
. "$TEST_DIRECTORY"/lib-read-tree.sh
|
|
|
|
# two-tree test
|
|
|
|
test_expect_success 'setup' '
|
|
git init &&
|
|
mkdir df &&
|
|
echo content >df/file &&
|
|
git add df/file &&
|
|
git commit -m one &&
|
|
git ls-files >expect &&
|
|
rm -rf df &&
|
|
echo content >df &&
|
|
git add df &&
|
|
echo content >new &&
|
|
git add new &&
|
|
git commit -m two
|
|
'
|
|
|
|
test_expect_success 'reset should work' '
|
|
read_tree_u_must_succeed -u --reset HEAD^ &&
|
|
git ls-files >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'reset should remove remnants from a failed merge' '
|
|
read_tree_u_must_succeed --reset -u HEAD &&
|
|
git ls-files -s >expect &&
|
|
sha1=$(git rev-parse :new) &&
|
|
(
|
|
echo "100644 $sha1 1 old" &&
|
|
echo "100644 $sha1 3 old"
|
|
) | git update-index --index-info &&
|
|
>old &&
|
|
git ls-files -s &&
|
|
read_tree_u_must_succeed --reset -u HEAD &&
|
|
git ls-files -s >actual &&
|
|
! test -f old
|
|
'
|
|
|
|
test_expect_success 'two-way reset should remove remnants too' '
|
|
read_tree_u_must_succeed --reset -u HEAD &&
|
|
git ls-files -s >expect &&
|
|
sha1=$(git rev-parse :new) &&
|
|
(
|
|
echo "100644 $sha1 1 old" &&
|
|
echo "100644 $sha1 3 old"
|
|
) | git update-index --index-info &&
|
|
>old &&
|
|
git ls-files -s &&
|
|
read_tree_u_must_succeed --reset -u HEAD HEAD &&
|
|
git ls-files -s >actual &&
|
|
! test -f old
|
|
'
|
|
|
|
test_expect_success 'Porcelain reset should remove remnants too' '
|
|
read_tree_u_must_succeed --reset -u HEAD &&
|
|
git ls-files -s >expect &&
|
|
sha1=$(git rev-parse :new) &&
|
|
(
|
|
echo "100644 $sha1 1 old" &&
|
|
echo "100644 $sha1 3 old"
|
|
) | git update-index --index-info &&
|
|
>old &&
|
|
git ls-files -s &&
|
|
git reset --hard &&
|
|
git ls-files -s >actual &&
|
|
! test -f old
|
|
'
|
|
|
|
test_expect_success 'Porcelain checkout -f should remove remnants too' '
|
|
read_tree_u_must_succeed --reset -u HEAD &&
|
|
git ls-files -s >expect &&
|
|
sha1=$(git rev-parse :new) &&
|
|
(
|
|
echo "100644 $sha1 1 old" &&
|
|
echo "100644 $sha1 3 old"
|
|
) | git update-index --index-info &&
|
|
>old &&
|
|
git ls-files -s &&
|
|
git checkout -f &&
|
|
git ls-files -s >actual &&
|
|
! test -f old
|
|
'
|
|
|
|
test_expect_success 'Porcelain checkout -f HEAD should remove remnants too' '
|
|
read_tree_u_must_succeed --reset -u HEAD &&
|
|
git ls-files -s >expect &&
|
|
sha1=$(git rev-parse :new) &&
|
|
(
|
|
echo "100644 $sha1 1 old" &&
|
|
echo "100644 $sha1 3 old"
|
|
) | git update-index --index-info &&
|
|
>old &&
|
|
git ls-files -s &&
|
|
git checkout -f HEAD &&
|
|
git ls-files -s >actual &&
|
|
! test -f old
|
|
'
|
|
|
|
test_done
|