mirror of
https://github.com/git/git.git
synced 2024-05-24 00:16:31 +02:00
05ac8582bc
On Cygwin, the codepath for POSIX-like systems is taken in run-command.c::start_command(). The prepare_cmd() helper function is called to decide if the command needs to be looked up in the PATH. The logic there is to do the PATH-lookup if and only if it does not have any slash '/' in it. If this test passes we end up attempting to run the command by appending the string after each colon-separated component of PATH. The Cygwin environment supports both Windows and POSIX style paths, so both forwardslahes '/' and back slashes '\' can be used as directory separators for any external program the user supplies. Examples for path strings which are being incorrectly searched for in the PATH instead of being executed as is: - "C:\Program Files\some-program.exe" - "a\b\c.exe" To handle these, the PATH lookup detection logic in prepare_cmd() is taught to know about this Cygwin quirk, by introducing has_dir_sep(path) helper function to abstract away the difference between true POSIX and Cygwin systems. Signed-off-by: Andras Kucsma <r0maikx02b@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
38 lines
1.1 KiB
C
38 lines
1.1 KiB
C
#ifndef WIN32_PATH_UTILS_H
|
|
#define WIN32_PATH_UTILS_H
|
|
|
|
int win32_has_dos_drive_prefix(const char *path);
|
|
#define has_dos_drive_prefix win32_has_dos_drive_prefix
|
|
|
|
int win32_skip_dos_drive_prefix(char **path);
|
|
#define skip_dos_drive_prefix win32_skip_dos_drive_prefix
|
|
static inline int win32_is_dir_sep(int c)
|
|
{
|
|
return c == '/' || c == '\\';
|
|
}
|
|
#define is_dir_sep win32_is_dir_sep
|
|
static inline char *win32_find_last_dir_sep(const char *path)
|
|
{
|
|
char *ret = NULL;
|
|
for (; *path; ++path)
|
|
if (is_dir_sep(*path))
|
|
ret = (char *)path;
|
|
return ret;
|
|
}
|
|
#define find_last_dir_sep win32_find_last_dir_sep
|
|
static inline int win32_has_dir_sep(const char *path)
|
|
{
|
|
/*
|
|
* See how long the non-separator part of the given path is, and
|
|
* if and only if it covers the whole path (i.e. path[len] is NUL),
|
|
* there is no separator in the path---otherwise there is a separator.
|
|
*/
|
|
size_t len = strcspn(path, "/\\");
|
|
return !!path[len];
|
|
}
|
|
#define has_dir_sep(path) win32_has_dir_sep(path)
|
|
int win32_offset_1st_component(const char *path);
|
|
#define offset_1st_component win32_offset_1st_component
|
|
|
|
#endif
|