mirror of
https://github.com/git/git.git
synced 2024-04-26 17:05:15 +02:00
92a209bf24
As of curl 7.66.0, we don't need to manually specify a "chunked" Transfer-Encoding header. Instead, modern curl deduces the need for it in a POST that has a POSTFIELDSIZE of -1 and uses READFUNCTION rather than POSTFIELDS. That version is recent enough that we can't just drop the header; we need to do so conditionally. Since it's only a single line, it seems like the simplest thing would just be to keep setting it unconditionally (after all, the #ifdefs are much longer than the actual code). But there's another wrinkle: HTTP/2. Curl may choose to use HTTP/2 under the hood if the server supports it. And in that protocol, we do not use the chunked encoding for streaming at all. Most versions of curl handle this just fine by recognizing and removing the header. But there's a regression in curl 8.7.0 and 8.7.1 where it doesn't, and large requests over HTTP/2 are broken (which t5559 notices). That regression has since been fixed upstream, but not yet released. Make the setting of this header conditional, which will let Git work even with those buggy curl versions. And as a bonus, it serves as a reminder that we can eventually clean up the code as we bump the supported curl versions. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
147 lines
4.1 KiB
C
147 lines
4.1 KiB
C
#ifndef GIT_CURL_COMPAT_H
|
|
#define GIT_CURL_COMPAT_H
|
|
#include <curl/curl.h>
|
|
|
|
/**
|
|
* This header centralizes the declaration of our libcurl dependencies
|
|
* to make it easy to discover the oldest versions we support, and to
|
|
* inform decisions about removing support for older libcurl in the
|
|
* future.
|
|
*
|
|
* The oldest supported version of curl is documented in the "INSTALL"
|
|
* document.
|
|
*
|
|
* The source of truth for what versions have which symbols is
|
|
* https://github.com/curl/curl/blob/master/docs/libcurl/symbols-in-versions;
|
|
* the release dates are taken from curl.git (at
|
|
* https://github.com/curl/curl/).
|
|
*
|
|
* For each X symbol we need from curl we define our own
|
|
* GIT_CURL_HAVE_X. If multiple similar symbols with the same prefix
|
|
* were defined in the same version we pick one and check for that name.
|
|
*
|
|
* We may also define a missing CURL_* symbol to its known value, if
|
|
* doing so is sufficient to add support for it to older versions that
|
|
* don't have it.
|
|
*
|
|
* Keep any symbols in date order of when their support was
|
|
* introduced, oldest first, in the official version of cURL library.
|
|
*/
|
|
|
|
/**
|
|
* CURL_SOCKOPT_OK was added in 7.21.5, released in April 2011.
|
|
*/
|
|
#if LIBCURL_VERSION_NUM < 0x071505
|
|
#define CURL_SOCKOPT_OK 0
|
|
#endif
|
|
|
|
/**
|
|
* CURLOPT_TCP_KEEPALIVE was added in 7.25.0, released in March 2012.
|
|
*/
|
|
#if LIBCURL_VERSION_NUM >= 0x071900
|
|
#define GITCURL_HAVE_CURLOPT_TCP_KEEPALIVE 1
|
|
#endif
|
|
|
|
|
|
/**
|
|
* CURLOPT_LOGIN_OPTIONS was added in 7.34.0, released in December
|
|
* 2013.
|
|
*
|
|
* If we start requiring 7.34.0 we might also be able to remove the
|
|
* code conditional on USE_CURL_FOR_IMAP_SEND in imap-send.c, see
|
|
* 1e16b255b95 (git-imap-send: use libcurl for implementation,
|
|
* 2014-11-09) and the check it added for "072200" in the Makefile.
|
|
|
|
*/
|
|
#if LIBCURL_VERSION_NUM >= 0x072200
|
|
#define GIT_CURL_HAVE_CURLOPT_LOGIN_OPTIONS 1
|
|
#endif
|
|
|
|
/**
|
|
* CURL_SSLVERSION_TLSv1_[012] was added in 7.34.0, released in
|
|
* December 2013.
|
|
*/
|
|
#if LIBCURL_VERSION_NUM >= 0x072200
|
|
#define GIT_CURL_HAVE_CURL_SSLVERSION_TLSv1_0
|
|
#endif
|
|
|
|
/**
|
|
* CURLOPT_PINNEDPUBLICKEY was added in 7.39.0, released in November
|
|
* 2014. CURLE_SSL_PINNEDPUBKEYNOTMATCH was added in that same version.
|
|
*/
|
|
#if LIBCURL_VERSION_NUM >= 0x072c00
|
|
#define GIT_CURL_HAVE_CURLOPT_PINNEDPUBLICKEY 1
|
|
#define GIT_CURL_HAVE_CURLE_SSL_PINNEDPUBKEYNOTMATCH 1
|
|
#endif
|
|
|
|
/**
|
|
* CURL_HTTP_VERSION_2 was added in 7.43.0, released in June 2015.
|
|
*
|
|
* The CURL_HTTP_VERSION_2 alias (but not CURL_HTTP_VERSION_2_0) has
|
|
* always been a macro, not an enum field (checked on curl version
|
|
* 7.78.0)
|
|
*/
|
|
#if LIBCURL_VERSION_NUM >= 0x072b00
|
|
#define GIT_CURL_HAVE_CURL_HTTP_VERSION_2 1
|
|
#endif
|
|
|
|
/**
|
|
* CURLSSLOPT_NO_REVOKE was added in 7.44.0, released in August 2015.
|
|
*
|
|
* The CURLSSLOPT_NO_REVOKE is, has always been a macro, not an enum
|
|
* field (checked on curl version 7.78.0)
|
|
*/
|
|
#if LIBCURL_VERSION_NUM >= 0x072c00
|
|
#define GIT_CURL_HAVE_CURLSSLOPT_NO_REVOKE 1
|
|
#endif
|
|
|
|
/**
|
|
* CURLOPT_PROXY_CAINFO was added in 7.52.0, released in August 2017.
|
|
*/
|
|
#if LIBCURL_VERSION_NUM >= 0x073400
|
|
#define GIT_CURL_HAVE_CURLOPT_PROXY_CAINFO 1
|
|
#endif
|
|
|
|
/**
|
|
* CURLOPT_PROXY_{KEYPASSWD,SSLCERT,SSLKEY} was added in 7.52.0,
|
|
* released in August 2017.
|
|
*/
|
|
#if LIBCURL_VERSION_NUM >= 0x073400
|
|
#define GIT_CURL_HAVE_CURLOPT_PROXY_KEYPASSWD 1
|
|
#endif
|
|
|
|
/**
|
|
* CURL_SSLVERSION_TLSv1_3 was added in 7.53.0, released in February
|
|
* 2017.
|
|
*/
|
|
#if LIBCURL_VERSION_NUM >= 0x073400
|
|
#define GIT_CURL_HAVE_CURL_SSLVERSION_TLSv1_3 1
|
|
#endif
|
|
|
|
/**
|
|
* CURLSSLSET_{NO_BACKENDS,OK,TOO_LATE,UNKNOWN_BACKEND} were added in
|
|
* 7.56.0, released in September 2017.
|
|
*/
|
|
#if LIBCURL_VERSION_NUM >= 0x073800
|
|
#define GIT_CURL_HAVE_CURLSSLSET_NO_BACKENDS
|
|
#endif
|
|
|
|
/**
|
|
* Versions before curl 7.66.0 (September 2019) required manually setting the
|
|
* transfer-encoding for a streaming POST; after that this is handled
|
|
* automatically.
|
|
*/
|
|
#if LIBCURL_VERSION_NUM < 0x074200
|
|
#define GIT_CURL_NEED_TRANSFER_ENCODING_HEADER
|
|
#endif
|
|
|
|
/**
|
|
* CURLOPT_PROTOCOLS_STR and CURLOPT_REDIR_PROTOCOLS_STR were added in 7.85.0,
|
|
* released in August 2022.
|
|
*/
|
|
#if LIBCURL_VERSION_NUM >= 0x075500
|
|
#define GIT_CURL_HAVE_CURLOPT_PROTOCOLS_STR 1
|
|
#endif
|
|
|
|
#endif
|